Received-SPF: pass (google.com: domain of linux-crypto+bounces-1223-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Wed, 3 Jan 2024 17:07:41 +0000
From: "Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>
To: Arnd Bergmann <arnd@kernel.org>
CC: Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller"
	<davem@davemloft.net>, Damian Muszynski <damian.muszynski@intel.com>, "Arnd
 Bergmann" <arnd@arndb.de>, Tom Zanussi <tom.zanussi@linux.intel.com>, "Jie
 Wang" <jie.wang@intel.com>, <qat-linux@intel.com>,
	<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] crypto: qat - avoid memcpy() overflow warning
Message-ID: <ZZWUXcHBwTJjiT/H@gcabiddu-mobl.ger.corp.intel.com>
References: <20240103162608.987145-1-arnd@kernel.org>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240103162608.987145-1-arnd@kernel.org>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?gV91LtlBMC7701PJ5PZyP7h7qHA0STnxKzDD73jbAVJtO6Xr3rpliad/nu7e?=
 =?us-ascii?Q?nF0qJzbDBUU25zZpNg8JeEpN0SHXbQMWZWeUNEaWqbLMezWypQtTe8CGG6gU?=
 =?us-ascii?Q?2aDfGpGMsBnSdNIxA/029JhaNZTt+UaC1TpNK8lfdNdV3AYHRefA/0jDHIvx?=
 =?us-ascii?Q?srPxtSlD9oLyhu+rkIqH9xsADXv4ej96rlc/LUL17jl7Vhg8FG2l7R5myIgO?=
 =?us-ascii?Q?vT7YjkQfMUHddk0oYAQ6M1U6dQk/xfS9RqlmWwrI+clIlfcM3fFNwpFhY7J5?=
 =?us-ascii?Q?gUO2PaIktwp8h2W3sZJ+0gqn+heYhGlKUzGqv/EsCLUPk8I9U1k3676FDfy5?=
 =?us-ascii?Q?/uXw85TnLgSCF2j/NN0tDUYE+Iu68xRHKq+N2gXPUO25XXUQ69B7AKN6IRLp?=
 =?us-ascii?Q?ixQmOO4+A6zkuU+hSiDT4L4DpEuQpqkZJiAImsTfZLqXW7d1XEc5NwsbNBbK?=
 =?us-ascii?Q?sbNss8X/U7zbueOBAG/WwyvBXnL1G5QHzcOcnih1stH/6AnI3htn3z3CnxUK?=
 =?us-ascii?Q?LPoN9ZN3JA7MKZrEQydt6jhEVZEa+ph03aykmozcHgUfqqSXiwqSfxxc6Haf?=
 =?us-ascii?Q?Go2pwS3kAUOoZsFJVSzMJs8gT39lc7IjCeddFKy/0IM3CUFAVBNmLvgr6mDR?=
 =?us-ascii?Q?JyOfCtCg4hiSRcg3KUpkNcAafUJ05cB3aOfgAcJgTwEnDR7CEDOWCB47K+4O?=
 =?us-ascii?Q?o4p/4UAytJl611fUhQDt8l1FI5XErQaifnmCiji+pkXGXk82/vNcUsXWA9jI?=
 =?us-ascii?Q?9McUY52epGIxDs7ncsv5tzacc3gzg0KyY4YSCtDaS+pBTO/dXRLMqwdKzXPz?=
 =?us-ascii?Q?9vsMX3573lkO8vHNfMWgKBt8niBpvrgExic4sq4dHRfkidwY9Mex5X5P+6Uh?=
 =?us-ascii?Q?/w1i9I+Rr4Bykv9h/AJ3zJYnjgPpb+K3gzf5pDnOisLv8SmXDtGCAKjILAOX?=
 =?us-ascii?Q?FEvr8m9VPZFvFOOdVVWmKKC+7ZGnOFsPHyJOObwG1FAV7F2LjoVULor1cBy6?=
 =?us-ascii?Q?nQByoE8E94gZtYmnyzqLWuBXJo2rupiS9aYyVKqc4gYZ9Fg4XnIICEZoR+kw?=
 =?us-ascii?Q?eEX8KVntiUiZtJJGAtSMIXK45vk8PONA98GI3iWKh+3GBxhnnX2Izvi1UMl6?=
 =?us-ascii?Q?OoC9xhvdeQHn3oIbAxmQ+iWqtbssTHMVa0y2OSSIIf83z2v1jh1eQOjvpATX?=
 =?us-ascii?Q?Kxp3rGmz83KIMda0zPrVOH5on4UYupmjV+GtwLlSoZYuda2O8zTpQlErjfrI?=
 =?us-ascii?Q?7qtf2dcYzWuzji5ZPSopoBYsSYTQI+FUXgKBYCYP1kf3CrkeJAor2+01JeYm?=
 =?us-ascii?Q?nGD+ocwFpsrFHLS9/yTT408tlqELTc/yqeoyjOlF+yvYSifzz9h8FnzhE3uc?=
 =?us-ascii?Q?ZeryUSsKRxXjozzAjm/9rI/enBFQEGh4datxAvFkC0imzc01xs70Nfv9ryLk?=
 =?us-ascii?Q?yhcI99o1c7RFTr2ZOMfrgN2QgEzNbwvaOojNGI5rL8bFkNV3nzAGXt/EeKHn?=
 =?us-ascii?Q?UqsLsMzojxUOx/8kH8DrJxyTV+sK052Pk65rrnohMBZjaHM5WuJGedH852cO?=
 =?us-ascii?Q?EGMZ2nEVNT4iMOz4hYoWcyebnmz4CdrOxVUKTtiw0rOy45CrZMyc5e4sDPno?=
 =?us-ascii?Q?2w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: e50c40aa-6cc8-46fa-a79d-08dc0c7e8642
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Jan 2024 17:07:53.8890
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: voOJ6O/xfx3fbpWKT1CHio4WMMuXNMXWA4hQDKXbpqTMuIb46W4bBFWlAih7piNvthkncS8jfzU1EF1OfB9F4ZlTlEE77ifrmmS2z8lcJb0=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN6PR11MB8220
X-OriginatorOrg: intel.com

On Wed, Jan 03, 2024 at 05:26:02PM +0100, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@arndb.de>
> 
> The use of array_size() leads gcc to assume the memcpy() can have a larger
> limit than actually possible, which triggers a string fortification warning:
> 
> In file included from include/linux/string.h:296,
>                  from include/linux/bitmap.h:12,
>                  from include/linux/cpumask.h:12,
>                  from include/linux/sched.h:16,
>                  from include/linux/delay.h:23,
>                  from include/linux/iopoll.h:12,
>                  from drivers/crypto/intel/qat/qat_common/adf_gen4_hw_data.c:3:
> In function 'fortify_memcpy_chk',
>     inlined from 'adf_gen4_init_thd2arb_map' at drivers/crypto/intel/qat/qat_common/adf_gen4_hw_data.c:401:3:
> include/linux/fortify-string.h:579:4: error: call to '__write_overflow_field' declared with attribute warning: detected write beyond size of field (1st parameter); maybe use struct_group()? [-Werror=attribute-warning]
>   579 |    __write_overflow_field(p_size_field, size);
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> include/linux/fortify-string.h:588:4: error: call to '__read_overflow2_field' declared with attribute warning: detected read beyond size of field (2nd parameter); maybe use struct_group()? [-Werror=attribute-warning]
>   588 |    __read_overflow2_field(q_size_field, size);
>       |    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
> 
> Add an explicit range check to avoid this.
> 
> Fixes: 5da6a2d5353e ("crypto: qat - generate dynamically arbiter mappings")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Acked-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>