Received-SPF: pass (google.com: domain of linux-crypto+bounces-1258-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Fri, 5 Jan 2024 17:44:15 +0000
From: "Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>
To: Geert Uytterhoeven <geert@linux-m68k.org>
CC: Jie Wang <jie.wang@intel.com>, <herbert@gondor.apana.org.au>,
	<linux-crypto@vger.kernel.org>, <qat-linux@intel.com>,
	<linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 5/5] crypto: qat - add support for 420xx devices
Message-ID: <ZZg/7+7XPXyR06CG@gcabiddu-mobl.ger.corp.intel.com>
References: <20231215100147.1703641-1-jie.wang@intel.com>
 <20231215100147.1703641-6-jie.wang@intel.com>
 <c6662ee1-9c2a-49fb-917f-2a3586f636b4@linux-m68k.org>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <c6662ee1-9c2a-49fb-917f-2a3586f636b4@linux-m68k.org>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?g7dLtz5fdyqKEnGVF+fjJfK9ANa1UqovuRvzSrH5nbYKTLWUquz9RHduOu?=
 =?iso-8859-1?Q?oBuzvxPiTsFQlLbYKvV/9NBsBkAtYMB9UdmN5GbS9cKsCwjeuVub0mB4LO?=
 =?iso-8859-1?Q?l3tYdGIq+NVhk3IgmziklFQoSEEXfCagAfWlAzQFmnbaVM8hc9zUmd3Xk6?=
 =?iso-8859-1?Q?Qi2TsMwLoIqKiLUHb4XKhTCJWh0jX9S305vx9rorQc5xhx+ktsi34Kvv6X?=
 =?iso-8859-1?Q?3zZ2Gode0Nr+rzbMMSGPqBU6/36N1V7URpfuP3mD1NXh3izMLvf1cxLIf6?=
 =?iso-8859-1?Q?WIj6HHoxjZyJ+Lbs6QljN3CdcesG9hns53JmwqodhKNB3cgeIm+VbqIq78?=
 =?iso-8859-1?Q?/gfa2TxPtviUzhjwC3rU7AtyJs5mW6z/nRPV0Eox0bw+34hRv6G2LyDRsb?=
 =?iso-8859-1?Q?O/Ksk8vDf+mM3lG3ZuR2IGe/HYaHe8cnQ3OGRsFZcnB2q8LUrcQxkbkRFC?=
 =?iso-8859-1?Q?scthK/KUBeZfz+4F/hntuj+3rfsT9ughvL0xOb47SZBYf1LH0vN0CWnPw4?=
 =?iso-8859-1?Q?2Qe1UdHbYbhDl4jbpkK20DONLr9LWMckbDlllfpXtqDajF4WHfRymJ7BlI?=
 =?iso-8859-1?Q?hGOImyY1ChkiMcB/ehllhKlRb/fuNI7EE5M1pDU/D0u12vpJd/xHDvoO3L?=
 =?iso-8859-1?Q?hUfQVX/sgDjkCTW40d3aUcxsZ/rynViWmrlqmWJhnwg8j7ijC4+npMUxa1?=
 =?iso-8859-1?Q?aWMuMLx4FerL0mu6p2uq4F6c0o32I8KXBjki/yJtjprZJinIBLGALwTngV?=
 =?iso-8859-1?Q?l3ilyD/0tb/relx0lybUiOASdPYV6lk90n3IteS99x8PrL+dhQdfzo0H15?=
 =?iso-8859-1?Q?JCii/WbZxfNri3WToSvFcVYEiMUfVLaezmhPQ/CZPNilWozrFl70cOioxF?=
 =?iso-8859-1?Q?gs6I5ATwZjDBPJIF/FEpEfgnn+3hmRff5BLCKilf6pMpEgSwdUyZfNqkUR?=
 =?iso-8859-1?Q?tr4QWZyUFGn/9Rj1eRfCSh+VY3wdDnagNzbuJOiVWze/j4vLD/iMvclTsw?=
 =?iso-8859-1?Q?bHhskXFfa0NVo7GJ7RbB7vNmGuY185YihaBCzHqUw5XuqYHL85obQxMqXR?=
 =?iso-8859-1?Q?vE56qkI2UbteqRYOY2zzhCIz7eYG+cYaAACWv21/uawfdI87oH3y7hVQkx?=
 =?iso-8859-1?Q?8XOPH5Yf3hou80MBkhYQrnShsMDvnqrZ5d7aR6VfhvCRLl6+bB+YrJXU9Z?=
 =?iso-8859-1?Q?tiNz16zaSbnVsduBiUTV/biBZ+7KurnuhPWVGtS2YbK9wFnj6Lt+9v6rlz?=
 =?iso-8859-1?Q?z2MvSMenYv0oDjSLCb508HKNMXeQ6KUhukrE1A07pVBcM7RTLk1960vHxa?=
 =?iso-8859-1?Q?g8FsE3lAmY4VrrtdRIiw7cTdX94+sXVkqeyvLu5qter6zAFUw/wnfc5CW+?=
 =?iso-8859-1?Q?+AuCPzb93Caiih5nshRe/Pu6zHzCCqpnK4FbAm7mK+XigmXQrcA2mhmhkm?=
 =?iso-8859-1?Q?sMF6+E/vnlaVxIG9Xlvf+fIY48yLJTmgy91gdc+ASgmuZ3Z99w6cSJxVwV?=
 =?iso-8859-1?Q?ZVzPsFWDke6ri7wusBznfzaQLmWY6TYPxCEQnnt/PgjUZUvrKkkc/oxRlz?=
 =?iso-8859-1?Q?aUQmPHxbmzzVHYuU/8wKso/QFJf3nJyUlN+MNm8LAd1IHj6K+bSH9vFy10?=
 =?iso-8859-1?Q?Fhu+mqA3NewKo71DfnLTi9iPYH+qtyTRbX7CUaYbxy0PlPHtTlTiWC4g?=
 =?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 95dbb901-871f-4671-298a-08dc0e15f515
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 05 Jan 2024 17:44:25.0770
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: UUlTPkkJvD4gh+rnY+wxH52j31DiklpLDEEDRrmT+wYwW2v4yM6+fcgbSF4FeOFOvBhRR3+Lo9o7ANdYneroKXFH4UddmpnrUZ/h1BD6YBY=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA0PR11MB7935
X-OriginatorOrg: intel.com

Hi Geert,

On Tue, Dec 26, 2023 at 12:31:20PM +0100, Geert Uytterhoeven wrote:
> On Fri, 15 Dec 2023, Jie Wang wrote:
> > --- a/drivers/crypto/intel/qat/Kconfig
> > +++ b/drivers/crypto/intel/qat/Kconfig
> > @@ -59,6 +59,17 @@ config CRYPTO_DEV_QAT_4XXX
> > 	  To compile this as a module, choose M here: the module
> > 	  will be called qat_4xxx.
> > 
> > +config CRYPTO_DEV_QAT_420XX
> > +	tristate "Support for Intel(R) QAT_420XX"
> > +	depends on PCI && (!CPU_BIG_ENDIAN || COMPILE_TEST)
> 
> These dependencies suggest that the QAT_420XX device can be present and
> used on any little-endian system that supports PCIe (arm64, MIPS,
> PowerPC, RISC-V, ...).
> 
> However, [1] says QAT is only present on intel Atom? C5000, P5300, and
> P5700 processors, implying the dependency should rather be
> 
>     depends on PCI && (X86_64 || COMPILE_TEST)
> 
> Which one is correct?
Thanks for spotting this.

For this particular device it should be X86_64.

Plug-in cards devices (e.g. DH895xCC), instead, should stay !CPU_BIG_ENDIAN
as they can be used on any little-endian system.

I'm going to send a patch to change this.

-- 
Giovanni