Received-SPF: pass (google.com: domain of linux-crypto+bounces-1292-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <a77797fd-cbe4-42be-abd6-54cc815d360a@hpe.com>
Date: Tue, 9 Jan 2024 10:10:00 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] KEYS: include header for EINVAL definition
Content-Language: en-US
To: Jarkko Sakkinen <jarkko@kernel.org>, <keyrings@vger.kernel.org>,
        <linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC: <dhowells@redhat.com>, <herbert@gondor.apana.org.au>,
        <davem@davemloft.net>
References: <20240107132842.4024084-1-clayc@hpe.com>
 <CY9E6M2BYETA.1VE73N3UHD4B9@suppilovahvero>
From: Clay Chang <clayc@hpe.com>
In-Reply-To: <CY9E6M2BYETA.1VE73N3UHD4B9@suppilovahvero>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?a1FaVzRyMDkydGEzSEpaOHNuYUplVFFWL3lMWUcwNlJnRm5EY25hNS9DajdT?=
 =?utf-8?B?a25tb282NDJkdjN2b3ppU1hsRDJzN1hQRVQyVXFweEljOGRoWE5haktjaTQ5?=
 =?utf-8?B?VmJzeWJiMzFEd283SGxZVkxhWSswZUZsT1ZUMHN6YzFqQmtSQ25vY1R5M1FO?=
 =?utf-8?B?ZC9iS09Ock56RXFkTmQwMUJUZU1OdUZyazhXc3g3WWFEYlNlTEcxMkRGbXd5?=
 =?utf-8?B?TjhTVjhhakxtRFkvOHBybFVVUUpTNWZjTUVOVHJySzIzRWQ4UE03VnVNa0xM?=
 =?utf-8?B?NXpSd251L1VvWVV6WE5UcjM4WXFOY3k1SXdTTTdZL1hjZVZ1SjJXR0pwSGNJ?=
 =?utf-8?B?R2pmNVBuTjE5SmxyVU5kY1IzY0tybUw4Y3YzbkM4SWQrMWY2bGZXRGRlSFhT?=
 =?utf-8?B?VzF0QjZTTzVZd0V6TTQ0Vk5va3owR0REK25iOFJObGtzcEZtRkhJS09aUHRK?=
 =?utf-8?B?NkFCNGE2ZE82WHZOeXhueFRnbDgyV3VpeDF5Y05weDE1aUJ3ekYrSXRJZklF?=
 =?utf-8?B?cnkreWdTUzR3NnkvNFpBV2Iwakg5bUxNSU9HRFhYWll3OUVUUEJKK3JJWUlB?=
 =?utf-8?B?NFRhY0ZkaWQ3ckp0a25BT1k1SE1VMy9UaWpkWXdZaHJMVjIvL2g1d1dDT1RV?=
 =?utf-8?B?K2p6Mm5HNm8rQndxUDdtTWFUbjhPdlJxZEtlai9WdzhjdEltcnlmNllPWG9J?=
 =?utf-8?B?R0pDeTk1cytEQWJzSFRFSTZUdEVkU0hGaFcyZkowT1RZNGoyR3V4WTRYMzZK?=
 =?utf-8?B?Umt5OGM2YzRIcDJzOXUyaFAvNi84bDFEU2EwcFMwdnk2UW12bTFKNDNhTk9Z?=
 =?utf-8?B?eUMwQXFIbk1HUkRtQ08vK1Y3aGlCWXNiN1Z5VFBIaElsM1BvcnNQdUhlZXdB?=
 =?utf-8?B?TDBKNDhPeFo3ajFkMmUySnNFRzR1NmZVQ3I4Y29iMTlpL0ZCRENXOTduejlx?=
 =?utf-8?B?VUdWN1BTVmIzWWhxSmtqbVRTcGZvemxpVjVQSVVzY3lBNDFtMUpndkVpRkR6?=
 =?utf-8?B?b0xtaHZZQ04zdkxQNWlLZ2ZNazZZb1M3dGxDdzgvVTJ3S0FYSjFpYTUrMito?=
 =?utf-8?B?Qm5jYytNZG9jajBlWkw1UTJLYUxyQmpMRGJnR0VhUVA4dTFSNDh4bXVJMWtq?=
 =?utf-8?B?WDZsNlhxakx6NmFzQmxRRzdVQnhyU1RNNElzSmZLT3h2VzFnL0NiUFZDbmNX?=
 =?utf-8?B?ZjhrOVN2elZNcWpUYUpydWphL3FnTXRGRXpoNEFzc3dvdDFvcWdYZTNlY2FY?=
 =?utf-8?B?TXE4dmF3dHpWcEZtbVliV1RrTjYrQUZwckdaMmc4dFVlQm9ZaVIvYkZtb09p?=
 =?utf-8?B?b0lCVTQrbWFIRjlmZ2M1WEpWYWxUR2hYZGl6TXpzcTRzS2VHNkFDWHhObjcx?=
 =?utf-8?B?OHh2MlJWM0NNN1R1RXZIeFlMT29VUjJMS2VOeSttbUpWdlQ5U0w1b0V5RmlM?=
 =?utf-8?B?aHVFcTg1L3VOTUJ5SkJwclA4aW5wdzBmZFdWaVAzSTZ5ZkxYRDdZKzExSEJp?=
 =?utf-8?B?b3lsczJtTEd2OTdxUHB1R2NlT3hqM01CWFJia2R6L1BrTXJTNnRPZzh4SVJ3?=
 =?utf-8?B?YlR1cTFveHViRmYwRUYrV3JPaFJNV05WUk1SdC9TczFmbzZ0elBNN2J4dkFJ?=
 =?utf-8?B?L2NrcHRNTUpDSUNZaEo1TmZyRWZrWlpEbDlMS3Z2VkdFS3BHbUpNMjlDbUFC?=
 =?utf-8?B?VjJqRTRad1g1UkNqUFlNK3ZrZFdBQ2pVSmlZaDhVNjgzTGpQRmduWnIzcVho?=
 =?utf-8?B?c2NOT0x0TDJqRHhyNThuRUpkdkNOSDRMNU5oQ0ZjV09aQXFDdm5PeitPa3Z3?=
 =?utf-8?B?NGl6T1NyNjhYYm8rV3JHLzRHQmZFVFRqcCtHSTZWQ1NBKzlqUk05Vm5NYTE4?=
 =?utf-8?B?R2JHeUlZYmZSWnBvVUljMmFNQlJxU2g0cmNialBkSy9VSHhLVGdmeFN3VUVM?=
 =?utf-8?B?WEU2NXdENkdxMzZMamZ4dW96d1ZDRExTUmZVWWdiN1FTZFQzU2ZoZEwvNWxJ?=
 =?utf-8?B?OFphTEg0VGFkdnYyRWlvRkpvV3N2Y1N3V0FHQm00aHpkOXpJS1pGNWkrd2FL?=
 =?utf-8?B?NUZ1Slo0dHREdHJKMndZOXJDd0NlVHdUSjdiYnJRT2VKYjlBejRqaTF0TW9s?=
 =?utf-8?Q?UUys=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9cb2d217-8ac8-427a-02f7-08dc10b81881
X-MS-Exchange-CrossTenant-AuthSource: PH0PR84MB1480.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 Jan 2024 02:10:05.3726
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: jplne57d9x57obhUJWip4qvVclgyOO066FYOCuAAEtRylLRlM0dyxsDMNqZu/0Nh
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR84MB3712
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: VHUIASe0X4O1Vu0QlI707Cz7MqQjB12w
X-Proofpoint-ORIG-GUID: VHUIASe0X4O1Vu0QlI707Cz7MqQjB12w
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-08_11,2024-01-08_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 bulkscore=0 mlxlogscore=713
 mlxscore=0 adultscore=0 lowpriorityscore=0 phishscore=0 impostorscore=0
 spamscore=0 malwarescore=0 suspectscore=0 priorityscore=1501 clxscore=1011
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401090010

Hi Jarkko,

The issue was found when crypto/public_key.h was included, but CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE was not enabled. If CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE was not enabled, the public_key_verify_signature simply returned -EINVAL, which was not declared without linux/errno.h being included.

Thanks,
Clay

On 2024/1/8 10:24 PM, Jarkko Sakkinen wrote:
> On Sun Jan 7, 2024 at 3:28 PM EET,  wrote:
>> From: Clay Chang <clayc@hpe.com>
>>
>> This patch includes linux/errno.h to address the issue of 'EINVAL' being
>> undeclared.
>>
>> Signed-off-by: Clay Chang <clayc@hpe.com>
>> ---
>>  include/crypto/public_key.h | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/include/crypto/public_key.h b/include/crypto/public_key.h
>> index 462f8a34cdf8..b7f308977c84 100644
>> --- a/include/crypto/public_key.h
>> +++ b/include/crypto/public_key.h
>> @@ -10,6 +10,7 @@
>>  #ifndef _LINUX_PUBLIC_KEY_H
>>  #define _LINUX_PUBLIC_KEY_H
>>  
>> +#include <linux/errno.h>
>>  #include <linux/keyctl.h>
>>  #include <linux/oid_registry.h>
>>  
> 
> Please provide evidence that issue exist (applies for any possible kernel issue).
> 
> BR, Jarkko