Received-SPF: pass (google.com: domain of linux-crypto+bounces-1306-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <30948df0bebe6d37d722b4ca4ab5feba7b7c0895.camel@linux.intel.com>
Subject: Re: [PATCH v1] crypto: iaa - Remove unnecessary
 debugfs_create_dir() error check in iaa_crypto_debugfs_init()
From: Tom Zanussi <tom.zanussi@linux.intel.com>
To: Minjie Du <duminjie@vivo.com>, Herbert Xu <herbert@gondor.apana.org.au>,
  "David S. Miller" <davem@davemloft.net>, "open list:INTEL IAA CRYPTO
 DRIVER" <linux-crypto@vger.kernel.org>, open list
 <linux-kernel@vger.kernel.org>
Cc: opensource.kernel@vivo.com
Date: Tue, 09 Jan 2024 10:25:21 -0600
In-Reply-To: <20240109021916.20960-1-duminjie@vivo.com>
References: <20240109021916.20960-1-duminjie@vivo.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
User-Agent: Evolution 3.44.4-0ubuntu2 
Precedence: bulk
MIME-Version: 1.0

On Tue, 2024-01-09 at 10:19 +0800, Minjie Du wrote:
> This patch removes the debugfs_create_dir() error checking in
> iaa_crypto_debugfs_init(). Because the debugfs_create_dir() is
> developed
> in a way that the caller can safely handle the errors that
> occur during the creation of DebugFS nodes.
>=20
> Signed-off-by: Minjie Du <duminjie@vivo.com>

Acked-by: Tom Zanussi <tom.zanussi@linux.intel.com>

Thanks Minjie,

Tom


> ---
> =C2=A0drivers/crypto/intel/iaa/iaa_crypto_stats.c | 2 --
> =C2=A01 file changed, 2 deletions(-)
>=20
> diff --git a/drivers/crypto/intel/iaa/iaa_crypto_stats.c
> b/drivers/crypto/intel/iaa/iaa_crypto_stats.c
> index 2e3b7b73af20..cbf87d0effe3 100644
> --- a/drivers/crypto/intel/iaa/iaa_crypto_stats.c
> +++ b/drivers/crypto/intel/iaa/iaa_crypto_stats.c
> @@ -275,8 +275,6 @@ int __init iaa_crypto_debugfs_init(void)
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0return -ENODEV;
> =C2=A0
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0iaa_crypto_debugfs_root =
=3D debugfs_create_dir("iaa_crypto",
> NULL);
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0if (!iaa_crypto_debugfs_root)
> -=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0return -ENOMEM;
> =C2=A0
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0debugfs_create_u64("max_c=
omp_delay_ns", 0644,
> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=
=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=
=A0=C2=A0 iaa_crypto_debugfs_root,
> &max_comp_delay_ns);