Received-SPF: pass (google.com: domain of linux-crypto+bounces-1323-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
From: Gaurav Jain <gaurav.jain@nxp.com>
To: Kun Song <Kun.Song@windriver.com>
CC: Varun Sethi <V.Sethi@nxp.com>, Aymen Sghaier <aymen.sghaier@nxp.com>,
	"davem@davemloft.net" <davem@davemloft.net>, "filip.pudak@windriver.com"
	<filip.pudak@windriver.com>, "heng.guo@windriver.com"
	<heng.guo@windriver.com>, "herbert@gondor.apana.org.au"
	<herbert@gondor.apana.org.au>, Horia Geanta <horia.geanta@nxp.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>, Meenakshi
 Aggarwal <meenakshi.aggarwal@nxp.com>, "richard.danter@windriver.com"
	<richard.danter@windriver.com>
Subject: RE: [EXT] RE: [PATCH v5.10.y] crypto: caam/jr - Fix possible caam_jr
 crash
Thread-Topic: [EXT] RE: [PATCH v5.10.y] crypto: caam/jr - Fix possible caam_jr
 crash
Thread-Index: AQHaQ56ceWii/sYVC0amEMLId/XZerDSu5zA
Date: Wed, 10 Jan 2024 09:14:16 +0000
Message-ID:
 <AM0PR04MB600455078CE01BE8246117B7E7692@AM0PR04MB6004.eurprd04.prod.outlook.com>
References:
 <AM0PR04MB6004B82755A53A216D2EFA13E7692@AM0PR04MB6004.eurprd04.prod.outlook.com>
 <20240110082532.2858045-1-Kun.Song@windriver.com>
In-Reply-To: <20240110082532.2858045-1-Kun.Song@windriver.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?C/PdtL53Sd+oqfnsBXDCMZURT9NI7wfeoJ5v/HVhgQbzdvE+BR4jJyTJodRx?=
 =?us-ascii?Q?foO9WYQQHMZ9micZwsUpxEZXHmfsVHbHETO7uALTbYUtqLWrYRjEFPm7K4c2?=
 =?us-ascii?Q?TU3mgRB7YWxPBqbPAPENd6kjPQKZz9L2ubb8nj/PZngS99YntB131Tm7A2gp?=
 =?us-ascii?Q?xeX/DVYD0Xn0Cld4x//aaOd9I9QMLbgSPV7YaU/lAgtV//fDnSLSqZVTa/it?=
 =?us-ascii?Q?SDqCjn7kvd9oDJYqGRIahmr0bumpGQ+5oGXb1k28uG07lx/NaUqGWDIolP/l?=
 =?us-ascii?Q?3Dq7z3qaBB9O1CUR3gNrry+wCCrGB2gszXi3FHgG1ghAtsnmWY6OuVCztnjV?=
 =?us-ascii?Q?506fS4X6K5PlsRoyH0FLPJKHzzujn0IvNqhzM1QI7yAl1ETDfoPn809Oo3aA?=
 =?us-ascii?Q?WE5O/Jit0zVQtzzLYwQLvP1X4RmnwZkNeB9OX+uAq03HN9msVkrTXG647xre?=
 =?us-ascii?Q?7qYQ2dUc0q5LAgBazyFigjh4J3mpzd050AdejiofIBE3xhWRisnsIPPzHJeN?=
 =?us-ascii?Q?12keBPHL+0Io85DctatNb+AUgcCiWRbyyJ+sUIqo9RYFgt58GHkvlfRE2PS/?=
 =?us-ascii?Q?IC2BaJD/+1lyQ8BtEuZOje65HYtbqnL51gbrhDrH78DNUOa6vJ8JLHqgBBjJ?=
 =?us-ascii?Q?k8Q3tn8G5/S17jeQCJnKZIIQ0nqMHVNf+YQNYDUKXe8coW793ojO6XNrZdUq?=
 =?us-ascii?Q?R4TK4w5WErdppFdVqyX2Mu9L7DzZB6wbLK95O7oQbOp2h4wI84WBYRJfa28s?=
 =?us-ascii?Q?OhFHgCFZUcCDveSPldfDe96XM7BPs3/c/XqhURTEQzAln90lg1G2a3KB45X0?=
 =?us-ascii?Q?wYRggNwu/7/bx57IJEQFaQV5U8G5sSmlezXPY4AjzC8ci4LUmXR1OWNMMpkp?=
 =?us-ascii?Q?JQE62169vdTvFYO9uL72lXbQgFdbf7jlBOet9K2JqRcToHr57yde/oV+Flxy?=
 =?us-ascii?Q?+v9sORtbS8VywJFeZBNoM0T7pm5apNIW3mD/UY9rscPpYnl3ZEInYcLdTgOE?=
 =?us-ascii?Q?fCEJeNzFGfZ3RT1El4IpQ4tjZO6LERCSNe/XLXLD67oO9tsuKn4fNC7SBf2K?=
 =?us-ascii?Q?pLmI1H8HIgXg1Xpef4ebB3IBLPGfHOMzT2scWMmDQh1pfL4i8crXpesN0YSx?=
 =?us-ascii?Q?UWZnD8+u4zR0z5RTVHNiLtAOvyAOrIsJYw1hbml8qOfF/Fkb23x3npYTw+jl?=
 =?us-ascii?Q?bmSj2Mwa3GvcQBdTFc2sxR/OFDNfJtZMzz1/SW67S345JoxrSVHYVm+9vw/9?=
 =?us-ascii?Q?RFUei2ocNo1fnp1PP0e+BcoarFN8mlhPpBSIFBJaV6iocEmQpkIrC2dDIoRG?=
 =?us-ascii?Q?44CJfpEKWeDk94fNCnv4m80wYEAbd++TnQaYHskB0V2KbZP3dkwKW7l7FPUM?=
 =?us-ascii?Q?TAgIJnbMDloYkdfQfb0cgeG5MzJWwQ/RABbyJ5EAgAxL/h25xo1tdmqTBbic?=
 =?us-ascii?Q?Ke5hpbifyB7Tdb18GK6d/+S7OdAf5wIIUnMqzISUyCb8UOUH5ESd6lnpabGI?=
 =?us-ascii?Q?qNQYNc0MOo9Yu8HmLl8SvTBizHlTumRKI/rSMUMuY7+g8jCk0Coh3PJNKOZx?=
 =?us-ascii?Q?A3uXQBkAlFr4KRlo/A6MmyNfjDdch5/w3L+kkA6+?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-crypto@vger.kernel.org
List-Id: <linux-crypto.vger.kernel.org>
List-Subscribe: <mailto:linux-crypto+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-crypto+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: AM0PR04MB6004.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 2793b802-64bd-4f70-293b-08dc11bc8519
X-MS-Exchange-CrossTenant-originalarrivaltime: 10 Jan 2024 09:14:16.4090
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: VrzGh/UEqwmVEbs4dXi4FjsL4SGaq91ggxAqKRYb+uCzUWjBBMY9P7sDH7J2JiWDBNGZmdXpdyr4AYTcT/VPHg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM8PR04MB7218


> -----Original Message-----
> From: Kun Song <Kun.Song@windriver.com>
> Sent: Wednesday, January 10, 2024 1:56 PM
> To: Gaurav Jain <gaurav.jain@nxp.com>
> Cc: Kun.Song@windriver.com; Varun Sethi <V.Sethi@nxp.com>; Aymen Sghaier
> <aymen.sghaier@nxp.com>; davem@davemloft.net; filip.pudak@windriver.com;
> heng.guo@windriver.com; herbert@gondor.apana.org.au; Horia Geanta
> <horia.geanta@nxp.com>; linux-crypto@vger.kernel.org; Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>; richard.danter@windriver.com
> Subject: [EXT] RE: [PATCH v5.10.y] crypto: caam/jr - Fix possible caam_jr=
 crash
>=20
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report =
this
> email' button
>=20
>=20
> >Hello SK
> >
> >I am submitting and replying patches using gaurav.jain@nxp.com
> >
> >In Later kernel versions we have provided fixes related to job ring flus=
h and
> there are other changes as well.
> >It would be better to add these changes on top of 5.10 tree as we also r=
un
> multiple tests and not observed this issue.
> >
> >Regards
> >Gaurav Jain
>=20
> Hi, Gaurav
>=20
> Can you identify which commits?
> Our version has added some related commits based on 5.10
> -------------------------------------------------
> 04ff8e37a2df crypto: caam/jr - add .shutdown hook
> f7ea4a6a6511 LF-3093-1 crypto: caam/jr - fix caam-keygen exit / clean-up
> c41daf27fa44 LF-3079 crypto: caam/jr - fix shared IRQ line handling
> 1f12127de72a MLK-24912-2 crypto: caam - fix RNG vs. hwrng kthread race
> 04e3a61f9bb5 MLK-24912-1 crypto: caam/jr - update jr_list during
> suspend/resume f48d9e23262e MLK-24420-3 crypto: caam - add ioctl calls fo=
r
> black keys and blobs generation
> 5c98742fbf60 MLK-24420-2 crypto: caam - add support for black keys and bl=
obs
> -------------------------------------------------


https://github.com/torvalds/linux/commit/06e39357c36b0d3cc2779d08ed04cb389e=
aa22ba - drivers: crypto: caam/jr - Allow quiesce when quiesced
apply this one as well.

>=20
> But We have no way to port this commit because its architecture has chang=
ed
> too much.
> commit 304a2efe9d55875c6805f3c2957bc39ceebbc5c0
> crypto: caam/jr - Convert to platform remove callback returning void

Ok. I think this can be skipped.

>=20
>=20
> On your test enviroment, modify function caam_jr_remove Test scenarios1:
> if &jrpriv->tfm_count is not zero,whether will crash?
>=20
> +atomic_inc(&jrpriv->tfm_count);
> if (atomic_read(&jrpriv->tfm_count)) {

This way jobring flush operation will not be triggered and reusing jobring =
result in error.

>=20
>=20
> Thanks!
> BR/SK