Received-SPF: pass (google.com: domain of linux-crypto+bounces-1404-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Message-ID: <a8ad036a-7d65-4dbe-8c87-f569e54d7a57@hpe.com>
Date: Fri, 12 Jan 2024 13:59:39 +0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] KEYS: include header for EINVAL definition
Content-Language: en-US
To: Jarkko Sakkinen <jarkko@kernel.org>, <keyrings@vger.kernel.org>,
        <linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
CC: <dhowells@redhat.com>, <herbert@gondor.apana.org.au>,
        <davem@davemloft.net>
References: <20240107132842.4024084-1-clayc@hpe.com>
 <CY9E6M2BYETA.1VE73N3UHD4B9@suppilovahvero>
 <a77797fd-cbe4-42be-abd6-54cc815d360a@hpe.com>
 <CYBAG2X330P5.2SIIYCQ1GN44G@suppilovahvero>
From: Clay Chang <clayc@hpe.com>
In-Reply-To: <CYBAG2X330P5.2SIIYCQ1GN44G@suppilovahvero>
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?eWd4eVM3dU5qY1BRNlZlZmFObENGNkJGZWlYOGNmUTRCOXd0NUdmYk5ycUVP?=
 =?utf-8?B?OFlHeU5VbU9PMnArbDRjTFJJb0lzQnhFVkpIOThmdUt3SnNiWFZ2OTVJNUho?=
 =?utf-8?B?ZXl0OUs1TjJTcTAzTW94Uy9vQlpocU5NUW9ndlVhWFBHMVRTcmFNNnI0bWJ2?=
 =?utf-8?B?d3F6SkN6K01PdHRzY3k5SmVZSTZsTHA5bXlrWWJQTkNSbWtzWmg4cVJrU3ll?=
 =?utf-8?B?ZWJ5VURWN3VtRUdDMnhFdkhEczBBRGZXSStkcnByVHlQWENYS0pxWHhvR3NK?=
 =?utf-8?B?dFNMRnhZQzNZbGxaOU1DREVmRkFBdXJMRUlHR3J5ZG52MWxQcWJTQjRGbUVO?=
 =?utf-8?B?dTNHRHBuZk1STE9GaFEvc0JYZkpYZWdLL25UMElHQWo1QzFORDA2TzJrZ0I4?=
 =?utf-8?B?TEpzaTg4OHNRM2pTL1lNak1QTFFEVXNwUysrWEZIN2NNVE9vSE5ROFRJQkRB?=
 =?utf-8?B?WDVobkdkSmorT09MMkhaWDV5Q0pSbldKSVhGYVhRTTVKTjJDamFLam5ZMVlo?=
 =?utf-8?B?eFdjNHplTVZCeVFLQVByMzlIWEthZnU3TFpLdmoyL3dGazRnVUdpRTZrM1No?=
 =?utf-8?B?MXJjUS9za0ZDbXdKeDhIelQ2MGxXUXNwVnozY2l6TEVoSG51VzZwRjdjNFJk?=
 =?utf-8?B?cnllaElkRUo3WjVuaDNreDlDUWRvNzRpOStDdE5jRUhSdEVyU3BTd01wWWxR?=
 =?utf-8?B?RlRiY3hUNUcvV0NVb2l0ZndKNWlsWGZxaDRJMC84VWYwWDhvc1hGVnpKNjBm?=
 =?utf-8?B?cHRiR2xFNlU3eDJNUDVheW9reHZvTjlHY2VUbXhPUUZRdFhmK05yRXdhR0Jt?=
 =?utf-8?B?NTNvQlMvbTl4eDZpcVZsSktMYmg2SEYrSW1ydTQ1S1dxSHFzVWExUXRENG5F?=
 =?utf-8?B?bGhSc1BadW5BelhyencrcWFBZ2Z4RlhXQWsrMlVoc1J3Q3NGZWQ1OWdCSXBE?=
 =?utf-8?B?QW9IRW5TOUl6OUd2VlpzNE93ZldJQ0pWMkVaWURnQ2ZmK0p6MUo2RWV4VkNU?=
 =?utf-8?B?WnNURVdjbzFDL0pwMEVVLzQxVGdJWXNNT3hIYlpHNzBvczBiTm1sYzdEeklX?=
 =?utf-8?B?TWhmaDlIbko4UkVkOTQxNE9NWkhyRkcvZThCbWw0anlJaWszeUFvNS9iUGVB?=
 =?utf-8?B?RnpZZW5WdENwRW9IOElQTVc3QmRlWDhkTmpSS2FvTEdPbnRHL3AwdDc2azJx?=
 =?utf-8?B?aCtWSENXSnAvUUpMdTlWeEV1V1VqV1ZRdXIyTkFMSVRuY0krLzkyaGxoVFZF?=
 =?utf-8?B?L0s5elJLSGFQTTI1M0VZTWJSL3dJTEN1ZVRHVDkydlZrRHBEdUVOQ3FROUFs?=
 =?utf-8?B?aktqUEZxUW8xVUdmVUdYVGd0Q1Y0WTd4Z2FGMi9yN0d4bXVhTkFLS0trbFc4?=
 =?utf-8?B?WHIzR2I3dWFaN1hNbTlrYTJwbGdTQXZvWXRYSDhrQkh0UGZPZTV2ZVg2akRw?=
 =?utf-8?B?VUc1elBLQXc4QndxbERqQ3ZMaGR2YkhCMmRLcW9lUDRyeGZnVWRIc3pya1lv?=
 =?utf-8?B?cG00YlNjY2FRZ0VkMGYrZWJqbnNCZVRsMk1RWmtoTUdjWkFmT0VXS2srT0hz?=
 =?utf-8?B?WkdEM2RKRzE2UEVzak1WSlcxbzhicDBnY0drRllMR2w2ZjB0dHRMZi8yTGdX?=
 =?utf-8?B?amtLWE9ES1RSeGUyWEZEVnNBSTNUWU9YeXlIRWwzMTEvTHd0Tk01d0JQc3p1?=
 =?utf-8?B?bjdIMThabzU5Tzhjemp1ZHo0ZEVMWEFBbmY2VWo3S0FEZmhvRDNwNDZ0NTFt?=
 =?utf-8?B?TkN1SXpCdFdyMHJUOTdhZXllcndrMlp4ZEFrYmFEeWVHYXJoYTVmRFI0L3BI?=
 =?utf-8?B?TS92TUovQytaRkxtMkxGYXBzbkJ1WFVGWEQwWDVlb1psU1RMbEVnTjVGQW1E?=
 =?utf-8?B?TVJBSGlJdFZ0Q2tZQndxWlRoZHVoMFJQR1FUOFBQYjJmbHlZU1NYYStDNjFm?=
 =?utf-8?B?T3l6OHh0YU94Yi9qbG0xQmxCQW1aSEgzZ1hmVHZUKzQ3NjFJdUd4YnZEZHVW?=
 =?utf-8?B?SVlqZWMwWmJzVmJlVUJ0c2NSWVNMdnFwUzZqUC85RHJlcng2aFk4N09iOTdM?=
 =?utf-8?B?ek8ySnRMdkJySHM3UmgzTWk0Z3dtZUFndUc3dWVpTDlBTGVqNFlFdDR3T2FE?=
 =?utf-8?Q?Ij8CjdEsvN1tX6wNYzRVFp0aB?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 51c423cc-5645-4a7a-87c8-08dc1333ad2f
X-MS-Exchange-CrossTenant-AuthSource: PH0PR84MB1480.NAMPRD84.PROD.OUTLOOK.COM
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Jan 2024 05:59:45.2077
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 105b2061-b669-4b31-92ac-24d304d195dc
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4EuHLd+XicB7mwCM9FYYBmHTIQhdN8P9zWQ5UBeQpk3w6lNenrIOhTb+MHmd+GQs
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW5PR84MB1572
X-OriginatorOrg: hpe.com
X-Proofpoint-GUID: id0q-i_UoAg96gx9SqjsSKSp0b-pYCni
X-Proofpoint-ORIG-GUID: id0q-i_UoAg96gx9SqjsSKSp0b-pYCni
X-HPE-SCL: -1
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.997,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-01-12_02,2024-01-11_01,2023-05-22_02
X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 mlxscore=0 malwarescore=0
 phishscore=0 adultscore=0 lowpriorityscore=0 suspectscore=0 clxscore=1015
 mlxlogscore=509 spamscore=0 impostorscore=0 bulkscore=0 priorityscore=1501
 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.12.0-2311290000
 definitions=main-2401120043

Hi Jarkko,

Yes, I have. I am working on an OpenBMC project and the kernel .config was generated by merging several config fragments. In one experiment where the CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE was not presented, I got a EINVAL undeclared compilation error.

Do you want me to show the full .config here?

Thanks,
Clay

On 2024/1/11 3:54 AM, Jarkko Sakkinen wrote:
> On Tue Jan 9, 2024 at 4:10 AM EET, Clay Chang wrote:
>> Hi Jarkko,
>>
>> The issue was found when crypto/public_key.h was included, but
>> CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE was not enabled. If
>> CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE was not enabled, the
>> public_key_verify_signature simply returned -EINVAL, which was not
>> declared without linux/errno.h being included.
>>
>> Thanks,
>> Clay
> 
> Do you have .config to verify this?
> 
> BR, Jarkko