Received-SPF: pass (google.com: domain of linux-crypto+bounces-1418-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Sat, 13 Jan 2024 22:46:57 +0200
Message-Id: <CYDVFYGDLJFC.1IAQAPLY6VRWX@kernel.org>
Cc: <dhowells@redhat.com>, <herbert@gondor.apana.org.au>,
 <davem@davemloft.net>
Subject: Re: [PATCH] KEYS: include header for EINVAL definition
From: "Jarkko Sakkinen" <jarkko@kernel.org>
To: "Clay Chang" <clayc@hpe.com>, <keyrings@vger.kernel.org>,
 <linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
References: <20240107132842.4024084-1-clayc@hpe.com>
 <CY9E6M2BYETA.1VE73N3UHD4B9@suppilovahvero>
 <a77797fd-cbe4-42be-abd6-54cc815d360a@hpe.com>
 <CYBAG2X330P5.2SIIYCQ1GN44G@suppilovahvero>
 <a8ad036a-7d65-4dbe-8c87-f569e54d7a57@hpe.com>
In-Reply-To: <a8ad036a-7d65-4dbe-8c87-f569e54d7a57@hpe.com>

On Fri Jan 12, 2024 at 7:59 AM EET, Clay Chang wrote:
> Hi Jarkko,
>
> Yes, I have. I am working on an OpenBMC project and the kernel .config wa=
s generated by merging several config fragments. In one experiment where th=
e CONFIG_ASYMMETRIC_PUBLIC_KEY_SUBTYPE was not presented, I got a EINVAL un=
declared compilation error.
>
> Do you want me to show the full .config here?

Well the problem with the patch is that it does not *prove*
that there is issue.

So you evidence in the commit message that there is bug in
the first place and which config options cause it. And it
it must be testable with latest mainline (not by downstream
project).

BR, Jarkko