Received-SPF: pass (google.com: domain of linux-crypto+bounces-1496-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Date: Fri, 19 Jan 2024 16:57:11 +0000
From: "Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>
To: <herbert@gondor.apana.org.au>
CC: Damian Muszynski <damian.muszynski@intel.com>,
	<linux-crypto@vger.kernel.org>, <qat-linux@intel.com>
Subject: Re: [PATCH] crypto: qat - fix arbiter mapping generation algorithm
 for QAT 402xx
Message-ID: <Zaqp5+mL/Gg2i/Oo@gcabiddu-mobl.ger.corp.intel.com>
References: <20240119161325.12582-1-damian.muszynski@intel.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240119161325.12582-1-damian.muszynski@intel.com>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?sePUK1zO4xh0hAiYecqy6AQDuMxH4q2cnH97XrWbUwtS/gb2fsBQv9u8uj4M?=
 =?us-ascii?Q?usAQmxTbKIoAaM/Pf/qiRxv8THYngKFW5k/+LyftpzWaWU3wIlywDSIxPsCS?=
 =?us-ascii?Q?33gJbaM4uKt/nDhUkC9B4o+cFHr3LoOFtoxU7+iu/bkD1WQ+IP1MzV0LEibJ?=
 =?us-ascii?Q?gVoh+g6WDCQv+oYzUOi7odVncRAi7x6CjgFA3WInVXUVh/H9mrPrUvd+2evt?=
 =?us-ascii?Q?IfhdX65Pa6FQmR07TPG5wyghubMuff6v+1GACgNsIsLXafIJW+UGUJ26EeO2?=
 =?us-ascii?Q?ydCtc645Eq1Zm5BXz3mJvu0cgPMNptkjHXNlacnysrKa5vZ/4N1VWFHZx/5p?=
 =?us-ascii?Q?OGumWtgWvesu6T/CK3AmsPXCYjJpv5pQWjfKdM3j+8chyjrivvWTWot894sK?=
 =?us-ascii?Q?3mCMWecsb+rDXHfNk0I22R7vYZYfe476/ApFpQyfY1i0wmBoZmUIX4Nt3Qw/?=
 =?us-ascii?Q?t8EnEhjTXMZ0IbBFJrCZs7gvWrHsrgmAAPzi40jFCqN+Sn6wQ09BzkSQ8rGs?=
 =?us-ascii?Q?kgi0ks4Iy/o4tJKM9I5EkFIEIpoDlbtGAcgzE9eYEslZRLeVoMjJu4sFYXxO?=
 =?us-ascii?Q?kcbTulzSCRulbpuz/6bXpJvJQqMCzmTVoCPJtvZ7SL0PQiWhZOXqmJyXFwvi?=
 =?us-ascii?Q?pf8S9feekWijO1x5tImTSD7DH2Rwq5xmHLK/Y1GC5I+/jHZ416vtXpkVY9dQ?=
 =?us-ascii?Q?egrm7VRmHs15BmvCTj4s/4B+LhiE0FjNnU2dutxexAGQbIJec9NkgANdAHz4?=
 =?us-ascii?Q?XGCLRgH+86HzS4Mm2LLMCPXqInhEN/8w/s1C5bwNfUpEfQAhbLCVtKGYwydg?=
 =?us-ascii?Q?Cec1mSMA1uut8AN6HSjFEHxdwDVOXoNey/8mzAA6b5kcPRncJnNj+JNVG6Je?=
 =?us-ascii?Q?28lZs6d9uksLgDP0Iqq/Dd0cjOTucWdM/sHjGsB+93YLe1Ewfy6fIfK6VTEg?=
 =?us-ascii?Q?yfc3Ax9VNXpcKhOWQAWSlagOuU2P4caUv4LVg/OaGotWRz4uzCiMxh+O3aRj?=
 =?us-ascii?Q?mBdwNWMsm60M3tax7UWXQO5BN2js2zspgeAGzrQZ43XEt7fAjiFneOtAU0hO?=
 =?us-ascii?Q?HS3SMRCkG8vMsdUME78+zDFoDAxOcNkmXrhzSgGlP8v9j2HO7hEP/zaCFbAt?=
 =?us-ascii?Q?l8zoijIqZPZKnblt2eMNwgIG340l2drM+OXxcXtD/B3Yfii83i8wVNfrMMdH?=
 =?us-ascii?Q?4vWDEZndqzPNOOrelRe4nZbR9KQpK2ItwI58SGDAWWaTDnj04OhybsCrMWWN?=
 =?us-ascii?Q?K/UmXYmmmn1Su8pSi9HS3OrEhasZShxyZ5uaGz7/1kbSgxlyls+I7CEGwOot?=
 =?us-ascii?Q?Nhm4qlzOoA2yHJqYgPFsuVV2ULTPn5hnalAYsykw0qBwKPpbRR8kyfxK2iBP?=
 =?us-ascii?Q?9zMwJPrYt4QBoyUZ2o+hkA/I3pIdYRTJVmSh9CE1u2166itcAhXQFgc+/+cE?=
 =?us-ascii?Q?W45IADf6YqJxwwQsI/tZCQeAV1ycdvWBdkg0dCykIGedl9i/iuJCa/4W1Tw3?=
 =?us-ascii?Q?utaSnPXO+8Hujgavx9L0KSiWGMuQINXm91vQkV7T1PPzKacDYEgplQdBj/Rg?=
 =?us-ascii?Q?XosKh2jgeRG48TnnXcZwCsiA5hmWYoGHmmSK3tddQMF4xX+i8ttEA5fx+Ebb?=
 =?us-ascii?Q?vw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: b9b2f8d6-2bc4-4d61-fc79-08dc190fb968
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2024 16:57:30.7256
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: ASxw56AQWUmDpJAqz+AWPW4jTS/sZZoAsdKUQd0KboJlFP1dCD8LwCYGX8Fd13kTPjebGZb3pOoO0q292y+Er0hwXGQJa461pl7ak8OD2ck=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB5678
X-OriginatorOrg: intel.com

Hi Herbert,

would it be possible to send this as a fix for 6.8?

Thanks,

-- 
Giovanni

On Fri, Jan 19, 2024 at 05:12:38PM +0100, Damian Muszynski wrote:
> The commit "crypto: qat - generate dynamically arbiter mappings"
> introduced a regression on qat_402xx devices.
> This is reported when the driver probes the device, as indicated by
> the following error messages:
> 
>   4xxx 0000:0b:00.0: enabling device (0140 -> 0142)
>   4xxx 0000:0b:00.0: Generate of the thread to arbiter map failed
>   4xxx 0000:0b:00.0: Direct firmware load for qat_402xx_mmp.bin failed with error -2
> 
> The root cause of this issue was the omission of a necessary function
> pointer required by the mapping algorithm during the implementation.
> Fix it by adding the missing function pointer.
> 
> Fixes: 5da6a2d5353e ("crypto: qat - generate dynamically arbiter mappings")
> Signed-off-by: Damian Muszynski <damian.muszynski@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> ---
>  drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c b/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c
> index 479062aa5e6b..94a0ebb03d8c 100644
> --- a/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c
> +++ b/drivers/crypto/intel/qat/qat_4xxx/adf_4xxx_hw_data.c
> @@ -463,6 +463,7 @@ void adf_init_hw_data_4xxx(struct adf_hw_device_data *hw_data, u32 dev_id)
>  		hw_data->fw_name = ADF_402XX_FW;
>  		hw_data->fw_mmp_name = ADF_402XX_MMP;
>  		hw_data->uof_get_name = uof_get_name_402xx;
> +		hw_data->get_ena_thd_mask = get_ena_thd_mask;
>  		break;
>  	case ADF_401XX_PCI_DEVICE_ID:
>  		hw_data->fw_name = ADF_4XXX_FW;
> 
> base-commit: 71518f53f4c3c3fadafdf3af86c98fa4c6ca1abc
> -- 
> 2.43.0
>