Received-SPF: pass (google.com: domain of linux-crypto+bounces-1499-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <6d8260e3-f22b-68c9-03c7-5e0fa351fe05@amd.com>
Date: Fri, 19 Jan 2024 11:36:44 -0600
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101
 Thunderbird/102.15.1
Subject: Re: [PATCH v1 18/26] crypto: ccp: Handle legacy SEV commands when SNP
 is enabled
Content-Language: en-US
To: Borislav Petkov <bp@alien8.de>, Michael Roth <michael.roth@amd.com>
Cc: x86@kernel.org, kvm@vger.kernel.org, linux-coco@lists.linux.dev,
 linux-mm@kvack.org, linux-crypto@vger.kernel.org,
 linux-kernel@vger.kernel.org, tglx@linutronix.de, mingo@redhat.com,
 jroedel@suse.de, hpa@zytor.com, ardb@kernel.org, pbonzini@redhat.com,
 seanjc@google.com, vkuznets@redhat.com, jmattson@google.com,
 luto@kernel.org, dave.hansen@linux.intel.com, slp@redhat.com,
 pgonda@google.com, peterz@infradead.org,
 srinivas.pandruvada@linux.intel.com, rientjes@google.com, tobin@ibm.com,
 vbabka@suse.cz, kirill@shutemov.name, ak@linux.intel.com,
 tony.luck@intel.com, sathyanarayanan.kuppuswamy@linux.intel.com,
 alpergun@google.com, jarkko@kernel.org, ashish.kalra@amd.com,
 nikunj.dadhania@amd.com, pankaj.gupta@amd.com, liam.merwick@oracle.com
References: <20231230161954.569267-1-michael.roth@amd.com>
 <20231230161954.569267-19-michael.roth@amd.com>
 <20240119171816.GKZaqu2M_1Pu7Q4mBn@fat_crate.local>
From: Tom Lendacky <thomas.lendacky@amd.com>
In-Reply-To: <20240119171816.GKZaqu2M_1Pu7Q4mBn@fat_crate.local>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?utf-8?B?SWQ1QzVueS85YkNua0lnTlhpRlFhSU1LaktXV015TkxibHJKK2JZTCt1QVFr?=
 =?utf-8?B?U2x5azhJQjFFZ2lGWEJ5QUpFb1RnTEd5ZXpWY3EzZktDSTRZdnhMVnVtUEVY?=
 =?utf-8?B?VkFpL2hRNmhXbG1QOGRxSThJM1I3aWRrL1ZKM1JJNzhSTTliNUFJNWthaFZs?=
 =?utf-8?B?eFU2MUxSRmdvcVBGbXRmT2ZPR005RjhzcUtHNkVBNUV3NXFCMGxISGNmWEcv?=
 =?utf-8?B?M0RwUzIyMENCMjBlQVRWdmhxNmNKWnJCclV4aVdsNXBES0JMekV1U1BYOEZF?=
 =?utf-8?B?dkRFa09mR2NBazN6akp0YmIxUEJEZDVidlU5UlpLMnVJTVB3dXdVZ21ybldF?=
 =?utf-8?B?M2s4eEJyOVNLalErNnhMdHQvUXEyb0JZRkk0ZDV1TEN2NXhobGVYeXhlQWxM?=
 =?utf-8?B?Y1htc0hjTlplVHN3Vm5FdXFOZ3FMa3pKbWo1Nks4c2d0Zk8vMTRkTFBFMzdi?=
 =?utf-8?B?elpmdWVlZ1A4eWpHSFN1cTVqK3lsRDRSVmRJeHhYMi80Si9ZV3FpTFdkZkpH?=
 =?utf-8?B?VW94WHRDNG1rNU1DbzFpS2QvQll6bTFxZlRRSng4TnNZaEJ0a28xOEVFRTZ5?=
 =?utf-8?B?a1hKTXJrVVVaR1prYk9JUE9qWGhVMzNTTnF2Z1ZQZ1RVNVZzdU44QTN2TmJM?=
 =?utf-8?B?TUhNZ1dPL0dYQkE1SmxPT3JPQkR5Q1hYSjQ1RTJkUUIzRnZZNnJOcm5UUDNE?=
 =?utf-8?B?VUM1Tml5UTJzU29lU1JLVmVTNXk1aDd4cGRUYnpCaXdhQldLaUVTRVZVN0tM?=
 =?utf-8?B?cnJzU3pSb29zdHpPWmV6THBEeWRKWFNlRVNEWi9ucjVMcnBTUmlWTWRwcUEr?=
 =?utf-8?B?UjlabjZDUGN0aUZWR2pacmF3cURIYWpIUFI5eFVQN0I4R1kwT2FYVFZMRGRt?=
 =?utf-8?B?VkFkM3puaW9NeHlsUGhNNUJGUktocURuRW0yQm5EZnFHTDV1QUwrWUpWQmd5?=
 =?utf-8?B?OWJvd1h2UlZMSXhJK0dKNEZzVFNMWHdoVUtsOE9CUHFLK2N4WlhabVIzRU1D?=
 =?utf-8?B?Q3dma2h0b0hucUhyVmo3V0RDYm81MVVmaUVzVVZjYzA3TEljYVdYYTB0UEpI?=
 =?utf-8?B?dGFiaU9aRGNhS05UamtjUmt4UWl0UGxVcG40S3dYd1Ewa2Y3VU5vQVdTZzRV?=
 =?utf-8?B?WDNlTzRMWk1FSWk3aEhVV3pzNTVpdW5Oak1CTXVjVC96dU9Fang0ZDQ5WVFx?=
 =?utf-8?B?TmRBQjNSQkk3bVR4d3JvMkROWDBSZ0czeDRPQ2duVndrL09Ib0p6SThwelBT?=
 =?utf-8?B?b2JBejd1VHZCSUZwQ0dpbEx5NTBCOXpOM01EZnlrVGc3ZDZjNk9UcDhjZ1ha?=
 =?utf-8?B?TEthUFgzd2x2bFBsWS9jRGMwWlpmQlVKenBCanFwd3F6WlI0b2hxTmhvVHd5?=
 =?utf-8?B?a0tieGNxOUowdGU0ak9PTDFmVzg1QldTWE9TZ2dBY2hXRTdnZHJyaEc5YnRW?=
 =?utf-8?B?M1pXeUtaem41OUY1K2pwSnlZMjdLRTc0WFZONmNwZmtQR0FRdTlIaDhBQk5F?=
 =?utf-8?B?ZXp2ZXdTbGdNbTJaMWszazhLN3lTM3dtVldudkRXbFRNUEpoQ0VKd29XQnRJ?=
 =?utf-8?B?emc5cUhQMkN2enJVOXlQQThQRVNSQWMwK3VkN1BTd2N2Q0N0akJJZWFFU1VG?=
 =?utf-8?B?VUVVYjg3R1duQndvQ0ZNRUNvNVlxSFUrK3EyZG11WnZGWVdKZUMzakpTbDRG?=
 =?utf-8?B?WVVHeGdwem5jaU4rYnBXblQ5cmpYL0xJMDFZUnZEa0JmU1FsaUQrWWFGaVUw?=
 =?utf-8?B?ZnY3QnFHVk4xc3ZQUExRWkxmRWxBbERhQTBQeGw5RjRVUll2TlMrMWszOWY1?=
 =?utf-8?B?VmlKWEJXZE1ObFp3VUlnVWFDaDJ3WWVVeGFIb29HTmw2OVl6NjdncGp1R3VH?=
 =?utf-8?B?Y2luY0s1NFh1SkJMeVVPSjlvSnM5VVBIYmtXVkNjdG0wUlBYaHI2S0FMS3Bu?=
 =?utf-8?B?Zkx4dVJGNmRxNjVWakpGSCtjQ282ejM1dlpPb042Z0k1NGVUQ3pvVlNnd2FR?=
 =?utf-8?B?aW1wQktjTXZxelA1bnR5dnZvL285Y3VLRitWcVJ3TGwva1hFbjVxeDFJVGVQ?=
 =?utf-8?B?KzVhdmQ4UURpN3BzWHN4aGh0bFdQMjVnbmphbjV5UUJ3RlpYMm9hbTdVVXc2?=
 =?utf-8?Q?n45X+T1dV5hp+NfCrqGtH4Rfm?=
X-OriginatorOrg: amd.com
X-MS-Exchange-CrossTenant-Network-Message-Id: c811268a-9bf1-440a-349e-08dc1915372c
X-MS-Exchange-CrossTenant-AuthSource: BL1PR12MB5732.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jan 2024 17:36:49.1727
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: BbD8XK7bXFLc67d70tMHjUnrTDsluyuPB5e2ZQwVlfdwmtm7h8114DCuzWRSsMGDLD8COlm2xjZlWOwVPPIo/Q==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY5PR12MB6251

On 1/19/24 11:18, Borislav Petkov wrote:
> On Sat, Dec 30, 2023 at 10:19:46AM -0600, Michael Roth wrote:
>> From: Brijesh Singh <brijesh.singh@amd.com>
>>
>> The behavior of legacy SEV commands is altered when the firmware is
>> initialized for SNP support. In that case, all command buffer memory
>> that may get written to by legacy SEV commands must be marked as
>> firmware-owned in the RMP table prior to issuing the command.
>>
>> Additionally, when a command buffer contains a system physical address
>> that points to additional buffers that firmware may write to, special
>> handling is needed depending on whether:
>>
>>    1) the system physical address points to guest memory
>>    2) the system physical address points to host memory
>>
>> To handle case #1, the pages of these buffers are changed to
>> firmware-owned in the RMP table before issuing the command, and restored
>> to after the command completes.
>>
>> For case #2, a bounce buffer is used instead of the original address.
>>
>> Signed-off-by: Brijesh Singh <brijesh.singh@amd.com>
>> Co-developed-by: Michael Roth <michael.roth@amd.com>
>> Signed-off-by: Michael Roth <michael.roth@amd.com>
>> Signed-off-by: Ashish Kalra <ashish.kalra@amd.com>
>> ---
>>   drivers/crypto/ccp/sev-dev.c | 421 ++++++++++++++++++++++++++++++++++-
>>   drivers/crypto/ccp/sev-dev.h |   3 +
>>   2 files changed, 414 insertions(+), 10 deletions(-)
> 
> Definitely better, thanks.
> 
> Some cleanups ontop:
> 
> ---
> 

> @@ -904,7 +904,7 @@ static int __sev_do_cmd_locked(int cmd, void *data, int *psp_ret)
>   		ret = snp_prep_cmd_buf(cmd, cmd_buf, desc_list);
>   		if (ret) {
>   			dev_err(sev->dev,
> -				"SEV: failed to prepare buffer for legacy command %#x. Error: %d\n",
> +				"SEV: failed to prepare buffer for legacy command 0x%#x. Error: %d\n",

Using %#x will produce the 0x in the output (except if the value is zero 
for some reason). So I would say make that 0x%x.

Thanks,
Tom

>   				cmd, ret);
>   			return ret;
>   		}
> 
>