Received-SPF: pass (google.com: domain of linux-crypto+bounces-1550-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
Feedback-ID: i56a14606:Fastmail
User-Agent: Cyrus-JMAP/3.11.0-alpha0-119-ga8b98d1bd8-fm-20240108.001-ga8b98d1b
Precedence: bulk
MIME-Version: 1.0
Message-Id: <0229fa60-2d87-4b1c-b9f0-6f04c6e4dbdd@app.fastmail.com>
In-Reply-To: <d03e90ca-8485-4d1b-5ec1-c3398e0e8da@linux-m68k.org>
References: 
 <CAHk-=wiB4iHTtfZKiy5pC24uOjun4fbj4kSX0=ZnGsOXadMf6g@mail.gmail.com>
 <20240123111235.3097079-1-geert@linux-m68k.org>
 <d03e90ca-8485-4d1b-5ec1-c3398e0e8da@linux-m68k.org>
Date: Tue, 23 Jan 2024 15:21:14 +0100
From: "Arnd Bergmann" <arnd@arndb.de>
To: "Geert Uytterhoeven" <geert@linux-m68k.org>, linux-kernel@vger.kernel.org
Cc: linuxppc-dev@lists.ozlabs.org, linux-sh@vger.kernel.org,
 sparclinux@vger.kernel.org, intel-xe@lists.freedesktop.org,
 dri-devel@lists.freedesktop.org, linux-mtd@lists.infradead.org,
 mpi3mr-linuxdrv.pdl@broadcom.com, linux-scsi@vger.kernel.org,
 "Chris Zankel" <chris@zankel.net>, "Max Filippov" <jcmvbkbc@gmail.com>,
 linux-hardening@vger.kernel.org, qat-linux@intel.com,
 linux-crypto@vger.kernel.org,
 "intel-wired-lan@lists.osuosl.org" <intel-wired-lan@lists.osuosl.org>,
 Netdev <netdev@vger.kernel.org>
Subject: Re: Build regressions/improvements in v6.8-rc1
Content-Type: text/plain;charset=utf-8
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 23, 2024, at 12:45, Geert Uytterhoeven wrote:

>> 68 error regressions:
>
>>  + /kisskb/src/arch/powerpc/sysdev/udbg_memcons.c: error: no previous=
 prototype for 'memcons_getc' [-Werror=3Dmissing-prototypes]:  =3D> 80:5
>>  + /kisskb/src/arch/powerpc/sysdev/udbg_memcons.c: error: no previous=
 prototype for 'memcons_getc_poll' [-Werror=3Dmissing-prototypes]:  =3D>=
 57:5
>>  + /kisskb/src/arch/powerpc/sysdev/udbg_memcons.c: error: no previous=
 prototype for 'memcons_putc' [-Werror=3Dmissing-prototypes]:  =3D> 44:6
>
> powerpc-gcc{5,12,13}/ppc64_book3e_allmodconfig

I now sent patches for powerpc booke warnings

>>  + /kisskb/src/arch/sh/kernel/cpu/init.c: error: no previous prototyp=
e for 'l2_cache_init' [-Werror=3Dmissing-prototypes]:  =3D> 99:29
>
> sh4-gcc1[123]/se7{619,750}_defconfig
> sh4-gcc1[123]/sh-{all{mod,no,yes},def}config
> sh4-gcc11/sh-allnoconfig

I assume the sh maintainers will eventually get to that

>>  + /kisskb/src/arch/sparc/include/asm/floppy_64.h: error: no previous=
 prototype for 'sparc_floppy_irq' [-Werror=3Dmissing-prototypes]:  =3D> =
200:13
>>  + /kisskb/src/arch/sparc/include/asm/floppy_64.h: error: no previous=
 prototype for 'sun_pci_fd_dma_callback' [-Werror=3Dmissing-prototypes]:=
  =3D> 437:6
>
> sparc64-gcc{5,11,12,13}/sparc64-allmodconfig

Andrew Morton did a patch for the sparc warnings, and Andreas Larsson
is joining as a maintainer, so hopefully he can pick that up soon.
> sparc64-gcc{5,1[123]}/sparc64-allmodconfig
>
>>  + /kisskb/src/arch/sparc/vdso/vclock_gettime.c: error: no previous p=
rototype for '__vdso_clock_gettime' [-Werror=3Dmissing-prototypes]:  =3D=
> 254:1
>>  + /kisskb/src/arch/sparc/vdso/vclock_gettime.c: error: no previous p=
rototype for '__vdso_clock_gettime_stick' [-Werror=3Dmissing-prototypes]=
:  =3D> 282:1
>>  + /kisskb/src/arch/sparc/vdso/vclock_gettime.c: error: no previous p=
rototype=20

There are prototypes in include/vdso/gettime.h that should be
used here, but unfortunately the sparc implementation does
not match the prototypes because sparc is missing the gettime64
support.

> sparc64-gcc{5,12,13}/sparc64-{allno,def}config
> sparc64-gcc11/sparc64-{all{mod,no},def}config
>
>>  + /kisskb/src/arch/x86/um/shared/sysdep/kernel-offsets.h: error: no =
previous prototype for =E2=80=98foo=E2=80=99 [-Werror=3Dmissing-prototyp=
es]:  =3D> 9:6
>
> um-x86_64-gcc12/um-{all{mod,yes},def}config

I made a patch for arch/um yesterday.

> sparc64-gcc1[12]/sparc64-allmodconfig
>
>>  + /kisskb/src/drivers/scsi/mpi3mr/mpi3mr_transport.c: error: the fra=
me size of 1680 bytes is larger than 1536 bytes [-Werror=3Dframe-larger-=
than=3D]:  =3D> 1818:1

I sent a patch in November when the regression started, missed
the reply about needing another change
https://lore.kernel.org/all/CAFdVvOxH4UQjww4124E2ttuTgknzkHoPxVSFOQgLfoV=
_dkANwQ@mail.gmail.com/

>>  + {standard input}: Error: displacement to undefined symbol .L105 ov=
erflows 8-bit field :  =3D> 590, 593
>>  + {standard input}: Error: displacement to undefined symbol .L135 ov=
erflows 8-bit field :  =3D> 603
>>  + {standard input}: Error: displacement to undefined symbol .L140 ov=
erflows 8-bit field :  =3D> 606
>>  + {standard input}: Error: displacement to undefined symbol .L76 ove=
rflows 12-bit field:  =3D> 591, 594
>>  + {standard input}: Error: displacement to undefined symbol .L77 ove=
rflows 8-bit field : 607 =3D> 607, 582, 585
>>  + {standard input}: Error: displacement to undefined symbol .L97 ove=
rflows 12-bit field:  =3D> 607
>>  + {standard input}: Error: pcrel too far: 604, 590, 577, 593, 572, 5=
69, 598, 599, 596, 610 =3D> 610, 574, 599, 569, 598, 596, 601, 590, 604,=
 595, 572, 577, 593
>
> SH ICE crickets

Linus did a patch for the syscall, and I sent another one for
arch/sh to prevent this from happening again:

https://lore.kernel.org/all/CAHk-=3Dwjh6Cypo8WC-McXgSzCaou3UXccxB+7PVeSu=
GR8AjCphg@mail.gmail.com/
https://lore.kernel.org/all/07d8877b-d933-46f4-8ca4-c10ed602f37e@app.fas=
tmail.com/

Resent mine now.

      Arnd