Received-SPF: pass (google.com: domain of linux-crypto+bounces-1592-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240124121032.8172-1-lirongqing@baidu.com>
In-Reply-To: <20240124121032.8172-1-lirongqing@baidu.com>
From: Stefan Hajnoczi <stefanha@gmail.com>
Date: Wed, 24 Jan 2024 07:41:03 -0500
Message-ID: <CAJSP0QUEwd+VbYzwkmo0hZc6FPxv-3MTz0n6t6PCKo3Q-C3_8g@mail.gmail.com>
Subject: Re: [PATCH] virtio_crypto: remove duplicate check if queue is broken
To: Li RongQing <lirongqing@baidu.com>
Cc: mst@redhat.com, jasowang@redhat.com, xuanzhuo@linux.alibaba.com, 
	arei.gonglei@huawei.com, herbert@gondor.apana.org.au, davem@davemloft.net, 
	virtualization@lists.linux.dev, linux-crypto@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"

On Wed, 24 Jan 2024 at 07:27, Li RongQing <lirongqing@baidu.com> wrote:
>
> virtqueue_enable_cb() will call virtqueue_poll() which will check if
> queue is broken at beginning, so remove the virtqueue_is_broken() call
>
> Signed-off-by: Li RongQing <lirongqing@baidu.com>
> ---
>  drivers/crypto/virtio/virtio_crypto_core.c | 2 --
>  1 file changed, 2 deletions(-)

Reviewed-by: Stefan Hajnoczi <stefanha@redhat.com>

>
> diff --git a/drivers/crypto/virtio/virtio_crypto_core.c b/drivers/crypto/virtio/virtio_crypto_core.c
> index 43a0838..3607b6f 100644
> --- a/drivers/crypto/virtio/virtio_crypto_core.c
> +++ b/drivers/crypto/virtio/virtio_crypto_core.c
> @@ -42,8 +42,6 @@ static void virtcrypto_ctrlq_callback(struct virtqueue *vq)
>                         virtio_crypto_ctrlq_callback(vc_ctrl_req);
>                         spin_lock_irqsave(&vcrypto->ctrl_lock, flags);
>                 }
> -               if (unlikely(virtqueue_is_broken(vq)))
> -                       break;
>         } while (!virtqueue_enable_cb(vq));
>         spin_unlock_irqrestore(&vcrypto->ctrl_lock, flags);
>  }
> --
> 2.9.4
>
>