Received-SPF: pass (google.com: domain of linux-crypto+bounces-1600-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Thu, 25 Jan 2024 17:24:12 +0800
From: Herbert Xu <herbert@gondor.apana.org.au>
To: Martin KaFai Lau <martin.lau@linux.dev>
Cc: Vadim Fedorenko <vadfed@meta.com>, netdev@vger.kernel.org,
	linux-crypto@vger.kernel.org, bpf@vger.kernel.org,
	Victor Stewart <v@nametag.social>,
	Vadim Fedorenko <vadim.fedorenko@linux.dev>,
	Jakub Kicinski <kuba@kernel.org>,
	Andrii Nakryiko <andrii@kernel.org>,
	Alexei Starovoitov <ast@kernel.org>,
	Mykola Lysenko <mykolal@fb.com>
Subject: Re: [PATCH bpf-next v8 2/3] bpf: crypto: add skcipher to bpf crypto
Message-ID: <ZbIovBWdpDrwFw0V@gondor.apana.org.au>
References: <20240115220803.1973440-1-vadfed@meta.com>
 <20240115220803.1973440-2-vadfed@meta.com>
 <dc3f48ee-2742-4c59-96a1-a06ffa1d7712@linux.dev>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <dc3f48ee-2742-4c59-96a1-a06ffa1d7712@linux.dev>

On Wed, Jan 24, 2024 at 05:14:56PM -0800, Martin KaFai Lau wrote:
> On 1/15/24 2:08 PM, Vadim Fedorenko wrote:
> > Implement skcipher crypto in BPF crypto framework.
> > 
> > Signed-off-by: Vadim Fedorenko<vadfed@meta.com>
> > ---
> > v7 -> v8:
> > - Move bpf_crypto_skcipher.c to crypto and make it part of
> >    skcipher module. This way looks more natural and makes bpf crypto
> >    proper modular. MAINTAINERS files is adjusted to make bpf part
> >    belong to BPF maintainers.
> > v6 - v7:
> > - style issues
> > v6:
> > - introduce new file
> > ---
> >   MAINTAINERS                  |  8 ++++
> >   crypto/Makefile              |  3 ++
> >   crypto/bpf_crypto_skcipher.c | 82 ++++++++++++++++++++++++++++++++++++
> 
> The changes are mostly isolated to the new bpf_crypto_skcipher.c file
> addition to the crypto/ but still will be helpful to get an Ack from the
> crypto maintainers (Herbert?).

Looks good to me.

Acked-by: Herbert Xu <herbert@gondor.apana.org.au>

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt