Received: by 2002:a05:7412:3290:b0:fa:6e18:a558 with SMTP id ev16csp485879rdb; Fri, 26 Jan 2024 01:25:18 -0800 (PST) X-Google-Smtp-Source: AGHT+IExodM3E3igEXK1VgYWU7G14DkpwM375IsNzcAhNDfl2yqYg9KrEbb9fjOPh+66J2GL/IMW X-Received: by 2002:a05:6a00:a17:b0:6dd:8a4c:bfb2 with SMTP id p23-20020a056a000a1700b006dd8a4cbfb2mr867427pfh.60.1706261118044; Fri, 26 Jan 2024 01:25:18 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1706261118; cv=pass; d=google.com; s=arc-20160816; b=A8XxG7AUXqJ9Ojiia1mJSKEOWldim3fwaFi3+TnYCwyl4500D8feiunE9lK5KRXtsI r/h3yRbftKlh0S9HaODk5idgqK/A2NXNFpsi/y0GcvVXp0jOmdlsP90+VB8H4uU7+c/g tpDhawQMIynN9Cis9CXVSyCMdBIYGnCLNGFuz+cnlzL3l4HeY0XaKJNT20UZQ6xG2QE1 9ip+kweIQ0lUH863zP4E4xJ1KR5CFI9YMMgYDWqCGKQUmvJQKbpjwTxLIwCG35AT+wHN bdb9CUIdsGbqzH8KWPhbsBEvH/Dr7hpsSLww4+YsK1nW/VYQ9s7cbW7hmRXAZL60A6M+ IaqQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=2kjpl7J4Hd0cQwYyPFdEM/2tFTvgfhDpQQaBhDEaMyY=; fh=/D49KBa3fyr96NYOa/LXBGD571yxC/n3ewN/DUvgBUc=; b=0cw4Uy+wFDq/kVjxcO23NsC2QY+YwrN0y67B7G+LBiRlNXzXlBj0a+g6ENt8glK0qE DTtFNNuKjNru2XclZtfZgiM3nYD01hTWfB7IT9nBD5sUDF3BeP9VAmDawVyOlAJelOm+ SpqpOsYcIo+nFlJiuRIZ6PHzRU7a4FvUPUVv33T5/km/8PsUQUMw8sFoyTWNKwEZ7ZQ+ 8Prrh2TIEzGd03MWUS6/W2gRu/75DWErsrHS9UZxQP8Qax94XCT3qObcYibnYLFAXBmq JmtqxfCJ57BeeNjfqwWVEIjG/RazE1anyvMS39rrQQZ+tbOX6LYN36Vvf0YKLOH6nymp M7tg== ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gondor.apana.org.au); spf=pass (google.com: domain of linux-crypto+bounces-1642-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-crypto+bounces-1642-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id f5-20020a056a000b0500b006dbdc3e21f0si829479pfu.322.2024.01.26.01.25.17 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 26 Jan 2024 01:25:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto+bounces-1642-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gondor.apana.org.au); spf=pass (google.com: domain of linux-crypto+bounces-1642-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-crypto+bounces-1642-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id 6C7F8B25BAD for ; Fri, 26 Jan 2024 09:17:07 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id CB8DC208D0; Fri, 26 Jan 2024 08:29:09 +0000 (UTC) X-Original-To: linux-crypto@vger.kernel.org Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BB2331BF31 for ; Fri, 26 Jan 2024 08:29:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=144.6.53.87 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706257749; cv=none; b=iYdJjzxd5d3gMGkV7CHlsPCRm1AI+ZxMIVn1xnYWF8pINZtLBcGJIZt/nOq4KP36LSqlJ3oCVY0iuCuC+TTs59QvkreyyD2W8NqRmiv/qA4Sydpm1ZsaziqeBz44Pqip2wa/0vhIcYjb3mf7y212E36RO2tJic8mgrFbC5FjZxU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1706257749; c=relaxed/simple; bh=0pazT6/+PhaI5hwbDlQ0W/arHusjdRVzz573NNFeBIQ=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=rsq3xxj5MsinFdnbW2JWPafGItbpGUMdycm5yWRV8GrUSBbcdXZNHIzWzcAR7y7lNMAxVICdeQanvZsuZvrNIAEZm19NuCibC7NHPtMYEoQy9ngU5PS6qbVhIZKqq8H2oBG5zQo5RwTj6KrHNO3dzZW68uDLbya5sjjy4juGuzU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au; spf=pass smtp.mailfrom=gondor.apana.org.au; arc=none smtp.client-ip=144.6.53.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gondor.apana.org.au Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1rTHa7-006E2p-Jc; Fri, 26 Jan 2024 16:29:00 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Fri, 26 Jan 2024 16:29:12 +0800 Date: Fri, 26 Jan 2024 16:29:12 +0800 From: Herbert Xu To: Joachim Vandersmissen Cc: linux-crypto@vger.kernel.org Subject: Re: [PATCH] crypto: rsa - restrict plaintext/ciphertext values more in FIPS mode Message-ID: References: <20240121194901.344206-1-git@jvdsn.com> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, Jan 26, 2024 at 12:13:00AM -0600, Joachim Vandersmissen wrote: > > Yes, mathematically speaking the values 1 and n - 1 aren't suitable for RSA > (they will always be fixed points). I simply didn't want to introduce a > breaking change. If you think a breaking change is acceptable, I can update > the patch to replace the RFC3447 check with the stricter check. Please do. We can always change it later if someone complains. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt