Received-SPF: pass (google.com: domain of linux-crypto+bounces-1741-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Mon, 29 Jan 2024 15:49:27 +0000
From: Conor Dooley <conor@kernel.org>
To: Eric Biggers <ebiggers@kernel.org>
Cc: linux-riscv@lists.infradead.org, linux-crypto@vger.kernel.org,
	llvm@lists.linux.dev, Brandon Wu <brandon.wu@sifive.com>,
	Nathan Chancellor <nathan@kernel.org>
Subject: Re: [PATCH] RISC-V: fix check for zvkb with tip-of-tree clang
Message-ID: <20240129-always-nurture-f5fe831b8bb2@spud>
References: <20240127090055.124336-1-ebiggers@kernel.org>
Precedence: bulk
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
	protocol="application/pgp-signature"; boundary="EL2F3hYGXg3SLtEB"
Content-Disposition: inline
In-Reply-To: <20240127090055.124336-1-ebiggers@kernel.org>


--EL2F3hYGXg3SLtEB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Sat, Jan 27, 2024 at 01:00:54AM -0800, Eric Biggers wrote:
> From: Eric Biggers <ebiggers@google.com>
>=20
> LLVM commit 8e01042da9d3 ("[RISCV] Add missing dependency check for Zvkb
> (#79467)") broke the check used by the TOOLCHAIN_HAS_VECTOR_CRYPTO
> kconfig symbol because it made zvkb start depending on v or zve*.  Fix
> this by specifying both v and zvkb when checking for support for zvkb.

Seems like a reasonable change on the part of LLVM.
Reviewed-by: Conor Dooley <conor.dooley@microchip.com>

Cheers,
Conor.

>=20
> Signed-off-by: Eric Biggers <ebiggers@google.com>
> ---
>  arch/riscv/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>=20
> diff --git a/arch/riscv/Kconfig b/arch/riscv/Kconfig
> index b49016bb5077b..912fff31492b9 100644
> --- a/arch/riscv/Kconfig
> +++ b/arch/riscv/Kconfig
> @@ -581,21 +581,21 @@ config TOOLCHAIN_HAS_ZBB
>  	default y
>  	depends on !64BIT || $(cc-option,-mabi=3Dlp64 -march=3Drv64ima_zbb)
>  	depends on !32BIT || $(cc-option,-mabi=3Dilp32 -march=3Drv32ima_zbb)
>  	depends on LLD_VERSION >=3D 150000 || LD_VERSION >=3D 23900
>  	depends on AS_HAS_OPTION_ARCH
> =20
>  # This symbol indicates that the toolchain supports all v1.0 vector cryp=
to
>  # extensions, including Zvk*, Zvbb, and Zvbc.  LLVM added all of these a=
t once.
>  # binutils added all except Zvkb, then added Zvkb.  So we just check for=
 Zvkb.
>  config TOOLCHAIN_HAS_VECTOR_CRYPTO
> -	def_bool $(as-instr, .option arch$(comma) +zvkb)
> +	def_bool $(as-instr, .option arch$(comma) +v$(comma) +zvkb)
>  	depends on AS_HAS_OPTION_ARCH
> =20
>  config RISCV_ISA_ZBB
>  	bool "Zbb extension support for bit manipulation instructions"
>  	depends on TOOLCHAIN_HAS_ZBB
>  	depends on MMU
>  	depends on RISCV_ALTERNATIVE
>  	default y
>  	help
>  	   Adds support to dynamically detect the presence of the ZBB
>=20
> base-commit: cb4ede926134a65bc3bf90ed58dace8451d7e759
> --=20
> 2.43.0
>=20
>=20
> _______________________________________________
> linux-riscv mailing list
> linux-riscv@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-riscv

--EL2F3hYGXg3SLtEB
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iHUEABYIAB0WIQRh246EGq/8RLhDjO14tDGHoIJi0gUCZbfJBwAKCRB4tDGHoIJi
0gPKAP4wBaV9cReJkJDl06WUVEYJxyYVr3Il1OGMyQgDVaCHKAD+L7LWWskK+HJW
fTp58Q6g61eD/wtV2oyASlZrEQ8f2g4=
=khU5
-----END PGP SIGNATURE-----

--EL2F3hYGXg3SLtEB--