Received-SPF: pass (google.com: domain of linux-crypto+bounces-1766-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Precedence: bulk
MIME-Version: 1.0
References: <20240130112740.882183-1-pizhenwei@bytedance.com>
In-Reply-To: <20240130112740.882183-1-pizhenwei@bytedance.com>
From: Jason Wang <jasowang@redhat.com>
Date: Thu, 1 Feb 2024 13:49:11 +0800
Message-ID: <CACGkMEsrMcAbrsfupDJ_fK_RTA8zRtGh77UBHeXZMiRxCaWypg@mail.gmail.com>
Subject: Re: [PATCH] crypto: virtio/akcipher - Fix stack overflow on memcpy
To: zhenwei pi <pizhenwei@bytedance.com>
Cc: arei.gonglei@huawei.com, mst@redhat.com, herbert@gondor.apana.org.au, 
	xuanzhuo@linux.alibaba.com, virtualization@lists.linux.dev, nathan@kernel.org, 
	linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, 
	davem@davemloft.net
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Tue, Jan 30, 2024 at 7:28=E2=80=AFPM zhenwei pi <pizhenwei@bytedance.com=
> wrote:
>
> sizeof(struct virtio_crypto_akcipher_session_para) is less than
> sizeof(struct virtio_crypto_op_ctrl_req::u), copying more bytes from
> stack variable leads stack overflow. Clang reports this issue by
> commands:
> make -j CC=3Dclang-14 mrproper >/dev/null 2>&1
> make -j O=3D/tmp/crypto-build CC=3Dclang-14 allmodconfig >/dev/null 2>&1
> make -j O=3D/tmp/crypto-build W=3D1 CC=3Dclang-14 drivers/crypto/virtio/
>   virtio_crypto_akcipher_algs.o
>
> Fixes: 59ca6c93387d ("virtio-crypto: implement RSA algorithm")
> Link: https://lore.kernel.org/all/0a194a79-e3a3-45e7-be98-83abd3e1cb7e@ro=
eck-us.net/
> Signed-off-by: zhenwei pi <pizhenwei@bytedance.com>

Acked-by: Jason Wang <jasowang@redhat.com>

Thanks