Received-SPF: pass (google.com: domain of linux-crypto+bounces-1791-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Alexey Romanov <avromanov@salutedevices.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
CC: "neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
	"clabbe@baylibre.com" <clabbe@baylibre.com>, "herbert@gondor.apana.org.au"
	<herbert@gondor.apana.org.au>, "davem@davemloft.net" <davem@davemloft.net>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>, "khilman@baylibre.com"
	<khilman@baylibre.com>, "jbrunet@baylibre.com" <jbrunet@baylibre.com>,
	"martin.blumenstingl@googlemail.com" <martin.blumenstingl@googlemail.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"linux-amlogic@lists.infradead.org" <linux-amlogic@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, kernel <kernel@sberdevices.ru>
Subject: Re: [PATCH v2 03/20] drviers: crypto: meson: add platform data
Thread-Topic: [PATCH v2 03/20] drviers: crypto: meson: add platform data
Thread-Index: AQHaTh1s2/zZexXjGk+hgEk0Ax0wPrDoX/oAgA01jwA=
Date: Thu, 1 Feb 2024 17:13:56 +0000
Message-ID: <20240201171352.ut5xhw3u2b77v33d@cab-wsm-0029881>
References: <20240123165831.970023-1-avromanov@salutedevices.com>
 <20240123165831.970023-4-avromanov@salutedevices.com> <ZbC8qLXogjxJD8LD@Red>
In-Reply-To: <ZbC8qLXogjxJD8LD@Red>
Accept-Language: ru-RU, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <E74E91B6684D234DA5CB2A0551E4FAC0@sberdevices.ru>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0

Hello,

On Wed, Jan 24, 2024 at 08:30:48AM +0100, Corentin Labbe wrote:
> Le Tue, Jan 23, 2024 at 07:58:14PM +0300, Alexey Romanov a 'ecrit :
> > To support other Amlogic SoC's we have to
> > use platform data: descriptors and status registers
> > offsets are individual for each SoC series.
> >=20
> > Signed-off-by: Alexey Romanov <avromanov@salutedevices.com>
> > ---
> >  drivers/crypto/amlogic/amlogic-gxl-cipher.c |  2 +-
> >  drivers/crypto/amlogic/amlogic-gxl-core.c   | 31 +++++++++++++++------
> >  drivers/crypto/amlogic/amlogic-gxl.h        | 11 ++++++++
> >  3 files changed, 35 insertions(+), 9 deletions(-)
> >=20
> > diff --git a/drivers/crypto/amlogic/amlogic-gxl-cipher.c b/drivers/cryp=
to/amlogic/amlogic-gxl-cipher.c
> > index b19032f92415..7eff3ae7356f 100644
> > --- a/drivers/crypto/amlogic/amlogic-gxl-cipher.c
> > +++ b/drivers/crypto/amlogic/amlogic-gxl-cipher.c
> > @@ -225,7 +225,7 @@ static int meson_cipher(struct skcipher_request *ar=
eq)
> > =20
> >  	reinit_completion(&mc->chanlist[flow].complete);
> >  	mc->chanlist[flow].status =3D 0;
> > -	writel(mc->chanlist[flow].t_phy | 2, mc->base + (flow << 2));
> > +	writel(mc->chanlist[flow].t_phy | 2, mc->base + ((mc->pdata->descs_re=
g + flow) << 2));
> >  	wait_for_completion_interruptible_timeout(&mc->chanlist[flow].complet=
e,
> >  						  msecs_to_jiffies(500));
> >  	if (mc->chanlist[flow].status =3D=3D 0) {
> > diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto=
/amlogic/amlogic-gxl-core.c
> > index a58644be76e9..2be381e157c4 100644
> > --- a/drivers/crypto/amlogic/amlogic-gxl-core.c
> > +++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
> > @@ -18,6 +18,7 @@
> >  #include <linux/kernel.h>
> >  #include <linux/module.h>
> >  #include <linux/of.h>
> > +#include <linux/of_device.h>
> >  #include <linux/platform_device.h>
> > =20
> >  #include "amlogic-gxl.h"
> > @@ -30,9 +31,10 @@ static irqreturn_t meson_irq_handler(int irq, void *=
data)
> > =20
> >  	for (flow =3D 0; flow < mc->flow_cnt; flow++) {
> >  		if (mc->chanlist[flow].irq =3D=3D irq) {
> > -			p =3D readl(mc->base + ((0x04 + flow) << 2));
> > +			p =3D readl(mc->base + ((mc->pdata->status_reg + flow) << 2));
> >  			if (p) {
> > -				writel_relaxed(0xF, mc->base + ((0x4 + flow) << 2));
> > +				writel_relaxed(0xF, mc->base +
> > +					      ((mc->pdata->status_reg + flow) << 2));
> >  				mc->chanlist[flow].status =3D 1;
> >  				complete(&mc->chanlist[flow].complete);
> >  				return IRQ_HANDLED;
> > @@ -245,15 +247,34 @@ static void meson_unregister_algs(struct meson_de=
v *mc)
> >  	}
> >  }
> > =20
> > +static const struct meson_pdata meson_gxl_pdata =3D {
> > +	.descs_reg =3D 0x0,
> > +	.status_reg =3D 0x4,
> > +};
> > +
> > +static const struct of_device_id meson_crypto_of_match_table[] =3D {
> > +	{
> > +		.compatible =3D "amlogic,gxl-crypto",
> > +		.data =3D &meson_gxl_pdata,
> > +	},
> > +	{},
> > +};
> > +
> >  static int meson_crypto_probe(struct platform_device *pdev)
> >  {
> > +	const struct of_device_id *match;
> >  	struct meson_dev *mc;
> >  	int err;
> > =20
> > +	match =3D of_match_device(meson_crypto_of_match_table, &pdev->dev);
> > +	if (!match)
> > +		return -EINVAL;
> > +
> >  	mc =3D devm_kzalloc(&pdev->dev, sizeof(*mc), GFP_KERNEL);
> >  	if (!mc)
> >  		return -ENOMEM;
> > =20
> > +	mc->pdata =3D match->data;
> >  	mc->dev =3D &pdev->dev;
> >  	platform_set_drvdata(pdev, mc);
> > =20
> > @@ -312,12 +333,6 @@ static void meson_crypto_remove(struct platform_de=
vice *pdev)
> >  	clk_disable_unprepare(mc->busclk);
> >  }
> > =20
> > -static const struct of_device_id meson_crypto_of_match_table[] =3D {
> > -	{ .compatible =3D "amlogic,gxl-crypto", },
> > -	{}
> > -};
> > -MODULE_DEVICE_TABLE(of, meson_crypto_of_match_table);
>=20
> Hello
>=20
> This patch breaks bisection, since it removes MODULE_DEVICE_TABLE.
> After applying patchs 1,2,3 the driver does not load anymore on lepotato =
board.

Please, give more information.=20

I applied the first 3 patches and the driver probes correctly.

>=20
> Regards

--=20
Thank you,
Alexey=