Received-SPF: pass (google.com: domain of linux-crypto+bounces-1836-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
From: Kshitiz Varshney <kshitiz.varshney@nxp.com>
To: Shawn Guo <shawn.gsc@gmail.com>
CC: Herbert Xu <herbert@gondor.apana.org.au>, Shawn Guo <shawnguo@kernel.org>,
	Sascha Hauer <s.hauer@pengutronix.de>, Fabio Estevam <festevam@gmail.com>,
	dl-linux-imx <linux-imx@nxp.com>, Pengutronix Kernel Team
	<kernel@pengutronix.de>, Varun Sethi <V.Sethi@nxp.com>, Gaurav Jain
	<gaurav.jain@nxp.com>, Pankaj Gupta <pankaj.gupta@nxp.com>, Sahil Malhotra
	<sahil.malhotra@nxp.com>, Vabhav Sharma <vabhav.sharma@nxp.com>, Meenakshi
 Aggarwal <meenakshi.aggarwal@nxp.com>, Rahul Kumar Yadav
	<rahulkumar.yadav@nxp.com>, Nikhil Singla <nikhil.singla@nxp.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [EXT] Re: [PATCH v1] imx_v6_v7_defconfig: Enable sm3, sm4,
 polyval, xctr cipher test support
Thread-Topic: [EXT] Re: [PATCH v1] imx_v6_v7_defconfig: Enable sm3, sm4,
 polyval, xctr cipher test support
Thread-Index: AQHaMzkv0uKPr9fQ6U+/vbkIUpb10rD48jOAgAL3fjA=
Date: Mon, 5 Feb 2024 11:42:19 +0000
Message-ID:
 <DB6PR04MB3190048410A18A231D5B7FC08F472@DB6PR04MB3190.eurprd04.prod.outlook.com>
References: <20231220113857.1127598-1-kshitiz.varshney@nxp.com>
 <20240203142149.GI463595@dragon>
In-Reply-To: <20240203142149.GI463595@dragon>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?h3jHklNUv+Evk5YzOeKif6LhPwYVIY+1fppeZU8F5l+M1lrzyN2DcN3g5I8m?=
 =?us-ascii?Q?FU29OIlrGcELybQkxRW+arh6/fwVQ1uKvGknUTVT9m0g7GHrCslDFHgX2nv/?=
 =?us-ascii?Q?rixcrhGoE95Cjp22HPP1GF8e9scwTspUNDDN+x36G3lOvx4dTEfvwB+38XvY?=
 =?us-ascii?Q?6zVbsn3HKg6vkKjiph4viez+6VPMPqQLgDqqAMJ5qreLESJCizcdGCHyS1tm?=
 =?us-ascii?Q?m4LpTVMqKnWp1X9wTSLH8l5WAU1R0s10r8kRYj6IcZ2YDqqz8wjwbDD7iGY7?=
 =?us-ascii?Q?KdTh0gHcTyhfT0co/GDOQDs2rIerzFZRSh87Bsp+Ub3t/5j2QQMG/7CkeELK?=
 =?us-ascii?Q?AAnyIASYdZbfdzN5Qp3FBWGb5o8cKPMbQy3HXWojukL8NEuqVhFJK9EP3E07?=
 =?us-ascii?Q?rePLu0AXAzE+O4gJnH2jlC5JO/UmRw1udbKXNRdZgf7ZtR1xGxY60I0Eapwt?=
 =?us-ascii?Q?No0Rt9nlX4LXUZdV6/5uwjeUnWS47WysSAM3qx885fR0Off1nl5mzZPvlUGV?=
 =?us-ascii?Q?89rEWc6oojTpJAH0T4wUtynr+HcWv/r9bMaYz8TSOk1R+aQkde3K4wRFD7kC?=
 =?us-ascii?Q?6nh5da+rrnje583GhQ3xUjG1JOX0kZXqclqGyLI62tIAyeLoCp3Kh0t4PzbC?=
 =?us-ascii?Q?CU7GbESSlelPRM4zWGQozR9rosQ5K0hhGhi+rDw0vhPF6CR8sutefGcEZ6O+?=
 =?us-ascii?Q?yoFB7mMrdI9JoSr4oTT6klO/e5qJ4PSj2VvmuS+C/UJHFwMSb2hNXFLBalBO?=
 =?us-ascii?Q?cVCP1ISOR/P0bSstBRAFWivd4RUsoNWyew73/1xOA1m9PUIVFHf+N2mMwtfK?=
 =?us-ascii?Q?3RJPtV0CfWxhq+XzIuaAB8SlWxuvZsT7tL9SJAIEteUazVHEJ/TphWMAQAxk?=
 =?us-ascii?Q?EEn7MM09g05eERPv5UnqmTrVnHj1rFjDF/kIiu4fraQx/N46MOT73RVHT8/m?=
 =?us-ascii?Q?QddddEzSx4OdBfZVIdwIZKUCnpl6Raj1mu3eLdZOsrHekJCYLI751OvkMAFN?=
 =?us-ascii?Q?nKURN9OIE0AfFx9L37A6vQFf6u398GA3XrTWQiQAt+fahbmHQlDHrf0zHaWI?=
 =?us-ascii?Q?OmF5Uql1N3tSiE63hw43gZjbSL9g8mF8TtT8KQPssAzQwbzh+hdCfR+MhI4F?=
 =?us-ascii?Q?Tvl86ws3zfiaBJsJWa186yWpxoYkGaHW19qpmRBbnGlA2qbtQsb7zyWHdApm?=
 =?us-ascii?Q?jI3PdATT+Gq8mCU7q+4FFOPgXDa50vSOeRkbc6knfUroXQQXq7Extt1lwxoR?=
 =?us-ascii?Q?NzzWMZXv5ed1CEHtDTVxXbZQeE4++fmOav0HDEShns7VxDxcnnh81NSpfGib?=
 =?us-ascii?Q?hmhipYiZD4IyTpRRjgKaA+DZSbb5XjufWtszP+RRhgwnQGP+GGsOvmmHWfuh?=
 =?us-ascii?Q?4f/DgULqL8Q7Ur2CPlh9QgEbOdxpH6aUAoazUdrk1HVsZ2uj5A097Fmq9B5O?=
 =?us-ascii?Q?2M1nyemJc3z9LbmW+7sVKQCGVpSn9wgmYC3FugyDY0wWwNdjk+boqhff2vGF?=
 =?us-ascii?Q?1dMVpRM1c4ITUDME8qEwbSQREFbVcLdGxaH/cWAcyO+2bjVm+Fvu0CgeiKKU?=
 =?us-ascii?Q?Jslt8eT+vy1Dv9E8iEXlbGSxr9iO//Ncndyv9GlM?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-crypto@vger.kernel.org
List-Id: <linux-crypto.vger.kernel.org>
List-Subscribe: <mailto:linux-crypto+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-crypto+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DB6PR04MB3190.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 845643ff-d733-4026-8136-08dc263f82da
X-MS-Exchange-CrossTenant-originalarrivaltime: 05 Feb 2024 11:42:19.9506
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: Ez5UGDmCOMFYcuvKIE+RvnZDfVmsKZiwblLxWJIMakEwLK//qm7MhNFlLT9e940xys/BXtQBnKfT+jYO47J8rYQBjBFjK3OieeO7Z8zBQhE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAXPR04MB8909


> -----Original Message-----
> From: Shawn Guo <shawn.gsc@gmail.com>
> Sent: Saturday, February 3, 2024 7:52 PM
> To: Kshitiz Varshney <kshitiz.varshney@nxp.com>
> Cc: Herbert Xu <herbert@gondor.apana.org.au>; Shawn Guo
> <shawnguo@kernel.org>; Sascha Hauer <s.hauer@pengutronix.de>; Fabio
> Estevam <festevam@gmail.com>; dl-linux-imx <linux-imx@nxp.com>;
> Pengutronix Kernel Team <kernel@pengutronix.de>; Varun Sethi
> <V.Sethi@nxp.com>; Gaurav Jain <gaurav.jain@nxp.com>; Pankaj Gupta
> <pankaj.gupta@nxp.com>; Sahil Malhotra <sahil.malhotra@nxp.com>;
> Vabhav Sharma <vabhav.sharma@nxp.com>; Meenakshi Aggarwal
> <meenakshi.aggarwal@nxp.com>; Rahul Kumar Yadav
> <rahulkumar.yadav@nxp.com>; Nikhil Singla <nikhil.singla@nxp.com>;
> linux-crypto@vger.kernel.org; linux-kernel@vger.kernel.org
> Subject: [EXT] Re: [PATCH v1] imx_v6_v7_defconfig: Enable sm3, sm4,
> polyval, xctr cipher test support
>=20
> Caution: This is an external email. Please take care when clicking links =
or
> opening attachments. When in doubt, report the message using the 'Report
> this email' button
>=20
>=20
> On Wed, Dec 20, 2023 at 12:38:57PM +0100, Kshitiz Varshney wrote:
> >     Enable config for sm3, sm4, polyval, xctr cipher test as built in m=
odule.
> >
> >     Issue:-
> >     Multiple crypto tests like sm3, sm4 xctr and polyval failing.
> >
> >     skcipher: failed to allocate transform for xctr(aes): -2
> >     alg: self-tests for xctr(aes) using xctr(aes) failed (rc=3D-2)
> >     alg: self-tests for sm3 using sm3 failed (rc=3D-2)
> >     tcrypt: failed to load transform for sm3: -2
> >     alg: hash: failed to allocate transform for polyval: -2
> >     alg: self-tests for polyval using polyval failed (rc=3D-2)
> >
> >     Resolution:-
> >     Enabling CONFIG_CRYPTO_SM3_GENERIC,
> CONFIG_CRYPTO_SM4_GENERIC,
> >     CONFIG_CRYPTO_HCTR2, CONFIG_CRYPTO_ARIA as module enables
> support of
> >     sm3, sm4, aria, polyval & xctr.
> >
> >     Signed-off-by: Kshitiz Varshney <kshitiz.varshney@nxp.com>
>=20
> The commit log and Signed-off-by lines shouldn't have leading
> spaces/indent.=20
Checkpatch has not reported any such issues.
>=20
> > ---
> >  arch/arm/configs/imx_v6_v7_defconfig | 4 ++++
> >  1 file changed, 4 insertions(+)
> >
> > diff --git a/arch/arm/configs/imx_v6_v7_defconfig
> > b/arch/arm/configs/imx_v6_v7_defconfig
> > index 0a90583f9f01..627f57da9d5b 100644
> > --- a/arch/arm/configs/imx_v6_v7_defconfig
> > +++ b/arch/arm/configs/imx_v6_v7_defconfig
> > @@ -484,3 +484,7 @@ CONFIG_DEBUG_FS=3Dy
> >  # CONFIG_SLUB_DEBUG is not set
> >  # CONFIG_SCHED_DEBUG is not set
> >  # CONFIG_FTRACE is not set
> > +CONFIG_CRYPTO_HCTR2=3Dm
> > +CONFIG_CRYPTO_SM3_GENERIC=3Dm
> > +CONFIG_CRYPTO_SM4_GENERIC=3Dm
> > +CONFIG_CRYPTO_ARIA=3Dm
>=20
> Instead of adding lines at the end of file, please use help from 'make
> savedefconfig' to get them appear at the correct places.
Changes done in v2.
>=20
> Shawn