Received-SPF: pass (google.com: domain of linux-crypto+bounces-1877-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Date: Tue, 6 Feb 2024 12:26:40 +0000
From: "Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>
To: Lenko Donchev <lenko.donchev@gmail.com>
CC: Herbert Xu <herbert@gondor.apana.org.au>, "David S. Miller"
	<davem@davemloft.net>, "Gustavo A. R. Silva" <gustavoars@kernel.org>,
	<qat-linux@intel.com>, <linux-crypto@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>, <linux-hardening@vger.kernel.org>
Subject: Re: [PATCH] crypto: qat - use kcalloc() instead of kzalloc()
Message-ID: <ZcIlgLvH08xlmmXY@gcabiddu-mobl.ger.corp.intel.com>
References: <ZbeguDTmVrP9SnDr@nixos>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZbeguDTmVrP9SnDr@nixos>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Kcy1JW2rWIiuiDBuPfBK5RucAjkdsGSKbXS5aUUv5nnXzF6rvjiIiLuLg6Eu?=
 =?us-ascii?Q?EeqCCt0j76srmxV19qwifx4f8ixvxt/4Zw+dNDnMDYZWnczuXu/xYv1YFZ2f?=
 =?us-ascii?Q?mLKjvxh8OnzHU7YKdNuNcg/iZis3t3eRnc3GzxGv0lwf2tDRJjedfSVlXl44?=
 =?us-ascii?Q?7bs19tr+OjpjNBwDKqY9QwZJuQGH2UDUIIk4xLzeheVi0ZPJnLuCudICBy4A?=
 =?us-ascii?Q?+ks4PU/JCuLfceVd55BYeD1DwDM7kvgUdCHvPquf25t7HbI8LV3qY6k9a7mq?=
 =?us-ascii?Q?kjDcneUOealjvzbQY/rurShp4QewbWWksjjv0Mp42SrgHzZDGWEbocI3p1mG?=
 =?us-ascii?Q?YKbzz4eBlOQaVPLlmMlzlGeS09pmQQfQt3Jhsc1jDgLLrCzyc2LOtyu7taZP?=
 =?us-ascii?Q?QD7bV/WpEKcNeA1fx1+xu1rzSRwFOI39cUdmeCsREfXHUWOWxCuRF6iXKeEx?=
 =?us-ascii?Q?5NiR08kBpQEHZ05nL9zUp1qQcgx08w9GSg75nzy7D//zbz+0oZRiIAOodCpb?=
 =?us-ascii?Q?IMyxtm27gftViSoDW/QDWklzRUjpmGFKE+bJKgrRJ0Ljfp0nNO9LVd8mbltf?=
 =?us-ascii?Q?QL6TEpvAMwc27ATA8ZCD9ZaO5O8NuDpB1WH/3FNzLukjhcajn1B01kLA4jU7?=
 =?us-ascii?Q?mGnSSCQP098NWWbPBnSuHAOcfQ7frOWODDLq9b/s62mGaYClXPRbuyj6gryK?=
 =?us-ascii?Q?qC8TVf7vTG2p/Q7ejIPqccxPz4UtCnn9w7DRdXRkwieIF0odMguGoriRCkkI?=
 =?us-ascii?Q?rC0GBL/guhgaGdkLyOS/GlhH3OuMIGfG8sK+8pL0BpEj3CBBwwDpd6uJmYDm?=
 =?us-ascii?Q?6BVwdF3NpER4k/xFB9CpOIW9ZTi5SENXTvI2CDE2f57/rlOtSZ5EirK1NSBA?=
 =?us-ascii?Q?M8j5ZJSZaZ7ExAcVV3Rpm1CvujGLQEU2K0Ilx4wksEqZtpYlKv0wdULxvJXm?=
 =?us-ascii?Q?OmOemsFGRMkqPs3IDPfz/9TSokVeUIEJveEy6ToO+p22rjzVedHlof1h515D?=
 =?us-ascii?Q?FqvDXW5TuhTdCZsBhKRuN8qFXRnq4M9YbZoNCp+H1PCRq5RhrrfyYO4lSHOs?=
 =?us-ascii?Q?Iza6JJXXNuVJFMKrI3/hS/8mefZyah66+ucyP4JZKBuF6/c2i7T6kWEUNYMH?=
 =?us-ascii?Q?n6IyFktAO+vvjXQe0lE7gRKIq7saE3ukpuNAN7JrzUEC6THgED8js4eWAB9O?=
 =?us-ascii?Q?+9ybtO9K2WI4NQdxHLv2+ACpDMMcbcr0VNOYdHq40wnsJW2O9/zytS2QucdV?=
 =?us-ascii?Q?/cX4Ry8x87kS5KKE8QmoR7UzsyvkK5hZlKx78yPGMePyoq4qemcbqJb+70l3?=
 =?us-ascii?Q?YdoTypsPBGn8jdZH+a6X6SH5xgLqyhowVbsu2g9uL/IlKmKXYL9Lg2KOpJ4W?=
 =?us-ascii?Q?AdDGAfU/HFUpKN+SnJETPtrDKTyEL3tstYrmneIba4HMM8Kb2CvWIOMd0qOd?=
 =?us-ascii?Q?UypyF7P5Q8oLSzkGMyH48tCfZHEncH9Yhcy7JHT2FSh9iWoUFVkFlsHldy9/?=
 =?us-ascii?Q?Gc/mcZSLqV5aba0Qzr84o2bbTSJp8zMnSKuyoYmWysMDNFOfF73RCgQ4PLX4?=
 =?us-ascii?Q?2tUVQ509M4P2SkvuVpHCYDHnUF47TZoZPaaoYARtCiJk5xxNSVOcoF+mY3/n?=
 =?us-ascii?Q?aQ=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 9a2331dd-0d6c-42e0-b876-08dc270ee39f
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 12:26:48.2644
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: WunrFlIx2i24PfnsZo1QoHZLiYVicXL7rOplXRNGsCIqm1MuNKdyok79lGU+CZz9qvRkE6VjSUAYGQ46LXR+YtnAgXcJ5sQ7/qLhAOeYkRE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH7PR11MB7596
X-OriginatorOrg: intel.com

On Mon, Jan 29, 2024 at 06:57:28AM -0600, Lenko Donchev wrote:
> We are trying to get rid of all multiplications from allocation
> functions to prevent integer overflows[1]. Here the multiplication is
> obviously safe, but using kcalloc() is more appropriate and improves
> readability. This patch has no effect on runtime behavior.
> 
> Link: https://github.com/KSPP/linux/issues/162 [1]
> Link: https://www.kernel.org/doc/html/next/process/deprecated.html#open-coded-arithmetic-in-allocator-arguments [2]
> 
> Signed-off-by: Lenko Donchev <lenko.donchev@gmail.com>
Thanks for your patch.
The same change was already applied to the cryptodev tree about two
weeks ago. See 4da3bc65d218 ("crypto: qat - use kcalloc_node() instead of
kzalloc_node()") [1].

[1] https://git.kernel.org/pub/scm/linux/kernel/git/herbert/cryptodev-2.6.git/commit/?id=4da3bc65d218605557696109e42cfeee666d601f

Regards,

-- 
Giovanni