Received-SPF: pass (google.com: domain of linux-crypto+bounces-1882-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
Date: Tue, 6 Feb 2024 14:42:38 +0000
From: "Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
CC: <qat-linux@intel.com>, <linux-crypto@vger.kernel.org>
Subject: Re: Failed self-test on ffdhe6144(qat-dh)
Message-ID: <ZcJFXtTZXKng7hKv@gcabiddu-mobl.ger.corp.intel.com>
References: <ZcC/C/kpcKaoVPp4@gondor.apana.org.au>
 <ZcDwxipP+CR8LBE8@gcabiddu-mobl.ger.corp.intel.com>
 <ZcHAlLdWfMhcACn5@gondor.apana.org.au>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <ZcHAlLdWfMhcACn5@gondor.apana.org.au>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?W0Ty8EacPxovHjRHFDfkqjPb5pEmaslcQEY52OEHt4Bmm/7HMQ2F7h3Vjbm8?=
 =?us-ascii?Q?dHoz5Q2INkmNuAWMfgGhoM0DhjTX/8dLT/zkp9CZSGdsGiha87lfx2719yQL?=
 =?us-ascii?Q?1HaYrFJGZSlD+pRFryFnMpgVN5ruyvJvWUlUaLi+Nno0uPojwF/iVHryrmTp?=
 =?us-ascii?Q?VTNXlU5Sy3Q4iMi044vwCxmtfYmphbnoEeXtTmO1bRsfrRygapcrMuLHzl2z?=
 =?us-ascii?Q?rnHoQ4VKgdpiMgeWd/JcVPp0mZxEtIV4fLvI/RDjPd/Xbx2BaMQJ9EaxyvBa?=
 =?us-ascii?Q?h7q62hsGMfHaRvAFmiJhGx4zJXAug/yWIxLlFhfHwnpSOi1Owsyl0IJiVoqj?=
 =?us-ascii?Q?tbBnyAPdVUxLmWiIjdn3EXdkbx+Cdr7slbobLOD0wWz/iTCnbPEEJvM7jr2g?=
 =?us-ascii?Q?XEPuV0SiZeUBglbTTN5gzHSbvboOYGR0CP3tVBLQd80Dcb2VIYxYTbcQkdrT?=
 =?us-ascii?Q?uHzMlQJ5chWDu7AziIGDjrifYLt2fcNwNKrgFjosTapAF72De0KrPV0woyc0?=
 =?us-ascii?Q?2V/6iLvxbc6sn9Rfnb2Y0rWKXdB6MYMLZg51rxie7D0KKBKVc/Amp4goo6T0?=
 =?us-ascii?Q?js+wvmKtVosbtbZ7ZkHijnQ1ezX2RFAdXCaCtz0OJj6hY818pDSZrJ0UaM+n?=
 =?us-ascii?Q?9Z50OKvR+ASDzGBZI0Wu/tK76ruO2LGDzolBc0ERrQdoIqjQIxaoglKCXQmP?=
 =?us-ascii?Q?sulO+djFx71R+Y8dzb9fSIf6RsrgofitW4jmZzsewfL1yvP4WqP/q3ClMYHU?=
 =?us-ascii?Q?KXn65o3eIo5HXm4/PJCvGtqxhlyz66Xzuf+GwOv+JWuSRq1u6fvLpqhQqEp8?=
 =?us-ascii?Q?Z44PYoZT7INB0Pqdh3v3ZrngP4a6CGCwIh4Bb+nestx58yhFLYeMnRFCMVQI?=
 =?us-ascii?Q?Jk3MfHjos0kj23z97I5vfziSfp8bqx2MXbjpI4EwcLiQGixo5ulAIkWLMIUK?=
 =?us-ascii?Q?5LEPrulixatkW6UhKyotMTzZGH90/IWEvFDSfkVyTt3xrTvAAb3c5zaLGQCe?=
 =?us-ascii?Q?o5aXnp2Br8zxyI3xueRNfh1rw9AAEKhxsAUbh5rL4buV3DPI/dcD/VSwJasN?=
 =?us-ascii?Q?3wMkNMixAfj7pW2uGnqKp2fNN67gtqpsoFwh4HE/K5LB3VUsoYtd3gdCO0/3?=
 =?us-ascii?Q?bbgI9Lj5uAE0qgpOSB0o6RSFNiv+LrWjg6Jaix8vdnzRTe/qkJtmVOPPdiXZ?=
 =?us-ascii?Q?apLiqczJT8HXLr8TlNTGtWDZKPAZjEkWYPbU7Jf/cqGdVQ/LY4yeNL3nRUcN?=
 =?us-ascii?Q?wR/kdX08Xv78uk9nzOFnNzoE8ej6hlLajTCEKFPoyD8Ps2L+6r5JXPJlG5uM?=
 =?us-ascii?Q?AC2AwbavkXwi/bmeHGci0VCH0EzbLCSzNf0WgD2pqcArI8P4pCXEWKFgk+tH?=
 =?us-ascii?Q?vgmL4GIWj43UW81OsEIxkKbyRIUHX68ctCa19b/wiyZOQHvvXazJc6YJapma?=
 =?us-ascii?Q?muEmyZAqeceX7uzvZnOu8EiqFD6W/sJlpPlKKkC7RGchD9gPlr8MIc3V6lVw?=
 =?us-ascii?Q?imbf3WXa+dthVIjQ56001S23FyD1SQ5OG7F73jOBAbxtciiY3YKXsJPyGB61?=
 =?us-ascii?Q?XwzppFYLje63PH//6iC1+Iv1tBXLv1eH7qewhaQ4yz6Gnj8zCtcDh91TWIoP?=
 =?us-ascii?Q?UA=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 01fdfb77-33a6-445e-d4e5-08dc2721dfd6
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Feb 2024 14:42:42.4060
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: KGAt+rewM8z7nkPtFKNGQ6/5IYlBUcUm3i732uM50lwmLs35kD0hC+EBtDSy6a513qLgIGODcRDEspcK2stlDhvhbZiQEWP8ApE+4VEsCPM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CO1PR11MB5028
X-OriginatorOrg: intel.com

On Tue, Feb 06, 2024 at 01:16:04PM +0800, Herbert Xu wrote:
> On Mon, Feb 05, 2024 at 02:29:26PM +0000, Cabiddu, Giovanni wrote:
> >
> > Thanks for the bug report.
> > I'm looking at it. It appears that even if I have
> > CONFIG_CRYPTO_DH_RFC7919_GROUPS=y, ffdhe is not getting registered.
> > I'm trying to understand what's going wrong.
> > 
> > BTW, do you have more details, like platform and kernel version?
> 
> This algorithm requires instantiation, so try:
> 
> modprobe tcrypt alg="ffdhe6144(dh)" type=8 mode=0 mask=15
Thanks Herbert. I can reproduce the issue.

6144-bit DH is not supported by QAT. The error code -22 (-EINVAL) is
returned by qat_dh_check_params_length() when validating the modulus
size [1].
The same is applicable to 8192-DH.

I believe the only option I have is to fallback to SW.

BTW, since ffdhe requires instantiation, I think we should extend the dh
test vectors so that they can find these issues with unsupported key
sizes. We can make those tests optional to
CONFIG_CRYPTO_MANAGER_EXTRA_TESTS.
What do you think?

[1] https://elixir.bootlin.com/linux/v6.8-rc3/source/drivers/crypto/intel/qat/qat_common/qat_asym_algs.c#L384

Thanks,

-- 
Giovanni