Received-SPF: pass (google.com: domain of linux-crypto+bounces-1891-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: Meenakshi Aggarwal <meenakshi.aggarwal@nxp.com>
To: Herbert Xu <herbert@gondor.apana.org.au>, Giovanni Cabiddu
	<giovanni.cabiddu@intel.com>
CC: Eric Biggers <ebiggers@kernel.org>, "agk@redhat.com" <agk@redhat.com>,
	"snitzer@kernel.org" <snitzer@kernel.org>, "linux-crypto@vger.kernel.org"
	<linux-crypto@vger.kernel.org>, "dm-devel@redhat.com" <dm-devel@redhat.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"qat-linux@intel.com" <qat-linux@intel.com>, "heinzm@redhat.com"
	<heinzm@redhat.com>, Horia Geanta <horia.geanta@nxp.com>, Varun Sethi
	<V.Sethi@nxp.com>, Pankaj Gupta <pankaj.gupta@nxp.com>, Gaurav Jain
	<gaurav.jain@nxp.com>, "davem@davemloft.net" <davem@davemloft.net>, Iuliana
 Prodan <iuliana.prodan@nxp.com>, Fiona Trahe <fiona.trahe@intel.com>
Subject: RE: [PATCH 1/3] dm integrity: do not filter algos with
 CRYPTO_ALG_ALLOCATES_MEMORY
Thread-Topic: [PATCH 1/3] dm integrity: do not filter algos with
 CRYPTO_ALG_ALLOCATES_MEMORY
Thread-Index: AQHZr19tPftu/4qhUE+Xly9w5Fkd4K+rmzCAgAAMzQCAABCvgIFUBGJw
Date: Wed, 7 Feb 2024 06:22:06 +0000
Message-ID:
 <PAXPR04MB8301C112A114A6AC5A19D69B8E452@PAXPR04MB8301.eurprd04.prod.outlook.com>
References: <20230705164009.58351-1-giovanni.cabiddu@intel.com>
 <20230705164009.58351-2-giovanni.cabiddu@intel.com>
 <20230705201205.GA866@sol.localdomain>
 <ZKXZUl4VgZkMbOL0@gcabiddu-mobl1.ger.corp.intel.com>
 <ZKXnUeueV6ncaJM6@gondor.apana.org.au>
In-Reply-To: <ZKXnUeueV6ncaJM6@gondor.apana.org.au>
Accept-Language: en-GB, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?o/G171hVFS0SHxAetPNPg0gKsVVMh6zs+JE3ZyzkyamJDMDd5w8o5KS/xkfh?=
 =?us-ascii?Q?auyyFjRYzv1jMhg1fu6k5dN6ArrpncliYDUlmLf5O3bDj7Xcm7sIMqX2EMcQ?=
 =?us-ascii?Q?yg/UGaKFu88U0N3X8JqSHVrAgQZvPjsXZoXQqwikeI2ZjMVFhXK+2uS1ciZx?=
 =?us-ascii?Q?YHkWHv9Eyng1My4dvSssEzHMURJDmprCAZaW63GWZPdRHjyLRp7q2AbVtO4b?=
 =?us-ascii?Q?mu5ibvrZyBt6jS7GEtpxP8W/9qNVG1m8p8faK1TNP4mHoPQ4Szx/Awo8V00Y?=
 =?us-ascii?Q?3FsTmaXbyJ9M/RPd0Q9vWmJvYQLKOfCyMl1etK1lBpNjGrwPBmKdVxdNH0aE?=
 =?us-ascii?Q?+5N06DW/tJR11As5AWc79v0GMUGlRmrqUnHw9qBK7oZAoz/ZSt9rr8nAv1Ru?=
 =?us-ascii?Q?KRJ8KbkW+3SKPcXi+IuxItsiHZIUjxRJGF6996QdUGI9m+Aq/xpApY8+gP0Y?=
 =?us-ascii?Q?7SLIf/7hHaPU5fUrdbUwxDHZNW93qP2r13+d+91qnFq4BAz0g2oUhbNhdJ6L?=
 =?us-ascii?Q?WRBc5jsCZU5jeMeY+oel0pSj4EJzUFSR12Se+aPmtcz8guBjhYRLh/gZdaC4?=
 =?us-ascii?Q?pNxY3DeVEs7qwy8IimtNlb2Dz9bkT2o4i7l6kQXTlV4YpQxk1ZG/fYym0Tkw?=
 =?us-ascii?Q?krAL4sYR95yzKDCZZNaVs9Hqo8Wc55HUCzjS6LRyPizN6YhuwuoMJFmMIEl4?=
 =?us-ascii?Q?rdwr3kUhMHV4+1d8lgA65Z5O9Vh2aGFjgtjEo9POCk0YhJGoxJGHxP234IIy?=
 =?us-ascii?Q?2wGmaLPTh5aScAAD1ca83HjPMUxp4rbcQ2kunpR/pwPcbGfHIjUjHNIsE84m?=
 =?us-ascii?Q?ajz8EzA7eXugfBAHO+u6NFQis2k/Z9CAlvpoJyxQQXBCoGA3yAqPsMYjjr4W?=
 =?us-ascii?Q?VqrouiAtw+P9cKSKbtlEf5ov9tjWU1+SBzED47BPRj8JRIJARDTuGU9eTUbj?=
 =?us-ascii?Q?/mbyfY+X4XVJO8zzxsw/3eAmmGR5SyqFTgXoJ+FcaTyfQwHqhM44Vnsdhsw7?=
 =?us-ascii?Q?4XhZTkeyPXkQkP4rO7D26Hv+uQhi3VtxnwTEt7ISxxfaRaUc5p0ykJW8M1df?=
 =?us-ascii?Q?RKKrV0yQQDeQI3KrrchP8NJipYd+u69v8/X04Z/emwDaKXWlycpBv5KTf7LH?=
 =?us-ascii?Q?o+2OmsDJwvmv7FFfcLO+mgieO/Ad4Vn7fXMKxtexqtyVubM8wB6qVCEPW3B6?=
 =?us-ascii?Q?zbXaL5mcO+KudzQOVU7Zy4TSnk9yp4Qf0AX3PHwFmRw1LpiDETamwfWbPnWU?=
 =?us-ascii?Q?xtlTPxkqQfAoB8cEWeL92RfNcccSbGSHrVTanQACPsqT/NpWO4kLEgj9hYDC?=
 =?us-ascii?Q?APqiniIyKZUwsU3zMxPiwWlEV3m3/+ws9E+5W3TZyQ7MTpttqcFzDUU4ebbu?=
 =?us-ascii?Q?/gEPd9mccBid5W2HTJNpgxfS4YQHR4ubHzGcbxnVXlY/oYbplIiGH0sYEC3n?=
 =?us-ascii?Q?9PZfk+8vDEntYxc93F+KMJ8peXs/tEdzSWBuoQLi0wZaIN9SbSA4N2Q/1iiC?=
 =?us-ascii?Q?2h76TcxjAxlhp6SgX04C/Df+HFtQGItAe9vZK/F0kqBeBl2KKNFU8b5wSnEI?=
 =?us-ascii?Q?0ncUGH4CBxa4py7WFX9GZBEIbSRpO07mwM/ZZOSAcyVxr0t4Bjvucs2Y6tdp?=
 =?us-ascii?Q?VA=3D=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-crypto@vger.kernel.org
List-Id: <linux-crypto.vger.kernel.org>
List-Subscribe: <mailto:linux-crypto+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-crypto+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: nxp.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: PAXPR04MB8301.eurprd04.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: e621d39b-c0c4-41e9-3a87-08dc27a51ba2
X-MS-Exchange-CrossTenant-originalarrivaltime: 07 Feb 2024 06:22:06.5853
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: lmsvcoR+xbJH1ORwpY0WyWiJ5ztjxQBUcCg1evgudeT0++VrId8t1ybcAx66I42RvX2RZoumEnKf1jgUsbUaHtFP0HeEFsAv0VRAjXHPgKM=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV1PR04MB9085

Hi Herbert,

What are your plans for this change?

Thanks,
Meenakshi

> -----Original Message-----
> From: Herbert Xu <herbert@gondor.apana.org.au>
> Sent: Thursday, July 6, 2023 3:28 AM
> To: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> Cc: Eric Biggers <ebiggers@kernel.org>; agk@redhat.com; snitzer@kernel.or=
g;
> linux-crypto@vger.kernel.org; dm-devel@redhat.com; linux-
> kernel@vger.kernel.org; qat-linux@intel.com; heinzm@redhat.com; Meenakshi
> Aggarwal <meenakshi.aggarwal@nxp.com>; Horia Geanta
> <horia.geanta@nxp.com>; Varun Sethi <V.Sethi@nxp.com>; Pankaj Gupta
> <pankaj.gupta@nxp.com>; Gaurav Jain <gaurav.jain@nxp.com>;
> davem@davemloft.net; Iuliana Prodan <iuliana.prodan@nxp.com>; Fiona Trahe
> <fiona.trahe@intel.com>
> Subject: Re: [PATCH 1/3] dm integrity: do not filter algos with
> CRYPTO_ALG_ALLOCATES_MEMORY
>
> On Wed, Jul 05, 2023 at 09:57:54PM +0100, Giovanni Cabiddu wrote:
> >
> > Then we are then back to square one. We need to check how many entries
> > are present in the scatterlists encrypted by crypt_journal() before
> > adjusting the meaning of !CRYPTO_ALG_ALLOCATES_MEMORY.
>
> Indeed.  I missed the fact that it was preallocating memory with GFP_KERN=
EL.
>
> So perhaps the answer is to adjust our API to allow the drivers to pre-al=
locate
> memory.  I'll look into this.
>
> Thanks,
> --
> Email: Herbert Xu <herbert@gondor.apana.org.au> Home Page:
> http://gondor.ap/
> ana.org.au%2F~herbert%2F&data=3D05%7C01%7Cmeenakshi.aggarwal%40nxp.co
> m%7C59d63c0b42d5423abb1108db7da2e431%7C686ea1d3bc2b4c6fa92cd99c5
> c301635%7C0%7C0%7C638241910806938399%7CUnknown%7CTWFpbGZsb3d8
> eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6Mn0%3D%
> 7C3000%7C%7C%7C&sdata=3DvdLCyhQOSTEhIK1%2FkAO7Z%2Fu6ejrLbRHwM88N
> DmsqaP0%3D&reserved=3D0
> PGP Key:
> http://gondor.ap/
> ana.org.au%2F~herbert%2Fpubkey.txt&data=3D05%7C01%7Cmeenakshi.aggarwal
> %40nxp.com%7C59d63c0b42d5423abb1108db7da2e431%7C686ea1d3bc2b4c6f
> a92cd99c5c301635%7C0%7C0%7C638241910806938399%7CUnknown%7CTWF
> pbGZsb3d8eyJWIjoiMC4wLjAwMDAiLCJQIjoiV2luMzIiLCJBTiI6Ik1haWwiLCJXVCI6
> Mn0%3D%7C3000%7C%7C%7C&sdata=3DeAkggsD8FaJzb9OO2p1bcaPYs8xt47Eav
> UdVVssGM7o%3D&reserved=3D0