Received: by 2002:a05:7412:1e0b:b0:fc:a2b0:25d7 with SMTP id kr11csp117898rdb; Wed, 14 Feb 2024 14:57:53 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCXMFJn3rrs/FadzpKCv796u3AyMipHujQes45T2EhNPi4CBYrwJX/BCs8a12y1Ntlm2e6C5MX5a3DSQc5k5A9FILNkEXN7JfMvwxd6r9Q== X-Google-Smtp-Source: AGHT+IEr0w08eVV69bBcm0UvnD5aBWHFdQrbn4A+nPFSKdLxWjOGLki7g61SUAfJpTiWMUr7vRSI X-Received: by 2002:aa7:df0c:0:b0:562:1a77:19a7 with SMTP id c12-20020aa7df0c000000b005621a7719a7mr1155edy.11.1707951473752; Wed, 14 Feb 2024 14:57:53 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1707951473; cv=pass; d=google.com; s=arc-20160816; b=W/gNiMCEPBBHaNwzLd2WH5t+OGdNmtUS7ApZPxsxCPBO2z9Yf8j+eZ59B1h+OHh9p3 8VLjvuAxY/YvNGx+49zKJ8xt1jB49xnysSRgWrJfok1rwQoI3PNST0QbvfrJDuUysvb5 3YZjOhg80tIicky2Ccdz7WmfDFzReNgBm7Ruz086oBmoqgFxqjx9NlAmKFKtzdsgRy83 wTG1alBbTPlhvn21Gsh+q3ROgF6LC1uH5znfiVEpAMpSs/IYDul4L63tfSXs/WgYcVaY g5jWmoNLNLgxpmrxQOqIZnVYzneo+gMTANxaYr2SaEjYH9HI0Ok6KcDd1fGeGl3dIjME f9fw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date:dkim-signature; bh=5+Qvi47L8XU94C+Z6IR2IHDPWZZEg9VIPZlTS1jigJ4=; fh=7L2OMMn8GIGLSnhl1GH7xAPQM1xMEB4OEUu+t2x8O+k=; b=YpRYh92Hte59GK9i6xY8+u327dXPBV5i4ubf4GNez2l8yabmd10Q7sM9ri8lmBwQ3y 4Kji9shc623mf6POcRvKU1f83VY6IWSp+zSzakPF1SDQoGm/rMUqFqK5EQgSq0ywiGwr MyTbUScXjOqJkQOJHb2SivgP88pIKINNkm51XVru07ut0fu8UI0PcV3XQHNlExj+tq1a Au/WNmVVDXC9yerwbwztDfBJr36cPGc9WgiPENXSWsEC4KmVRE7rxf97ouEnRVjylIua l2ZMweSaJ9uhWnvmq+FFNelBRZ1riBX2Wqs+TNxt1X98jO2V1Gqd3VwjnCjfMRBusPPv PHgw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DAwfMBdw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-crypto+bounces-2063-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-crypto+bounces-2063-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org X-Forwarded-Encrypted: i=2; AJvYcCUOVIVk1AbyXaPSK0VTnFk0TRkx0RPAzGZA2J1It0guotrom0HqYW0DRqUThN+YnAUiagjJG13HtqsCEJK+zHS4qV9nijBwiQ7PXmex7g== Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id a20-20020a05640213d400b00561cc26deaesi3066924edx.304.2024.02.14.14.57.53 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 14 Feb 2024 14:57:53 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto+bounces-2063-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=DAwfMBdw; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-crypto+bounces-2063-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-crypto+bounces-2063-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 3FEF31F22593 for ; Wed, 14 Feb 2024 22:56:45 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 394FB2E629; Wed, 14 Feb 2024 22:56:40 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="DAwfMBdw" X-Original-To: linux-crypto@vger.kernel.org Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id EBAA71DDD7 for ; Wed, 14 Feb 2024 22:56:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707951400; cv=none; b=GxQWamdenz6AmZOOlsePRTyL0MO9uXiqxh+X62Q/KrpebCwEyKkz8DR7vN9bDsnUytTb74Q2+V7xVeCfroNfoX5UVa34z/Mp9oS56NgBaW/rFOe4CGZhG2Ny+iybVWTFtuhHqrg9VAU+0wkd9g5axfWz0CAfyFYw7hxCOtXR4cw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1707951400; c=relaxed/simple; bh=dT3umuOkpXbN4uVvQqNXMbQjeiYWLCoVYkutJvXlNt0=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=aOSpEN/sTpZ+9ayYW2KvwUgSAu9XJ1CKv5+Jnbdm/fcsisgqBc58z/CSAKaoW2wrsOTpSTj54WaerF76xlnaZwBwO2DzoRsrYYIzGxx9nNCgxubG1mos7uezi6+aIzMpsJ3OnvhaQbXvmL2sLe4AyFYWEEwRM/bgVIBvJy9JPrE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=DAwfMBdw; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id A77AAC433F1; Wed, 14 Feb 2024 22:56:39 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1707951399; bh=dT3umuOkpXbN4uVvQqNXMbQjeiYWLCoVYkutJvXlNt0=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=DAwfMBdw90asazKyxUJ5Vr8F1katfbYJwjbpnrf0+poankbtcbuerzGAwswSWU9L/ 5IQ4jTk+Ctpml5QvXMBiiURwk2nONc3EvCTWfLHl3WErG+bMKbfe1y6RRBye81yTyj yStB5WXwO17mixrgfn/nHyEQ7cWvsppboh6e8WtXkPvQbvUDl2XYlbpcRzSLdQmhBc m/K/v0oOSTEvGVR+deqRPsI52kb3OBrzFjz+QFsQiy7pEWirExMWl6pYnIdTTykcyT P0N/toc1e3/lS3BtlPB3avjTnQdIKbetvDDF6gBFPb4mqKhcv9cFxAVs6OqyzjXhVH pyBCANg0JnNsQ== Date: Wed, 14 Feb 2024 14:56:38 -0800 From: Eric Biggers To: Herbert Xu Cc: Linux Crypto Mailing List Subject: Re: [PATCH 06/15] crypto: algif_skcipher - Disallow nonincremental algorithms Message-ID: <20240214225638.GB1638@sol.localdomain> References: Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Tue, Dec 05, 2023 at 02:13:26PM +0800, Herbert Xu wrote: > As algif_skcipher does not support nonincremental algorithms, check > for them and return ENOSYS Shouldn't they still be supported if the data is being read/written all at once? Also, ENOSYS isn't really an appropriate error code. ENOSYS normally means that the system call isn't supported at all. Maybe use EOPNOTSUPP? - Eric