Received-SPF: pass (google.com: domain of linux-crypto+bounces-2081-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
From: Alexey Romanov <avromanov@salutedevices.com>
To: Corentin Labbe <clabbe.montjoie@gmail.com>
CC: "neil.armstrong@linaro.org" <neil.armstrong@linaro.org>,
	"clabbe@baylibre.com" <clabbe@baylibre.com>, "herbert@gondor.apana.org.au"
	<herbert@gondor.apana.org.au>, "davem@davemloft.net" <davem@davemloft.net>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" <krzysztof.kozlowski+dt@linaro.org>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>, "khilman@baylibre.com"
	<khilman@baylibre.com>, "jbrunet@baylibre.com" <jbrunet@baylibre.com>,
	"martin.blumenstingl@googlemail.com" <martin.blumenstingl@googlemail.com>,
	"vadim.fedorenko@linux.dev" <vadim.fedorenko@linux.dev>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"linux-amlogic@lists.infradead.org" <linux-amlogic@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>, kernel <kernel@sberdevices.ru>
Subject: Re: [PATCH v4 00/20] Support more Amlogic SoC families in crypto
 driver
Thread-Topic: [PATCH v4 00/20] Support more Amlogic SoC families in crypto
 driver
Thread-Index: AQHaXbqRFptCyAwKyUyy1Cn5x5FmZLEHrLEAgANdAYA=
Date: Thu, 15 Feb 2024 10:43:09 +0000
Message-ID: <20240215104251.pcqj532ekhq5dfbt@cab-wsm-0029881.sigma.sbrf.ru>
References: <20240212135108.549755-1-avromanov@salutedevices.com>
 <ZcsYaPIUrBSg8iXu@Red>
In-Reply-To: <ZcsYaPIUrBSg8iXu@Red>
Accept-Language: ru-RU, en-US
Content-Language: en-US
Content-Type: text/plain; charset="us-ascii"
Content-ID: <1F71700A325F53478901685FB02CFC10@sberdevices.ru>
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
MIME-Version: 1.0

Hello,

On Tue, Feb 13, 2024 at 08:21:12AM +0100, Corentin Labbe wrote:
> Le Mon, Feb 12, 2024 at 04:50:48PM +0300, Alexey Romanov a 'ecrit :
> > Hello!
> >=20
> > This patchset expand the funcionality of the Amlogic
> > crypto driver by adding support for more SoC families:
> > AXG, G12A, G12B, SM1, A1, S4.
> >=20
> > Also specify and enable crypto node in device tree
> > for reference Amlogic devices.
> >=20
> > Tested on AXG, G12A/B, SM1, A1 and S4 devices via
> > custom tests [1] and tcrypt module.
> >=20
> > ---
> >=20
>=20
> I started to test on Lepotato board and added patchs up to  "drivers: cry=
pto: meson: process more than MAXDESCS descriptors"
> booting lead to:

Can you please give me your test cases?
Which tool are you using or is it something custom?

> [   18.559922] gxl-crypto c883e000.crypto: will run requests pump with re=
altime priority
> [   18.562492] gxl-crypto c883e000.crypto: will run requests pump with re=
altime priority
> [   18.570328] Unable to handle kernel NULL pointer dereference at virtua=
l address 0000000000000028
> [   18.581135] Mem abort info:
> [   18.581354]   ESR =3D 0x0000000096000006
> [   18.585138]   EC =3D 0x25: DABT (current EL), IL =3D 32 bits
> [   18.593005]   SET =3D 0, FnV =3D 0
> [   18.593334]   EA =3D 0, S1PTW =3D 0
> [   18.597329]   FSC =3D 0x06: level 2 translation fault
> [   18.604250] Data abort info:
> [   18.604282]   ISV =3D 0, ISS =3D 0x00000006, ISS2 =3D 0x00000000
> [   18.612243]   CM =3D 0, WnR =3D 0, TnD =3D 0, TagAccess =3D 0
> [   18.614552]   GCS =3D 0, Overlay =3D 0, DirtyBit =3D 0, Xs =3D 0
> [   18.624249] user pgtable: 4k pages, 48-bit VAs, pgdp=3D000000007b8ab00=
0
> [   18.626196] [0000000000000028] pgd=3D080000007b8ac003, p4d=3D080000007=
b8ac003, pud=3D080000007b8ad003, pmd=3D0000000000000000
> [   18.640426] Internal error: Oops: 0000000096000006 [#1] PREEMPT SMP
> [   18.642929] Modules linked in: of_mdio fixed_phy fwnode_mdio sm4_ce(-)=
 sm4 meson_rng meson_canvas libphy rng_core meson_gxbb_wdt watchdog amlogic=
_gxl_crypto(+) ghash_generic gcm xctr xts cts essiv authenc cmac xcbc ccm
> [   18.662164] CPU: 3 PID: 264 Comm: cryptomgr_test Not tainted 6.8.0-rc1=
-00052-gf70f2b0814a0 #11
> [   18.670698] Hardware name: Libre Computer AML-S905X-CC (DT)
> [   18.676220] pstate: 60000005 (nZCv daif -PAN -UAO -TCO -DIT -SSBS BTYP=
E=3D--)
> [   18.683118] pc : meson_get_engine_number+0x2c/0x50 [amlogic_gxl_crypto=
]
> [   18.689674] lr : meson_skencrypt+0x38/0x8c [amlogic_gxl_crypto]
> [   18.695539] sp : ffff800081393790
> [   18.698816] x29: ffff800081393790 x28: 0000000000000400 x27: ffff80008=
0874a80
> [   18.705888] x26: ffff800081393830 x25: ffff800081393bd8 x24: ffff00000=
1aaa000
> [   18.712961] x23: 0000000000000001 x22: 0000000000000000 x21: ffff00000=
11b1c50
> [   18.720033] x20: ffff00007bac8248 x19: ffff0000011b1c00 x18: fffffffff=
fffffff
> [   18.727105] x17: 00000000000001a4 x16: ffff800078edc1f0 x15: ffff80008=
13938e0
> [   18.734178] x14: ffff800101393bd7 x13: 0000000000000000 x12: 000000000=
0000000
> [   18.741250] x11: 000000000000021c x10: fffffffff81213e0 x9 : 000000000=
00730d5
> [   18.748323] x8 : ffff0000011b1ca8 x7 : fefefefefefefefe x6 : fffffc000=
007a302
> [   18.755395] x5 : ffff800078eb4148 x4 : 0000000000000000 x3 : 000000000=
0000028
> [   18.762468] x2 : ffff000001aaa040 x1 : 0000000000000000 x0 : 000000000=
0000000
> [   18.769541] Call trace:
> [   18.771956]  meson_get_engine_number+0x2c/0x50 [amlogic_gxl_crypto]
> [   18.778167]  crypto_skcipher_encrypt+0xe0/0x124
> [   18.782651]  test_skcipher_vec_cfg+0x2a8/0x6b0
> [   18.787050]  test_skcipher_vec+0x80/0x1c4
> [   18.791017]  alg_test_skcipher+0xbc/0x1fc
> [   18.794985]  alg_test+0x140/0x628
> [   18.798262]  cryptomgr_test+0x24/0x44
> [   18.801885]  kthread+0x110/0x114
> [   18.805076]  ret_from_fork+0x10/0x20
> [   18.808617] Code: 1b008440 d65f03c0 9100a003 f9800071 (885f7c61)=20
> [   18.814651] ---[ end trace 0000000000000000 ]---
> [   18.862270] meson8b-dwmac c9410000.ethernet: IRQ eth_wake_irq not foun=
d
> [   18.863897] meson8b-dwmac c9410000.ethernet: IRQ eth_lpi not found
> [   18.870349] meson8b-dwmac c9410000.ethernet: PTP uses main clock
> [   18.880548] meson8b-dwmac c9410000.ethernet: User ID: 0x11, Synopsys I=
D: 0x37
> [   18.882403] meson8b-dwmac c9410000.ethernet: 	DWMAC1000
> [   18.887926] meson8b-dwmac c9410000.ethernet: DMA HW capability registe=
r supported
> [   18.895215] meson8b-dwmac c9410000.ethernet: RX Checksum Offload Engin=
e supported
> [   18.902627] meson8b-dwmac c9410000.ethernet: COE Type 2
> [   18.907756] meson8b-dwmac c9410000.ethernet: TX Checksum insertion sup=
ported
> [   18.914750] meson8b-dwmac c9410000.ethernet: Wake-Up On Lan supported
> [   18.921246] meson8b-dwmac c9410000.ethernet: Normal descriptors
> [   18.927017] meson8b-dwmac c9410000.ethernet: Ring mode enabled
> [   18.932782] meson8b-dwmac c9410000.ethernet: Enable RX Mitigation via =
HW Watchdog Timer

--=20
Thank you,
Alexey=