Received-SPF: pass (google.com: domain of linux-crypto+bounces-2123-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Date: Fri, 16 Feb 2024 17:22:53 +0000
From: "Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
CC: Damian Muszynski <damian.muszynski@intel.com>, Herbert Xu
	<herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>,
	"Lucas Segarra Fernandez" <lucas.segarra.fernandez@intel.com>, Tero Kristo
	<tero.kristo@linux.intel.com>, Markas Rapoportas
	<markas.rapoportas@intel.com>, <qat-linux@intel.com>,
	<linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	<kernel-janitors@vger.kernel.org>
Subject: Re: [PATCH] crypto: qat - uninitialized variable in
 adf_hb_error_inject_write()
Message-ID: <Zc+Z7RBFNLcnzNOL@gcabiddu-mobl.ger.corp.intel.com>
References: <193d36b0-961a-4b66-b945-37988f157ebe@moroto.mountain>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <193d36b0-961a-4b66-b945-37988f157ebe@moroto.mountain>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?9gTWU24g7MmRP8ItqMWA4eKk1tbhxlKUNV+X/tuvLBNkQg/sUM6LA7C6vUam?=
 =?us-ascii?Q?H6h89qgeToOtNtzpKuntyJBscQJCjItzwiq4ie44f74jp0wl17EvA6gqTdPP?=
 =?us-ascii?Q?c/w8ClQprghSW86jgxm07WEcwpiAUcm+RcGWMt/hKGhHQJwHVqE/ofNeKhGt?=
 =?us-ascii?Q?1EtGnYPv/JuBB4jya3oyvzd4Ok0LAQP0rEoVz71+6tOZrM3tmcxtZCCbIF3m?=
 =?us-ascii?Q?kU/FcGPvLSZmpxaDF3wRJ7Pa/Ulb37mLlpb4zEGLmqMGxWzr0w9PXJ+J+KSl?=
 =?us-ascii?Q?uUfr3p4SYOx96KBhWxdDksEbJ+FeulZAIwV41Gm9ALNCtws5uVNiIuxNo+aQ?=
 =?us-ascii?Q?2oYaKI4T+lEZ5tlsapbKYnIjrirr1pSbAX6OgfVD5L4b8GCCqm8h5HJ3erN9?=
 =?us-ascii?Q?cl7cSXsH86y1e+603lNw2cYqDdrsb0qweoquLE/8FzshO6geSjdixkVADpl+?=
 =?us-ascii?Q?vrRZ2jO/c55SV4JBRQFkM+cjCD9USKu6/57zbKWvhtaeQNr9KvPf38chJWse?=
 =?us-ascii?Q?jNK8P1QzRPJ7gle3Idx1UoCEdf2uWXU/iRfwvxBeVc4620JBiBfbz4ukkXFv?=
 =?us-ascii?Q?zotnYJSpIgKIZGfC5rz2ji/PAf8qs+WUAmhJHVBpz/3JRF3RBssjjr9g0Bsh?=
 =?us-ascii?Q?caiwaMQ1Em1HZgO6iZE6PvgTlyABsZMVQnOrqyWEiahreT7mFRpnyUKeFYK2?=
 =?us-ascii?Q?Iu4LpcT59T83uJ5mtUYsPVzkPZLikTAaw1Leip9DNOrVfGm2T4u+emi1eAPc?=
 =?us-ascii?Q?Gh6BderZ5LTHMzcx5MFY8yq76HhlEntKwSRv4TZ08wKunGFmGM2bmTOXbsy+?=
 =?us-ascii?Q?+oFmJDjdOqnqf0rcXpLj0KkhwXt3Tcbwc3HXu/EJjxKI65qkq386/bsnQh2V?=
 =?us-ascii?Q?P7xSiPgdq8jUkrdcIqQ3nWrDR/J1OUkTQLI7kscu7LjGOe5Xkjsn+Q9myEQI?=
 =?us-ascii?Q?t2NUUqDnIpUF7D7FN2JniDjBD5QTi6usNIfxW+RoxnNHhiLBSXsuwLbttI7Z?=
 =?us-ascii?Q?zMbSZx/kqVaCA/hDcY4S3EepE3AscfowE2urHzgvMstOZcmtOlyXTpaB437h?=
 =?us-ascii?Q?4eWIq4ZPFsPHQNxyVORxrx74L0XJsmHmdLTps0hLTuHtlpXwLhkyoXPzsDob?=
 =?us-ascii?Q?TB1Fivjkvle+DohAmBT9fC9FtbWzS1E5LBX9KVTdXDdCK4MCVpXhnI+ysBlj?=
 =?us-ascii?Q?7U2kY04CfV2uGf663MFTSHQPnvXXZiMnRYggauuT8pWau/yihFlLYxz+TSqi?=
 =?us-ascii?Q?lFwjUs/c2Q7mZ0roZ/0jP6x3vsFZqsxCjKa70C/3uSq2gwEUxaOhz1OwPt0b?=
 =?us-ascii?Q?dUWjwIhNY9DaeqOIsgqTCQFEfc8Co2pxcUDAp0A9IX0iFZo8apouJsiVe8Gb?=
 =?us-ascii?Q?xnxvHoQu1lm4+8nKLNXhPmch3LknPLMPW16aKWzg1nI3n7lGS+Ez0Q2NwJZD?=
 =?us-ascii?Q?eEIN6PM7hKZbrbUgrm3VZloc/DUTiIFu3EFcXOEJPVjbB36lRkGaXX8/aeop?=
 =?us-ascii?Q?lQ9rpFbLPE78S7UmUlf7AE6iHF97g1a3gUIQRG+KPoIkdpt45ydz4eP6L5Rk?=
 =?us-ascii?Q?ODZnRV/Kre6Dugz3ibnZEu2GTvpOYfzVocWk+zkrKl+xjSmA39jDn5Yj9Hju?=
 =?us-ascii?Q?yw=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c4fdf1b0-52c5-463f-d7ea-08dc2f13edde
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 16 Feb 2024 17:23:02.2834
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: Yr4A4PUSJwvI7jwstVXBR4BhpZIGppqp9weXFZjYAQ6EMTDUWdlJFhceAKcCfit7DBxuSdAU9idRG2IBv9Wy7BPFFjmYc1m1hBxLxYp5PKs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SA2PR11MB5004
X-OriginatorOrg: intel.com

On Tue, Feb 13, 2024 at 09:09:41PM +0300, Dan Carpenter wrote:
> There are a few issues in this code.  If *ppos is non-zero then the
> first part of the buffer is not initialized.  We never initialize the
> last character of the buffer.  The return is not checked so it's
> possible that none of the buffer is initialized.
Thanks Dan.
> 
> This is debugfs code which is root only and the impact of these bugs is
> very small.  However, it's still worth fixing.  To fix this:
> 1) Check that *ppos is zero.
> 2) Use copy_from_user() instead of simple_write_to_buffer().
> 3) Explicitly add a NUL terminator.
> 
> Fixes: e2b67859ab6e ("crypto: qat - add heartbeat error simulator")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
>  .../crypto/intel/qat/qat_common/adf_heartbeat_dbgfs.c | 11 ++++++-----
>  1 file changed, 6 insertions(+), 5 deletions(-)
> 
> diff --git a/drivers/crypto/intel/qat/qat_common/adf_heartbeat_dbgfs.c b/drivers/crypto/intel/qat/qat_common/adf_heartbeat_dbgfs.c
> index 5cd6c2d6f90a..cccdff24b48d 100644
> --- a/drivers/crypto/intel/qat/qat_common/adf_heartbeat_dbgfs.c
> +++ b/drivers/crypto/intel/qat/qat_common/adf_heartbeat_dbgfs.c
> @@ -160,16 +160,17 @@ static ssize_t adf_hb_error_inject_write(struct file *file,
>  					 size_t count, loff_t *ppos)
>  {
>  	struct adf_accel_dev *accel_dev = file->private_data;
> -	size_t written_chars;
>  	char buf[3];
>  	int ret;
>  
>  	/* last byte left as string termination */
> -	if (count != 2)
> +	if (*ppos != 0 || count != 2)
Is this alone not sufficient to fix the problem? Probably I'm missing
something.
The function just checks the first character in buf.

Anyway, looks correct to me.
Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>

Regards,

-- 
Giovanni