Received-SPF: pass (google.com: domain of linux-crypto+bounces-2158-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
From: "Wan, Siming" <siming.wan@intel.com>
To: Kamlesh Gurudasani <kamlesh@ti.com>, "Zeng, Xin" <xin.zeng@intel.com>,
	"herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
	"alex.williamson@redhat.com" <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>, "yishaih@nvidia.com" <yishaih@nvidia.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "Tian, Kevin" <kevin.tian@intel.com>
CC: "linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, qat-linux <qat-linux@intel.com>,
	"Zeng, Xin" <xin.zeng@intel.com>
Subject: RE: [EXTERNAL] [PATCH 07/10] crypto: qat - add bank save and restore
 flows
Thread-Topic: [EXTERNAL] [PATCH 07/10] crypto: qat - add bank save and restore
 flows
Thread-Index: AQHaVSVB/m38AurFzkKxVGnzjrvP0LD50xgAgBdMZaA=
Date: Mon, 19 Feb 2024 03:41:04 +0000
Message-ID: <DM8PR11MB56875F986E6BC02D408CB4708E512@DM8PR11MB5687.namprd11.prod.outlook.com>
References: <20240201153337.4033490-1-xin.zeng@intel.com>
 <20240201153337.4033490-8-xin.zeng@intel.com>
 <87o7cwzn1t.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me>
In-Reply-To: <87o7cwzn1t.fsf@kamlesh.i-did-not-set--mail-host-address--so-tickle-me>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?2H+p/KCSA5or/q3emjRq20LU+NYQDDDk6WBEiZB4e3dfC14ODdmW8wPMFyja?=
 =?us-ascii?Q?B2rsYrf9z92+A87iQM5Dg4uaiFff9xZwpr33Neav/hZWXvaDgANdMNTcxvSz?=
 =?us-ascii?Q?P4hAJEz0Nnp25cvB1qDYAUIsKq1vTZeWk1HNKumzEwY6FA0YFHwUjIFdGicw?=
 =?us-ascii?Q?v/0qUS6/stRSnd0osh4nltfifPmz2lUsNJ5HWvPp5LBY5cPI1JEWJjdchqC5?=
 =?us-ascii?Q?1XRDo4xq62hTAdsApXPuns6yaq35MLw0eWaOcF19NxmnQgus+9/F0UMNmS0F?=
 =?us-ascii?Q?tk85Uya/h3KqnB40i7ZgcNTPmBsXVEkh2Tq3uIoewNSZwWX2TQOATgsPg5/C?=
 =?us-ascii?Q?i5Hgkh4hZiUt6gMyTBWQfpc5WzQAwjsmf1EQVSjtX0EgIzimwF/ltHWx4a3G?=
 =?us-ascii?Q?I9k4LtOM/TzJ1T4cD8q7GpPqBDLv3PvYeTXbGR5k5KuN5/lSnCfiIDXsNhEd?=
 =?us-ascii?Q?rTgRadIqME5hrz+osrtk4dkwaUH2FyYN1cOK52PJgFzOUJCbYj3TzlAi2+Vd?=
 =?us-ascii?Q?7wCG/lF7tr4NM79FmXyeOJsA00zj2BM+HKQTwP4xIER5D5HCMMR7tteDU8Mj?=
 =?us-ascii?Q?EXhvRXEGVgUpwEG1zEuOAIpygZHeqpFw1QffSa6QBlbxbB2wK4O7lE+0fNTY?=
 =?us-ascii?Q?V76LanP3e+K7ay/P8KF4Dwym4jb8qNkEBqfd1tFARNqQS9IWKwkJs1sMYG3+?=
 =?us-ascii?Q?PJ5UeafHur052ZX+LPjPxMjIGwgpaq+7mGy4T3E2nFFQ5QR+aDk+ojUZBUHQ?=
 =?us-ascii?Q?jLjtWef0DjxmW8HKxvinvaQsFJm4x+SQxTwNKcdrVeVIxfRmTFn4TNbOcSuY?=
 =?us-ascii?Q?RfitBr8RcTfmfthqKJdk7AeJbsEFdor0BFz3rDdip1GcCtSGyS7kGate5PLe?=
 =?us-ascii?Q?8sirut8K3o4eMJRd0mvuH/yKX7dpoJavXHBuWobYwSj0+Bwzz56ID9FsT/2w?=
 =?us-ascii?Q?awej4r8uckPwNqqeHPxqsz1wD7QDw/nZfbD6b2MGBnEm9q6awFW6e8wqTWks?=
 =?us-ascii?Q?mhDaYuQqdm48YfpBT7oifEequdKngCp0m7jKucFEqXBT4W2//jj73Wn3UF4a?=
 =?us-ascii?Q?Q4enE7+82m3+NgYfcUO85pwtDivfbTyVxrqDVo78tnfiu9Qo6kZ0RNtOnj+R?=
 =?us-ascii?Q?kB0mun1/UOF32exEfCLchsOz7xbVfF2tacMDtoc85lpvCz8eh2RMrOwQe4/b?=
 =?us-ascii?Q?p6eWPVBiei57NgI4j4p0Pb1GtsIkNDfjYz+UMrzPQYiJbSOQa9chO+71Iybu?=
 =?us-ascii?Q?84LyBzrvi4KVoWbs+QpFso7dQJl+Q3b0DBxvSPgwDatZTXIk+nea1uXlD1B2?=
 =?us-ascii?Q?Fd/R5qvQiao5+t2tfvB2uFBlIA0msWfqOPAqB6N/LsR9958y4dBLyiwrd6Tv?=
 =?us-ascii?Q?q/1yMCpnPf9Ve1ovY8hEkWfwKA+ptfTCrE5JNP3+xPf+JRGD7zYv/tVmG2oZ?=
 =?us-ascii?Q?/MhCQDqVL7+CSQiBJ0C2eWSBtUcTgYWZjWJEpIOmOQB7JdJZL1zM2P2G4v+F?=
 =?us-ascii?Q?6Xvi1RMzw1OZ9/sa7Bu1H8TKtp5+r4Dc5b6Jbqn5flPMDXQi+e75LdwVrL7h?=
 =?us-ascii?Q?NJTCmiVDZbrMQW5TRGY9wGfg9K/5qcFUF3uJ5D07?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-crypto@vger.kernel.org
List-Id: <linux-crypto.vger.kernel.org>
List-Subscribe: <mailto:linux-crypto+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-crypto+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM8PR11MB5687.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 68c42700-edec-43d4-a333-08dc30fc9982
X-MS-Exchange-CrossTenant-originalarrivaltime: 19 Feb 2024 03:41:04.4802
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 6ILrHAIOqiL7jHnmCg1YZvokdlgZ00up5pZxzrbLyIwAnsfx0/79OT/qBg9S80wxA/dAAc/D9PgvtdsKrjCEJg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MW4PR11MB6983
X-OriginatorOrg: intel.com

From: Kamlesh Gurudasani <kamlesh@ti.com>=20
Sent: Sunday, February 4, 2024 3:50 PM
To: Zeng, Xin <xin.zeng@intel.com>; herbert@gondor.apana.org.au; alex.willi=
amson@redhat.com; jgg@nvidia.com; yishaih@nvidia.com; shameerali.kolothum.t=
hodi@huawei.com; Tian, Kevin <kevin.tian@intel.com>
Cc: linux-crypto@vger.kernel.org; kvm@vger.kernel.org; qat-linux <qat-linux=
@intel.com>; Wan, Siming <siming.wan@intel.com>; Zeng, Xin <xin.zeng@intel.=
com>
Subject: Re: [EXTERNAL] [PATCH 07/10] crypto: qat - add bank save and resto=
re flows

Xin Zeng <xin.zeng@intel.com> writes:

> This message was sent from outside of Texas Instruments.=20
> Do not click links or open attachments unless you recognize the source of=
 this email and know the content is safe.=20
> =20
> From: Siming Wan <siming.wan@intel.com>
>
> Add logic to save, restore, quiesce and drain a ring bank for QAT GEN4=20
> devices.
> This allows to save and restore the state of a Virtual Function (VF)=20
> and will be used to implement VM live migration.
>
> Signed-off-by: Siming Wan <siming.wan@intel.com>
> Reviewed-by: Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> Reviewed-by: Xin Zeng <xin.zeng@intel.com>
> Signed-off-by: Xin Zeng <xin.zeng@intel.com>
...
> +#define CHECK_STAT(op, expect_val, name, args...) \ ({ \
> +	u32 __expect_val =3D (expect_val); \
> +	u32 actual_val =3D op(args); \
> +	if (__expect_val !=3D actual_val) \
> +		pr_err("QAT: Fail to restore %s register. Expected 0x%x, but actual is=
 0x%x\n", \
> +			name, __expect_val, actual_val); \
> +	(__expect_val =3D=3D actual_val) ? 0 : -EINVAL; \
I was wondering if this can be done like following, saves repeat comparison=
.

(__expect_val =3D=3D actual_val) ? 0 : (pr_err("QAT: Fail to restore %s \
                                          register. Expected 0x%x, \
                                          but actual is 0x%x\n", \
                 			  name, __expect_val, \
                                          actual_val), -EINVAL); \ Regards,=
 Kamlesh

> +})
...


Thanks for your comments! Will update.