Received-SPF: pass (google.com: domain of linux-crypto+bounces-2202-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161;
From: "Zeng, Xin" <xin.zeng@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
CC: Yishai Hadas <yishaih@nvidia.com>, "herbert@gondor.apana.org.au"
	<herbert@gondor.apana.org.au>, "alex.williamson@redhat.com"
	<alex.williamson@redhat.com>, "shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "Tian, Kevin" <kevin.tian@intel.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, qat-linux <qat-linux@intel.com>,
	"Cao, Yahui" <yahui.cao@intel.com>
Subject: RE: [PATCH 10/10] vfio/qat: Add vfio_pci driver for Intel QAT VF
 devices
Thread-Topic: [PATCH 10/10] vfio/qat: Add vfio_pci driver for Intel QAT VF
 devices
Thread-Index: AQHaVSVFJ9K0TVMQD0C9btTtb+JmirD9TRgAgAQ3vqCAAHLkgIAC42sAgAhyjxCABghogIAADukQ
Date: Tue, 20 Feb 2024 15:53:08 +0000
Message-ID: <DM4PR11MB5502BE3CC8BD098584F31E8D88502@DM4PR11MB5502.namprd11.prod.outlook.com>
References: <20240201153337.4033490-1-xin.zeng@intel.com>
 <20240201153337.4033490-11-xin.zeng@intel.com>
 <20240206125500.GC10476@nvidia.com>
 <DM4PR11MB550222F7A5454DF9DBEE7FEC884B2@DM4PR11MB5502.namprd11.prod.outlook.com>
 <20240209121045.GP10476@nvidia.com>
 <e740d9ec-6783-4777-b984-98262566974c@nvidia.com>
 <DM4PR11MB550274B713F6AE416CDF7FDB88532@DM4PR11MB5502.namprd11.prod.outlook.com>
 <20240220132459.GM13330@nvidia.com>
In-Reply-To: <20240220132459.GM13330@nvidia.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?atYyu+u3DWVdLj8cFrmvpPECYmxP0Ylfm2HJqUBs8ShAbIhneaJrLVBgWk04?=
 =?us-ascii?Q?S3YdlxeWDSiMjmbXT2SXfR2gx2suMEpZ2Aj6E1km3T3iefsI1DaAHZuzoXey?=
 =?us-ascii?Q?76hP3iZDGMK72puX+rWAsNYOh5EvmtoRixO5GB9dmif/b1aaScwRqBGQG4af?=
 =?us-ascii?Q?So83O0QNg3jge77eq5/cQ6Iqvz4AAKjc8uHjUqdkQukvFzpnFyIVVZwB7pNu?=
 =?us-ascii?Q?pneTkFkSUmqTJylqEiy+tjegxnNknlOEUbsxehnmAdy1RCUS7SqjXqlwtjDI?=
 =?us-ascii?Q?LC+bi1YbZRrIoHhRpNnEK0G+OmKUv/yDcQyjWGX1wJZOsGNCSB2vhVWbPcj6?=
 =?us-ascii?Q?ygw3Yl5S+Zg4qPVOcY0Ag17ZX906hCvOs/sd+p8bpL7cFtqayxJId43fBODc?=
 =?us-ascii?Q?M+Su8TrDDeQtK38agF45PK5+FhUaXlon32tLA4iW5J5VpX0vEHJYnERjnLoV?=
 =?us-ascii?Q?tfHNMjbpMVcSec50Mbi7uXJvQjyV8ibvCPrfZCXY9SZX8G4kny1tb1EetOz6?=
 =?us-ascii?Q?Y1Lqh7ZO3+uAsjtmnbl0Vj9f4iu7MgXYloKi/sBaW6F+4Jbz+U0YRbr5Y1d8?=
 =?us-ascii?Q?q6hi2H0gFRJpJwU+Tvir2nAhutWMWO/BbTn48kjeQnAR2LqWJmW6WTOi25NL?=
 =?us-ascii?Q?TQNxeqpVrlmhh1rh3JERnpIn9HEMDzA+R/OPlIDR3sboEEnnzGN88rKWxQ/p?=
 =?us-ascii?Q?P/VDD0Q0iqoKhxcZoFZckoiiQ4BnSlfjJ74EmnYZt2TdN4UPHa48V/djnYTx?=
 =?us-ascii?Q?Enh67oTehVwu0QWILJwGjEnHI9tZs76f/a8C/ru0aUd9YkH2Wh8/AiAQuKP1?=
 =?us-ascii?Q?NVTr/YjBATHv802Y6bIKVOhBkghQICWh5Z17F1IrqwP8Y8LFVMdZVwHi+/qH?=
 =?us-ascii?Q?gH5vzHCCO6ESMKXF/HuVppDcsMV4gQp6hd2KiRCmpI46vHzC8VDwvfIzK84b?=
 =?us-ascii?Q?6YcrVpqLesOhX44n32bfY2L7ZV+VYFTWG+vNfe2Pwy607hYyu9byLUB0LLl3?=
 =?us-ascii?Q?W8Hz8oYSfffbEb3vrs5yuxMI6NDN2VrPbYyUAXhspnUHz2jEfb9TCy/TzLko?=
 =?us-ascii?Q?ZHT03NiGlIJvUl1GVKR9Cnf/ICrET7dXK8Pyq1MgKzn2jYU67IoZeyvhJ+fG?=
 =?us-ascii?Q?jsNcxhKnDjNenHxy4QQdn4+2DWf2HFgCPkI9k12zJlvA1+9Zw1RoKMIi37rS?=
 =?us-ascii?Q?qWc3yOxpRDJjp6uuxapgqeyntO38++bMP5K7NALLOM0wvTUBfL4970ugynE8?=
 =?us-ascii?Q?GWTDT7LK2T+UAYU+xzagcYSF0m/6SbpmGBLeEvSeXAgoS6Ei+kMG6u9FlZTO?=
 =?us-ascii?Q?ta37Y0uq4d6KZc9YLbiAGG4ktVGBQez2FMKziXXoXyUrWDyU2ic8MlA1RLLI?=
 =?us-ascii?Q?zUtzI7+EP2GBCcvma9XknEFQMf17a3toGacLfapmsg7Uri/EurVOqDLexCym?=
 =?us-ascii?Q?mwaJPVKSdQmt3UrJfxkITW/+p1WUWoN6EGe5cxlMU+dkYZU1Dv8EimyDNq3Y?=
 =?us-ascii?Q?VF5FPvjNWaQOUOa5NM0qnx13vfsm0Z38pcIlzKyAqkiJ8r4BHe4KnBRlxUHP?=
 =?us-ascii?Q?53wCC0KEo21xzUoLL+26YNJ97aRc/Ro+xyuMTNVc?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-crypto@vger.kernel.org
List-Id: <linux-crypto.vger.kernel.org>
List-Subscribe: <mailto:linux-crypto+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-crypto+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5502.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 389ad2e2-7810-4d94-98cf-08dc322c08c0
X-MS-Exchange-CrossTenant-originalarrivaltime: 20 Feb 2024 15:53:08.6304
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: 3GpU+nmhAaHFion+8pjcG7nbXv+NEevwd8QIGNzVpSlv4V26C+geUpyEU8w2FlSTrZmXAHrxZRQwgro/8HfsCg==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ2PR11MB7453
X-OriginatorOrg: intel.com

On Tuesday, February 20, 2024 9:25 PM, Jason Gunthorpe wrote:
> To: Zeng, Xin <xin.zeng@intel.com>
> Cc: Yishai Hadas <yishaih@nvidia.com>; herbert@gondor.apana.org.au;
> alex.williamson@redhat.com; shameerali.kolothum.thodi@huawei.com; Tian,
> Kevin <kevin.tian@intel.com>; linux-crypto@vger.kernel.org;
> kvm@vger.kernel.org; qat-linux <qat-linux@intel.com>; Cao, Yahui
> <yahui.cao@intel.com>
> Subject: Re: [PATCH 10/10] vfio/qat: Add vfio_pci driver for Intel QAT VF=
 devices
>=20
> On Sat, Feb 17, 2024 at 04:20:20PM +0000, Zeng, Xin wrote:
>=20
> > Thanks for this information, but this flow is not clear to me why it
> > cause deadlock. From this flow, CPU0 is not waiting for any resource
> > held by CPU1, so after CPU0 releases mmap_lock, CPU1 can continue
> > to run. Am I missing something?
>=20
> At some point it was calling copy_to_user() under the state
> mutex. These days it doesn't.
>=20
> copy_to_user() would nest the mm_lock under the state mutex which is a
> locking inversion.
>=20
> So I wonder if we still have this problem now that the copy_to_user()
> is not under the mutex?

In protocol v2, we still have the scenario in precopy_ioctl where copy_to_u=
ser is
called under state_mutex.

Thanks,
Xin