Received-SPF: pass (google.com: domain of linux-crypto+bounces-2239-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Message-ID: <d250f64a-dd4b-44ca-8fb9-464bbd812c54@oracle.com>
Date: Wed, 21 Feb 2024 18:10:43 -0800
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v8 04/15] x86: Secure Launch Resource Table header file
Content-Language: en-US
To: Andrew Cooper <andrew.cooper3@citrix.com>,
        Ard Biesheuvel <ardb@kernel.org>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org,
        linux-integrity@vger.kernel.org, linux-doc@vger.kernel.org,
        linux-crypto@vger.kernel.org, kexec@lists.infradead.org,
        linux-efi@vger.kernel.org, dpsmith@apertussolutions.com,
        tglx@linutronix.de, mingo@redhat.com, bp@alien8.de, hpa@zytor.com,
        dave.hansen@linux.intel.com, mjg59@srcf.ucam.org,
        James.Bottomley@hansenpartnership.com, peterhuewe@gmx.de,
        jarkko@kernel.org, jgg@ziepe.ca, luto@amacapital.net,
        nivedita@alum.mit.edu, herbert@gondor.apana.org.au,
        davem@davemloft.net, kanth.ghatraju@oracle.com,
        trenchboot-devel@googlegroups.com
References: <20240214221847.2066632-1-ross.philipson@oracle.com>
 <20240214221847.2066632-5-ross.philipson@oracle.com>
 <CAMj1kXGaMfUAR85jpeS2JxcmWBbpkzroCVZOtwa3WDQwStDjMw@mail.gmail.com>
 <08ac69b4-4d12-4454-aa16-40db7e54816f@citrix.com>
From: ross.philipson@oracle.com
In-Reply-To: <08ac69b4-4d12-4454-aa16-40db7e54816f@citrix.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: 
	=?utf-8?B?TExWc1ltNUVWNjlEWDJycHV4dGpEc1AxVXN6UnVEbnBIOTNMeTllMDZpWmFK?=
 =?utf-8?B?YTFvZ2tKTStlT3M1ZlNKNlNoMUFpRFNIcFpNTnVjNVVJWk44Ni90L3BkL1dt?=
 =?utf-8?B?V2xMdFFZQUkrYURqcFB3T3loczQ3aVdlbGJTeW05a1ludWR5VjJ1ckIwUDRV?=
 =?utf-8?B?bkhEeXFld3kyczFIL0RGL3ArZEx2Z2dyYk45WHFiSzBsdmtCZ1pick1BczhY?=
 =?utf-8?B?cVZ3MHFJcmlwMlNFWHJvM2FXeHFqUkhaQ1BxMUplazJ3dFQ1VFRzQTRUQ3RG?=
 =?utf-8?B?TWFHYVE5NWx4SGpCWWJ3S2kyZVYrSHlPY2tacklQRWFTc21ZU01ybDliUW9p?=
 =?utf-8?B?S2ZqRFgyT09XekZHSXExaG5YQS9VVGxUek5Ca0hjL1Z4RCtWeGdnY0tia1Ey?=
 =?utf-8?B?Qmdlb3lGSGFHUDNYZmx0R0pXc01pajAwMzZWaU4xZ2paNmw3d2ZlcVpudWpx?=
 =?utf-8?B?VDJwbFJ4cTVIS1JYN1BDN0NySWJ5YUxuTDhWSWF5RnFvZkYvb1JOc3p6OWtp?=
 =?utf-8?B?MEhNWTBOeTN1MWVRc1ZhV3IwVDZ0dmYxREMzQk5YejExUzhFZW9TM3plTnk5?=
 =?utf-8?B?UXBHdWRUOFRsUlBaWFYySUw1S2lkN1J4endTcXVLeE8yOXRZTXowV1QyTlIr?=
 =?utf-8?B?RzBMdDMzTkQ3eXFxVk4yUDFRcUFmbDBEVUdlQXZuN1ZlNUNJNlB6QmwrOWFD?=
 =?utf-8?B?NDlDV2g3UGc0S1B6ajZMb3Y1ZSs3ZmZJMG5vN3BnWXVqc1YzYUU3Z3diYWcx?=
 =?utf-8?B?YVlYRmRUbERVOTV2bUQzMkRoK0Q1UjM2Q1dra2tTQjRwYW0yRU84MUgrelR4?=
 =?utf-8?B?Zm9ic0lSUVVjWGJpZzlIVUE0U0J4OVJrN1NOR2RrSGZoM3pKVkRjRVpmY29F?=
 =?utf-8?B?NHJ1NzVBWnJlZDRkWkpFNjBKKytTSm81bmZCUS9TQjZ6QTVONDZCTno2M2NX?=
 =?utf-8?B?WUlBcWNuanl2Y3JLOWYxQ3VhVDdlWTFLYzhxWnMxdlZNZndaYkNEQkdvMkp6?=
 =?utf-8?B?aXVHbU1YSUMvOERWNFluaUtOSi9KVXhIZkV1ZEY1clMrSzZ6cTUzZHdXMlpF?=
 =?utf-8?B?L2dNYllYRGFCTk94MWFYWVFuck9YK0ZVUVlQMWNLK3MrVGhVdTJpdXorT1E3?=
 =?utf-8?B?emh3UE5ucFpGOWZqcnF0R0F5c212bWxwUGZvNy9KL09mdVBxcjFGU0JaVTVE?=
 =?utf-8?B?TmlxRkRsamN6NEh0WTIvSjJwVjNQYjkxQ2VnOFNCU1hPSGY4bWFvR2dlNEZi?=
 =?utf-8?B?ZFcxN2lqbkJ3dFFGMFBLMzM0Wm5BOXlyZkZvWHY4cGhxS3dsdmg1U0s4dUlU?=
 =?utf-8?B?RzNyc3NqRHBtNDhHTTRBMkNDMkg2TjV4MUpsb1lMMjNPdHRESmxQd3Bac0dM?=
 =?utf-8?B?dkF1YUhtMkVVYUpwTCtxeXdwd3QwdFlrK3R3am02dzd0QmZ5djNYcXVjTGpo?=
 =?utf-8?B?RFF1dEoxY1YyMnFBUXMwODZoU0ZTa1NMdUZudkxBR0U0QllNYklBZXVsYjlB?=
 =?utf-8?B?RW1RM3Q0aWNwdG5ya1BhRjRUdHhPdnlOSGdHZGVrRENSRzFHOFQ5M3NocEtU?=
 =?utf-8?B?UXJBc2FqQ2pQWXM5UnNtSnFsRzl1a0FuRTlLU3NHcGsvb0FGOTZRNDZySzJZ?=
 =?utf-8?B?aUdROGFneEVkRFFqL3NCcE42V094QmVoTTJkMnBZQWVlVGtLVHpjQ1dNN0Mv?=
 =?utf-8?B?alRDRXBra1ZyYmNBRXpmbCsraGx1TmRRaU1OekdLdktHYnNkSHJncWhLRUxD?=
 =?utf-8?B?U0FDRUpKNE40RnZhZEhIQUJ5RFhweHRNenRNaWErUjJHZkN5N29ZWk40T0xK?=
 =?utf-8?B?NzdmdmhuRGc2NmFHaEVrUzl1cTBhc2xPTFJzUzNMZ1dtWllaelE5M2tjd1Nj?=
 =?utf-8?B?N2FKK0VhS2VSYzJlV2lWOWs1WHF6WDUzZVR1cWdybXpXVW1hTHlOZDAvTEFo?=
 =?utf-8?B?bHpPQ3NHNC92WGM4Sk9mR1oraVZyNVg2aVlnZ2xLWjREZHdQSFVvWHNpaGQ2?=
 =?utf-8?B?R0tTNzYyOE1nU1ZZajR3bWdrQ0lNSWZYOVk2SFBVZ3YwSTBPbGw5L2lTTGZK?=
 =?utf-8?B?dG9kWk81QzQ0WDVPckRnVUZaNFhCWnhTSE9KNWc3UmE1TjlNSmE5c3FaVklP?=
 =?utf-8?B?dWZsZFN5NTNQU0d4MGZ0YjNwS1pUNjBIbjBsL2xyN0JuaWxsekNzR2JIY21U?=
 =?utf-8?B?YUE9PQ==?=
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-ExternalHop-MessageData-0: 
	Sbmyk4rFKSmSq1u5LsvTpVMaHjFgmIRrtIUgnWZQ/sTWdUhX3jvr0awCqFu8Ct7rfXen+aEtnxzZOH6Fy2Uj+bVmNjNBFQvJIVMys1/1b6UmReWhbs8UNQjHfd7DehnNJCJTHEFeRFKkIK3RAEiAYm0YFxvjHkrnCPLNOjqXPgXLRHV3/en9EluEsrCpWg5DP8CCYf6x8fsXnDPlMY8flGGIhEK1UTVSHdK7nXtQI+ooGE5v8hcuVmL2fKFbEb07tLXoFE1EgDIoHsqfLfOUpwnd7cuQHOdNzp4O3fUMlWDWVhTqxpLIE9AF5bV31Sp81cWbhPe+eGqAlnPjJE4oSjLLFFbY4MPL/4ho8rDDMVgqEMS2oGdCZV0PwVVkvI92brCL8mEm+Exx7yvgSxoznMgiLxRQdi8cu2Shk3NporXveaZuHgb19ApZrKEwibAem9rCDTYQQy1wLxHgN5Md+bQ9nz5PoRkYACVl0KQo1B5JyUavuuYZNSgC5ID5jVvJvUUKdUDvWmezZIYB60KGqznlFMLO/5lP5QkT1M6Tm5XyBxUOnJDOGUi65Z9EkYmRIbPLhTLtl8U861GePVMNFderKUVV0sg1yRs5fBacn/4=
X-OriginatorOrg: oracle.com
X-MS-Exchange-CrossTenant-Network-Message-Id: fc1e7dbc-6d84-4364-12bd-08dc334b7bbf
X-MS-Exchange-CrossTenant-AuthSource: DS0PR10MB7224.namprd10.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 02:10:47.3803
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 4e2c6054-71cb-48f1-bd6c-3a9705aca71b
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: 4bmX5arLZds36u48hg6AEO/TXCYmeectAp25m+gMc4ID1jSvpIyzFRxtFD6a/dWzxCV6xdrC8onjfd8sr9ix2sFwjtLsZLtU7JS4fm4fnvE=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: MN2PR10MB4351
X-Proofpoint-Virus-Version: vendor=baseguard
 engine=ICAP:2.0.272,Aquarius:18.0.1011,Hydra:6.0.619,FMLib:17.11.176.26
 definitions=2024-02-21_10,2024-02-21_02,2023-05-22_02
X-Proofpoint-Spam-Details: rule=notspam policy=default score=0 suspectscore=0 phishscore=0
 adultscore=0 mlxlogscore=999 mlxscore=0 bulkscore=0 malwarescore=0
 spamscore=0 classifier=spam adjust=0 reason=mlx scancount=1
 engine=8.12.0-2311290000 definitions=main-2402220015
X-Proofpoint-ORIG-GUID: Cu2DIczEwzt4BuHso0NCcFiCWrYlqHKj
X-Proofpoint-GUID: Cu2DIczEwzt4BuHso0NCcFiCWrYlqHKj

On 2/21/24 6:03 PM, 'Andrew Cooper' via trenchboot-devel wrote:
> On 15/02/2024 8:08 am, Ard Biesheuvel wrote:
>> On Wed, 14 Feb 2024 at 23:31, Ross Philipson <ross.philipson@oracle.com> wrote:
>>> +/*
>>> + * Primary SLR Table Header
> 
> I know it's just a comment, but SLR ought to be written in longhand here.

Will do, thanks. Ross.

> 
>>> + */
>>> +struct slr_table {
>>> +       u32 magic;
>>> +       u16 revision;
>>> +       u16 architecture;
>>> +       u32 size;
>>> +       u32 max_size;
>>> +       /* entries[] */
>>> +} __packed;
>> Packing this struct has no effect on the layout so better drop the
>> __packed here. If this table is part of a structure that can appear
>> misaligned in memory, better to pack the outer struct or deal with it
>> there in another way.
> 
> As you note, __packed does two things not one.
> 
> The consumer of the random integer that is expected to be a pointer to a
> struct lsr_table doesn't know whether it was invoked by a 16bit
> bootloader or a 32bit bootloader, and this really does make a difference
> for an ABI described only in C.
> 
> Then again, we're holding off on setting the spec in stone until there's
> an agreement in principle, so we could retrofit a statement about the
> expected alignment of this structure in memory.
> 
> The sane choices are either 8b alignment (there are uint64_t's in
> entires[], but I also see there are some misaligned uint64_t's too,
> which is dull), or using the good old x86 fallback or paragraph
> alignment just in case we really want to extend it with a uint128_t in
> future.
> 
> Thoughts?
> 
> ~Andrew
>