Received-SPF: pass (google.com: domain of linux-crypto+bounces-2251-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.199.223 as permitted sender) client-ip=147.75.199.223;
Message-ID: <f4af8317-776f-7530-51af-9cf42eab7b01@quicinc.com>
Date: Thu, 22 Feb 2024 16:56:19 +0530
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101
 Thunderbird/91.8.0
Subject: Re: [PATCH 03/11] crypto: qce - Convert register r/w for skcipher via
 BAM/DMA
Content-Language: en-US
To: Md Sadre Alam <quic_mdalam@quicinc.com>, <thara.gopinath@gmail.com>,
        <herbert@gondor.apana.org.au>, <davem@davemloft.net>,
        <agross@kernel.org>, <andersson@kernel.org>,
        <konrad.dybcio@linaro.org>, <vkoul@kernel.org>,
        <linux-crypto@vger.kernel.org>, <linux-arm-msm@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <dmaengine@vger.kernel.org>,
        <quic_varada@quicinc.com>
References: <20231214114239.2635325-1-quic_mdalam@quicinc.com>
 <20231214114239.2635325-4-quic_mdalam@quicinc.com>
From: Sricharan Ramabadhran <quic_srichara@quicinc.com>
In-Reply-To: <20231214114239.2635325-4-quic_mdalam@quicinc.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit


On 12/14/2023 5:12 PM, Md Sadre Alam wrote:
> Convert register read/write for skcipher via BAM/DMA.
> with this change all the crypto register configuration
> will be done via BAM/DMA. This change will prepare command
> descriptor for all register and write it once.
> 
> Signed-off-by: Md Sadre Alam <quic_mdalam@quicinc.com>
> ---
>   drivers/crypto/qce/common.c   | 42 +++++++++++++++++++++--------------
>   drivers/crypto/qce/skcipher.c | 12 ++++++++++
>   2 files changed, 37 insertions(+), 17 deletions(-)
> 
> diff --git a/drivers/crypto/qce/common.c b/drivers/crypto/qce/common.c
> index 04253a8d3340..d1da6b1938f3 100644
> --- a/drivers/crypto/qce/common.c
> +++ b/drivers/crypto/qce/common.c

  Changes to common.c should have been in patch #2 ?
  Btw, if we are making cmd desc approach as default for all socs
  we should have it tested in all platforms ?

Regards,
  Sricharan