Received-SPF: pass (google.com: domain of linux-crypto+bounces-2259-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Thu, 22 Feb 2024 10:25:15 -0800
From: Dan Williams <dan.j.williams@intel.com>
To: Dan Williams <dan.j.williams@intel.com>, Dave Jiang
	<dave.jiang@intel.com>, Marek =?iso-8859-1?Q?Beh=FAn?= <kabel@kernel.org>,
	<linux-kernel@vger.kernel.org>, Hans de Goede <hdegoede@redhat.com>, "Matti
 Vaittinen" <mazziesaccount@gmail.com>
CC: Horia =?utf-8?Q?Geant=C4=83?= <horia.geanta@nxp.com>, Pankaj Gupta
	<pankaj.gupta@nxp.com>, Gaurav Jain <gaurav.jain@nxp.com>, Herbert Xu
	<herbert@gondor.apana.org.au>, "David S. Miller" <davem@davemloft.net>,
	Davidlohr Bueso <dave@stgolabs.net>, Jonathan Cameron
	<jonathan.cameron@huawei.com>, Alison Schofield <alison.schofield@intel.com>,
	Vishal Verma <vishal.l.verma@intel.com>, Ira Weiny <ira.weiny@intel.com>, Dan
 Williams <dan.j.williams@intel.com>, Bamvor Jian Zhang <bamv2005@gmail.com>,
	Linus Walleij <linus.walleij@linaro.org>, "Bartosz Golaszewski"
	<brgl@bgdev.pl>, Douglas Anderson <dianders@chromium.org>, Andrzej Hajda
	<andrzej.hajda@intel.com>, Neil Armstrong <neil.armstrong@linaro.org>, Robert
 Foss <rfoss@kernel.org>, "Laurent Pinchart"
	<Laurent.pinchart@ideasonboard.com>, Jonas Karlman <jonas@kwiboo.se>, Jernej
 Skrabec <jernej.skrabec@gmail.com>, "Maarten Lankhorst"
	<maarten.lankhorst@linux.intel.com>, Maxime Ripard <mripard@kernel.org>,
	Thomas Zimmermann <tzimmermann@suse.de>, David Airlie <airlied@gmail.com>,
	Daniel Vetter <daniel@ffwll.ch>, James Seo <james@equiv.tech>, Jean Delvare
	<jdelvare@suse.com>, Guenter Roeck <linux@roeck-us.net>,
	<linux-crypto@vger.kernel.org>, <linux-cxl@vger.kernel.org>,
	<linux-gpio@vger.kernel.org>, <dri-devel@lists.freedesktop.org>,
	<linux-hwmon@vger.kernel.org>
Subject: Re: [PATCH 2/2] devm-helpers: Add resource managed version of
 debugfs directory create function
Message-ID: <65d7918b358a5_1ee3129432@dwillia2-mobl3.amr.corp.intel.com.notmuch>
References: <20240222145838.12916-1-kabel@kernel.org>
 <20240222145838.12916-2-kabel@kernel.org>
 <23c50406-7ebd-4cc3-a978-1b8a5fc71ff0@intel.com>
 <65d78e55844c1_1ee312946a@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Content-Type: text/plain; charset="iso-8859-1"
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <65d78e55844c1_1ee312946a@dwillia2-mobl3.amr.corp.intel.com.notmuch>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?iso-8859-1?Q?jc0CMwJ+viTns2sPchYhwb5l9f+KZ86qER28p6uC4ri9MI9D5A1f/TJ+hy?=
 =?iso-8859-1?Q?HE+oKNMqqWUVg4ZKjKa4QJY08Nc9xZCzoXcsUV6Vs3bINxO61hR227vMFL?=
 =?iso-8859-1?Q?G75foFHovO5TMcRC1YB+zPolu9f/xjFy087OjjTWG/GRcaEQO+saCZkNgX?=
 =?iso-8859-1?Q?oOcWgSEVWFP9mruRDvx+8jmJ/Vum7rtXX4hQgptNdw9qtxbz3OP+aZf88g?=
 =?iso-8859-1?Q?2Dz/LJ81sz/LtXziAz2iElkSGf9AQ7QkTa20IKvuvCn1ikxtSDrdxUmzj+?=
 =?iso-8859-1?Q?MkXOZIXtSerg/0/RVMCYxY7cHfgn1BQqXdvVZf7GLHFxbYf+69HU2mM2uJ?=
 =?iso-8859-1?Q?6w1bPg46dq3gJhmHyXjZiahEG9wJnLYehkhH7VD6dGtF6WIdJRKbTr0fVD?=
 =?iso-8859-1?Q?MPaC6pezJTuumJd80XKVEUqVarFgQm8D1NFVTXyepteewgHZztqh+QeVJF?=
 =?iso-8859-1?Q?3jPjYVTF59PBDcqNqfvDlMXqDf2hxGhsLs40rgUQ/PuDqF7KTWjASn+BJJ?=
 =?iso-8859-1?Q?qIgpmqDRf/m2f7Egr9zZEi9z6BxWi/fVKBB4BhDr7EzaISrTNyd68uDK8x?=
 =?iso-8859-1?Q?MfG9cSwKF3v9BqiXu0qVjoq6PvbfKUKl8ffLA+s5ss13exPNCuUE2wqUrW?=
 =?iso-8859-1?Q?LZXocgJ6KSKDd9cSJjzDxSXF4AeZulU10JaFnGQHTb9+O+5SlwmqtPzwj1?=
 =?iso-8859-1?Q?BXD44iXqfN0hqDEu6TKiqibaZ1ZUb5YSFmf8CJN1y2zMq92C/KdcjjKC4w?=
 =?iso-8859-1?Q?PNtjRd+XvUUe0r/lYdfILS+lRsnUgGyBNo+XIz4ZmpJvLDHPBtorgC2lFu?=
 =?iso-8859-1?Q?XN8WHv738r8crxxM2Q78x2915CR4oS0Vzxa45CPVUD2HXUl9isk/0hAett?=
 =?iso-8859-1?Q?ZhNotQWg+BQf9ppJuliwckrUnBZfVwlIOkevKIMdb+R+3vRoG1LkJqHLNS?=
 =?iso-8859-1?Q?T2QxZN0Np7cEbt0PYnZqj7Xh/vWxr1FkRfJe1C7El83mZMuVr2k3wZp71Z?=
 =?iso-8859-1?Q?acUJuvo46qKV+D92xmbw6VsXoo7SaFebOkKdmGi+bs+FBy1xVCfB+VL/6R?=
 =?iso-8859-1?Q?UsqdAQDvmXPIHULWObode34RWL0wfNSdoKXthD29hEVms/F/z42+W5UzkK?=
 =?iso-8859-1?Q?ZAioeN6NyHElJS3dBJagWq3KOWOKKCVuJSkZXnBcu6Ahb9cpfUZAyYZytz?=
 =?iso-8859-1?Q?DPpx8xmR2rmJ6sHTMmvDoZduwqeGwyQGmHHk8dollkXC1aPkTI2+3g4kdc?=
 =?iso-8859-1?Q?o00ozapbKZyM61UIN5tbDGhV1BFCLuwICh75nxPWqvpl3J8+FPjHt79I8s?=
 =?iso-8859-1?Q?WQDJvkSflS9HiAZwfQDHHHEOy3ECKRasBowHZMBxTqbrCms4ZoBT7lCrMR?=
 =?iso-8859-1?Q?HJpRONd7ippNFV7l/TFSoEkGbMPlV+fP0IAxsXmpaLGMtYqJ9isudaRd0G?=
 =?iso-8859-1?Q?eI23RFGoqPFxpcXq+86MYYk8ibL8Cr3Lq1miwqWhOOj0RWwRJURh4hPnIL?=
 =?iso-8859-1?Q?BXIBdJSZkfy6hTwpz2kiBzK6EHmsJjs0h8PAFu4u1MEjM/rSTGPcKtAF1r?=
 =?iso-8859-1?Q?Ialx03UgzVhFXp/o15MDue3XB8cgmbPgoxX2XDhVgLDIdvsnVBI7adDNXu?=
 =?iso-8859-1?Q?Kg8D3hyEOO/5eTHlwpT/cc/OBq9dSLGEKHyDTwOOAuAmUEXPOkG5hHWQ?=
 =?iso-8859-1?Q?=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: ebc1b1a1-73a9-4663-5eb9-08dc33d39fdd
X-MS-Exchange-CrossTenant-AuthSource: PH8PR11MB8107.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 22 Feb 2024 18:25:19.4517
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: uYig7fF1jS41Pb9D8C+d1C0dFe4oyfod4zlkmGHfmSzRd9zod1kX2UECHpt76B4AAPfj0wSjrE8uWxozfB9x+HmnMwDqZo9hlPc/qzuM2vs=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DS7PR11MB6104
X-OriginatorOrg: intel.com

Dan Williams wrote:
> Dave Jiang wrote:
> > 
> > 
> > On 2/22/24 7:58 AM, Marek Beh?n wrote:
> > > A few drivers register a devm action to remove a debugfs directory,
> > > implementing a one-liner function that calls debufs_remove_recursive().
> > > Help drivers avoid this repeated implementations by adding managed
> > > version of debugfs directory create function.
> > > 
> > > Use the new function devm_debugfs_create_dir() in the following
> > > drivers:
> > >   drivers/crypto/caam/ctrl.c
> > >   drivers/gpu/drm/bridge/ti-sn65dsi86.c
> > >   drivers/hwmon/hp-wmi-sensors.c
> > >   drivers/hwmon/mr75203.c
> > >   drivers/hwmon/pmbus/pmbus_core.c
> > > 
> > > Also use the action function devm_debugfs_dir_recursive_drop() in
> > > drivers
> > >   drivers/cxl/mem.c
> > >   drivers/gpio/gpio-mockup.c
> > > 
> > > Signed-off-by: Marek Beh?n <kabel@kernel.org>
> > > ---
> > >  drivers/crypto/caam/ctrl.c            | 16 +++------
> > >  drivers/cxl/mem.c                     |  9 ++---
> > >  drivers/gpio/gpio-mockup.c            | 11 ++----
> > >  drivers/gpu/drm/bridge/ti-sn65dsi86.c | 13 ++------
> > >  drivers/hwmon/hp-wmi-sensors.c        | 15 ++-------
> > >  drivers/hwmon/mr75203.c               | 15 +++------
> > >  drivers/hwmon/pmbus/pmbus_core.c      | 16 +++------
> > >  include/linux/devm-helpers.h          | 48 +++++++++++++++++++++++++++
> > >  8 files changed, 72 insertions(+), 71 deletions(-)
> > > 
[..]
> > diff --git a/drivers/cxl/cxlmem.h b/drivers/cxl/cxlmem.h
> > index 5303d6942b88..b6f13ba87927 100644
> > --- a/drivers/cxl/cxlmem.h
> > +++ b/drivers/cxl/cxlmem.h
> > @@ -859,6 +859,5 @@ struct cxl_hdm {
> >  };
> >  
> >  struct seq_file;
> > -struct dentry *cxl_debugfs_create_dir(const char *dir);
> >  void cxl_dpa_debug(struct seq_file *file, struct cxl_dev_state *cxlds);
> >  #endif /* __CXL_MEM_H__ */
> > diff --git a/drivers/cxl/mem.c b/drivers/cxl/mem.c
> > index c5c9d8e0d88d..494abe7a54c5 100644
> > --- a/drivers/cxl/mem.c
> > +++ b/drivers/cxl/mem.c
> > @@ -4,6 +4,7 @@
> >  #include <linux/device.h>
> >  #include <linux/module.h>
> >  #include <linux/pci.h>
> > +#include <linux/devm-helpers.h>
> >  
> >  #include "cxlmem.h"
> >  #include "cxlpci.h"
> > @@ -30,11 +31,6 @@ static void enable_suspend(void *data)
> >  	cxl_mem_active_dec();
> >  }
> >  
> > -static void remove_debugfs(void *dentry)
> > -{
> > -	debugfs_remove_recursive(dentry);
> > -}
> > -
> >  static int cxl_mem_dpa_show(struct seq_file *file, void *data)
> >  {
> >  	struct device *dev = file->private;
> > @@ -128,7 +124,10 @@ static int cxl_mem_probe(struct device *dev)
> >  	if (work_pending(&cxlmd->detach_work))
> >  		return -EBUSY;
> >  
> > -	dentry = cxl_debugfs_create_dir(dev_name(dev));
> > +	dentry = devm_debugfs_create_dir(dev, dev_name(dev), NULL);
> > +	if (IS_ERR(dentry))
> > +		return PTR_ERR(dentry);
> > +
> 
> No that loses the "cxl" prefix.

So, to be clear, I do see the benefit of removing the
devm_add_action_or_reset() call altogether, but that work is a bit
deeper and should not be tied with all these other cleanups. So I think
from the CXL perspective, please drop these CXL changes out of this
patch. Follow up with a standalone patch, or leave it to drivers/cxl/
folks to create that deeper cleanup.