Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp1766978rbb; Mon, 26 Feb 2024 23:43:18 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWq/JlTQ0p735NKRt7YFahCXAeAXJz6Vj1APOQsX7gABPUNUFVV6rZG0Ru65sOSInqaVr0cS9ByXG2KgnCulnqMNokzGRUhe6xREwB0jw== X-Google-Smtp-Source: AGHT+IEcYx9Y4C9vD2A25K20Q0ZkS0utNN9aa+bXVR+txmpWCMWFQKH6+l/0hJhXLhHARXvGihEQ X-Received: by 2002:a0c:db13:0:b0:68f:ff2c:36ee with SMTP id d19-20020a0cdb13000000b0068fff2c36eemr2166287qvk.9.1709019798228; Mon, 26 Feb 2024 23:43:18 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709019798; cv=pass; d=google.com; s=arc-20160816; b=sYkACoX0PLYvzGI4qKK2v50GJrI5emU891wGpjCQ0ZTFl2ZUjuuLoxG/hwjPdoPJal OBa4ky6kMUFl9jBhq57tSTElKIk9aRCe4TCbI0+BKx5SNex5OR3iWMzepI/8Pk6KOzro iaAfldhKkoTPRPyIof7XxbeBgaRbO/9txxktoWrIqFamDWT6utQK1HP6yXW2OhsMXKBF Mt8fO5Y2eDQg018t2sTpp27ygOJQYobteoziCh4/p9UL1YKlXgO6pfgVZu2flSpJyFAj gbZ5qPgE7SQ0hoHPyX79nHTWYUv98TCyA+edoY+1SsB4QBkgrobDcWzhVxHK+PLJXZXS kH4A== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:date:message-id:dkim-signature; bh=wjrMeisqY8AoXJfPdTuiC48Afo5k16AYIhrX4PC3Rrw=; fh=MnFiDUfLOk/iMq0tbk1EGcaXNrSkRmPK6Rg8wXBTW5U=; b=mShofrDJAi18XOpdQw37+tr8yoRVHgTzXDxwqLnlUuYXH0rqHuiq6EuSfIZZlKHrSk hqUKh7dCss42hPaicS9a88nwRlv/1Mad0IseN7vOI22vtgPMRuzEX9jg674ypoQ2ahu3 6U22ULdztZJ7RGk9nVNslEeU5WcdY55ejVxnj+/0OUZ3ke4TT2rrjndiEuBQkMvypd4Y dOQqlPDqn6WwFtePcESJhrPyornsUjTjleBL1hzU9oPqmlOlgKI/5EiXxUd7IYofc9Nw TjkvbMfDhOiRVH1d5dpUf9d/tFEN0ju3fObTVqIEM5KR7QQXi5Jh+sVtbGWbnwN9QEUm OKNw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@xen0n.name header.s=mail header.b=CgwrGYZK; arc=pass (i=1 spf=pass spfdomain=xen0n.name dkim=pass dkdomain=xen0n.name); spf=pass (google.com: domain of linux-crypto+bounces-2335-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-crypto+bounces-2335-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id i7-20020ad45c67000000b0068f3be89f52si6785066qvh.322.2024.02.26.23.43.18 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 26 Feb 2024 23:43:18 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto+bounces-2335-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@xen0n.name header.s=mail header.b=CgwrGYZK; arc=pass (i=1 spf=pass spfdomain=xen0n.name dkim=pass dkdomain=xen0n.name); spf=pass (google.com: domain of linux-crypto+bounces-2335-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-crypto+bounces-2335-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id DFC141C21FB5 for ; Tue, 27 Feb 2024 07:43:17 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 9DE1754F8F; Tue, 27 Feb 2024 07:43:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=xen0n.name header.i=@xen0n.name header.b="CgwrGYZK" X-Original-To: linux-crypto@vger.kernel.org Received: from mailbox.box.xen0n.name (mail.xen0n.name [115.28.160.31]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C3A1454BCB; Tue, 27 Feb 2024 07:42:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=115.28.160.31 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709019781; cv=none; b=L/GakyDjFCCK+xURU42pqp5ZU/AuM3EVnNwzd988Ald46uQ2IEj1nI42UsTU3RH0scqrdj1wO8yDYD16K9OUHb4YtJXuaTAHfr8XHFlBqf/ane3PznNctnT5bAuewflnxZ29VvfSKXQudAQ5uHFwjT1RFzMND8TGRD+bDghOu4c= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709019781; c=relaxed/simple; bh=VeQQz1LGeycIAUL/EG5r7Rx6hXmeV3PR/rjB1cNm8r8=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=QkpbUbB8prCN5QKh535Wk3yl4XMFMeHSzL0atKRBU9tkG+fIuLLuRwoCQsc/YlA58TWlgHYjsjdnTyChpYKMbmyZxYPkP+K72JJ9e8ORWd3I3RwtO6IlNkLAnPtDZBN3nGnzZDP/SBXRvfOI5WYjw3DkYaWzyjy928muWiOmA/M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=xen0n.name; spf=pass smtp.mailfrom=xen0n.name; dkim=pass (1024-bit key) header.d=xen0n.name header.i=@xen0n.name header.b=CgwrGYZK; arc=none smtp.client-ip=115.28.160.31 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=xen0n.name Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=xen0n.name DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=xen0n.name; s=mail; t=1709019771; bh=VeQQz1LGeycIAUL/EG5r7Rx6hXmeV3PR/rjB1cNm8r8=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=CgwrGYZKopCqIHyNKix56CRK6Zx1FUln27PllXLGI28yYptJmjITlqfLEMtm1+nzb VBHf+/dtpa3ZpccqLfMSWZSqrHmMtyLuCmr5LNDPHnPuQlFCU74W52hcMcjWsH2bQS gXk/+Npz+yt5Oelq7n7rp+hkdXvNUxrpeaZELIII= Received: from [28.0.0.1] (unknown [101.230.251.34]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mailbox.box.xen0n.name (Postfix) with ESMTPSA id 0419B60121; Tue, 27 Feb 2024 15:42:50 +0800 (CST) Message-ID: <0a7d0a9e-c56e-4ee2-a83b-00164a450abe@xen0n.name> Date: Tue, 27 Feb 2024 15:42:49 +0800 Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] loongarch/crypto: Clean up useless assignment operations Content-Language: en-US To: =?UTF-8?B?5YWz5paH5rab?= , =?UTF-8?B?546L5pix5Yqb?= , herbert , davem , chenhuacai Cc: linux-crypto , loongarch , linux-kernel References: <20240226080328.334021-1-wangyuli@uniontech.com> <48afa638-9145-40ee-9868-fa82a1fce271@xen0n.name> From: WANG Xuerui In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit On 2/26/24 16:25, 关文涛 wrote: > Sure,but we not seem to have "crc.w.d.w" dword asm in loongarch 32bit mode,now the whole file can only run in 64bit mode? > > Thanks. Sorry. I have checked the manual and it turns out you & Yuli are correct: even though the narrower CRC instructions doesn't require GRLEN=64, they still *aren't* part of LA32 (LoongArch reference manual v1.10, Volume 1, Table 2-1). Counter-intuitive as it is, the original patch is correct nevertheless. I'm going to amend my review shortly. -- WANG "xen0n" Xuerui Linux/LoongArch mailing list: https://lore.kernel.org/loongarch/