Received-SPF: pass (google.com: domain of linux-crypto+bounces-2360-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: "Zeng, Xin" <xin.zeng@intel.com>
To: Alex Williamson <alex.williamson@redhat.com>, "jgg@nvidia.com"
	<jgg@nvidia.com>
CC: "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
	"yishaih@nvidia.com" <yishaih@nvidia.com>,
	"shameerali.kolothum.thodi@huawei.com"
	<shameerali.kolothum.thodi@huawei.com>, "Tian, Kevin" <kevin.tian@intel.com>,
	"linux-crypto@vger.kernel.org" <linux-crypto@vger.kernel.org>,
	"kvm@vger.kernel.org" <kvm@vger.kernel.org>, qat-linux <qat-linux@intel.com>,
	"Cao, Yahui" <yahui.cao@intel.com>
Subject: RE: [PATCH v3 10/10] vfio/qat: Add vfio_pci driver for Intel QAT VF
 devices
Thread-Topic: [PATCH v3 10/10] vfio/qat: Add vfio_pci driver for Intel QAT VF
 devices
Thread-Index: AQHaZN7uGaDln+Lw/0+91W8o27GvhrEdAR0AgALB7iA=
Date: Wed, 28 Feb 2024 13:57:08 +0000
Message-ID: <DM4PR11MB5502450A52C4BE0E0465B76088582@DM4PR11MB5502.namprd11.prod.outlook.com>
References: <20240221155008.960369-1-xin.zeng@intel.com>
 <20240221155008.960369-11-xin.zeng@intel.com>
 <20240226115556.3f494157.alex.williamson@redhat.com>
In-Reply-To: <20240226115556.3f494157.alex.williamson@redhat.com>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0: =?us-ascii?Q?9QVBTBF9qI6bqkkICaeV6iehXGIrgVZ2Fc3hSW35eR2JuJdlisXcuS+pHRgF?=
 =?us-ascii?Q?FD4DKa+Qz6NfV4s/PCXTMOcn00DIT6mtsMks7FQpMktvrVNR/NxhiOCbDhqY?=
 =?us-ascii?Q?y/1NojpguoWJvwciTtdGuPpn9gnQO4QC9d4Y5ygjoXHUOPFicy/7zW1Yu9ZN?=
 =?us-ascii?Q?TTEuTTrHFasr6A/lu3OA/D2ziSR3WbQbJAC0BuCxpPBGD/Z4ISIqNlguZhLp?=
 =?us-ascii?Q?4FUa5EmUoAw800GBVtZFijatOsEkRDgx+s5IMWOcFi9xcPY0c2J1OxFGhjHB?=
 =?us-ascii?Q?IgXAoU5J/m0QfT11ay4Ihwpdms0ZNauION/vXK2SwJjypYjJCcGFXlmKbrsb?=
 =?us-ascii?Q?Tn/WSsTJ7qP6UeVcsbomnwCo6C65Zp+BdgpugigjhFp/5s6jgm8I/tUKe04D?=
 =?us-ascii?Q?RT/WtQmvoB2o4SV6XgXHIvezurlbraJ7GpBMls2b/DcoUKq2tI1wA9CJGRWy?=
 =?us-ascii?Q?BnDh99FGU52kHWoUbAunv92JEtlOAvMF5fgNyu6TStWPdgE1N/KK4De6ain/?=
 =?us-ascii?Q?LZpRr6lmIQqxX6YDis5+gZZYPAJOqjKnZ4frNnd57qsP7h1iPBkGwubxvEzo?=
 =?us-ascii?Q?43EvyTHe1tex3G1i7LKijodZUjvGdWwbp5eIp1CZn1duph35ceY4QtUqlH3H?=
 =?us-ascii?Q?bwyIwoRbdYQD0zxNEo6vapd84k1WUceLfigpglfipahTBnERmMheAIqYstyJ?=
 =?us-ascii?Q?IxiJLEBS5DYS3k/HI6JLlCQrCTfzcQPa55ZCVZtZ8wmYAfGRMIpWJF0yyE4V?=
 =?us-ascii?Q?wzTU0lEIdILOQrN+EnMy+wLafxklUA4m1+v69V5NuZlLDQhQe7dG4ntNuBZS?=
 =?us-ascii?Q?V5IhuoWI4+5aLBWErmu0+m/fyaDGQZtXrz3IdKXiLF2S6YoFgHYHiBFsK/rY?=
 =?us-ascii?Q?lQYFcUTbv/f2kKz/HSAxCBb3U3zQ6Em4/OIj8y3qrKhjyKcHz+q0F4GcJyYg?=
 =?us-ascii?Q?sVlSBTrCwU0Jo7issUCKyvvqb6XAM1zZcOXTmKu6OCmJyIhfd3bmVVRmZBmk?=
 =?us-ascii?Q?uKMNmIJojbXctYzKfhLZ0qaXX5VjgsRP+Whz3Ls+nDNfwPrOGXmtbfKY5c0X?=
 =?us-ascii?Q?B8dZc1Co1YsozkRI9HdSg2EZ4katJ4P/vXMYPYso42zv2uyoD9lAA51TGHob?=
 =?us-ascii?Q?v8ih0m4Aqkq+RC8ZZE8PwF08UtX+Bjo63hmO6u9rQAG5WhAl4FMap9EcymLY?=
 =?us-ascii?Q?R26aRuujQHeYMUoOrl/E41vctZKjeDTIx9q5ZHkXjagNokjN2OayCBbHG8Yk?=
 =?us-ascii?Q?Ujvo09yt+zBwa6hipnx3kQZHsx6Ds2Uvj4bU71SwbKCoXPE0CJYbK3wwRU6H?=
 =?us-ascii?Q?Byjwzshxx62x3MGioT3JmueS3r2Rw31SEdcnf/EhNBG9e0bbVZKRcbwd6HY5?=
 =?us-ascii?Q?Fmk61wlz7Ja+DK4Dkv9IztZbiSy+Zg7fqAtGI+rbA5/MKSXLmhxKFYokxzMQ?=
 =?us-ascii?Q?Qu53z3/613v9aSY3SOX0CYWlt/zybA1zHHjlQ6WoeWFytqKdo9xzFXxy0W4x?=
 =?us-ascii?Q?2dNB/CKSAAgvRVW82bRKxg58+vS4WXEsNof+gbSvaiTUI48/P6Vs2okoQmYh?=
 =?us-ascii?Q?X5jo48hAIHeiDX6R0vk=3D?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-crypto@vger.kernel.org
List-Id: <linux-crypto.vger.kernel.org>
List-Subscribe: <mailto:linux-crypto+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-crypto+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: DM4PR11MB5502.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: 6115ffe2-4c4f-48d1-67e0-08dc386527b4
X-MS-Exchange-CrossTenant-originalarrivaltime: 28 Feb 2024 13:57:08.8595
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: W6YZeoSSwHUewzkpa7rpqMspt5Z2o7vXT323GDCiQej4x+F2mYdebwSXvq8G/Coi7Bx5S/u+UmH08nxwdofXVQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR11MB4927
X-OriginatorOrg: intel.com

On Tuesday, February 27, 2024 2:56 AM, Alex Williamson <alex.williamson@red=
hat.com> wrote:
> On Wed, 21 Feb 2024 23:50:08 +0800
> Xin Zeng <xin.zeng@intel.com> wrote:
>=20
> >  MAINTAINERS                         |   8 +
> >  drivers/vfio/pci/Kconfig            |   2 +
> >  drivers/vfio/pci/Makefile           |   2 +
> >  drivers/vfio/pci/intel/qat/Kconfig  |  12 +
> >  drivers/vfio/pci/intel/qat/Makefile |   3 +
> >  drivers/vfio/pci/intel/qat/main.c   | 663 ++++++++++++++++++++++++++++
> >  6 files changed, 690 insertions(+)
> >  create mode 100644 drivers/vfio/pci/intel/qat/Kconfig
> >  create mode 100644 drivers/vfio/pci/intel/qat/Makefile
> >  create mode 100644 drivers/vfio/pci/intel/qat/main.c
> >
> > diff --git a/MAINTAINERS b/MAINTAINERS
> > index 5a4051996f1e..8961c7033b31 100644
> > --- a/MAINTAINERS
> > +++ b/MAINTAINERS
> > @@ -23099,6 +23099,14 @@ S:	Maintained
> >  F:
> 	Documentation/networking/device_drivers/ethernet/amd/pds_vfio_pci
> .rst
> >  F:	drivers/vfio/pci/pds/
> >
> > +VFIO QAT PCI DRIVER
> > +M:	Xin Zeng <xin.zeng@intel.com>
> > +M:	Giovanni Cabiddu <giovanni.cabiddu@intel.com>
> > +L:	kvm@vger.kernel.org
> > +L:	qat-linux@intel.com
> > +S:	Supported
> > +F:	drivers/vfio/pci/intel/qat/
> > +
>=20
> Alphabetical please.

Sure, will update it in next version.

>=20
> >  VFIO PLATFORM DRIVER
> >  M:	Eric Auger <eric.auger@redhat.com>
> >  L:	kvm@vger.kernel.org
> > diff --git a/drivers/vfio/pci/Kconfig b/drivers/vfio/pci/Kconfig
> > index 18c397df566d..329d25c53274 100644
> > --- a/drivers/vfio/pci/Kconfig
> > +++ b/drivers/vfio/pci/Kconfig
> > @@ -67,4 +67,6 @@ source "drivers/vfio/pci/pds/Kconfig"
> >
> >  source "drivers/vfio/pci/virtio/Kconfig"
> >
> > +source "drivers/vfio/pci/intel/qat/Kconfig"
>=20
> This will be the first intel vfio-pci variant driver, I don't think we
> need an intel sub-directory just yet.
>=20

Ok, will update it.

> Tangentially, I think an issue we're running into with
> PCI_DRIVER_OVERRIDE_DEVICE_VFIO is that we require driver_override to
> bind the device and therefore the id_table becomes little more than a
> suggestion.  Our QE is already asking, for example, if they should use
> mlx5-vfio-pci for all mlx5 compatible devices.
>=20
> I wonder if all vfio-pci variant drivers that specify an id_table
> shouldn't include in their probe function:
>=20
> 	if (!pci_match_id(pdev, id)) {
> 		pci_info(pdev, "Incompatible device, disallowing
> driver_override\n");
> 		return -ENODEV;
> 	}
>=20

Ok, make sense. According to the late discuss, I will include it in
next version.

> (And yes, I see the irony that vfio introduced driver_override and
> we've created variant drivers that require driver_override and now we
> want to prevent driver_overrides)
>=20
> Jason, are you seeing any of this as well and do you have a better
> suggestion how we might address the issue?  Thanks,
>=20
> Alex