Received-SPF: pass (google.com: domain of linux-crypto+bounces-2372-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Wed, 28 Feb 2024 09:51:12 -0600
From: Rob Herring <robh@kernel.org>
To: Jia Jie Ho <jiajie.ho@starfivetech.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
	"David S . Miller" <davem@davemloft.net>,
	Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>,
	Vinod Koul <vkoul@kernel.org>, linux-crypto@vger.kernel.org,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	dmaengine@vger.kernel.org
Subject: Re: [PATCH v3 1/6] dt-bindings: crypto: starfive: Add jh8100 support
Message-ID: <20240228155112.GA4059153-robh@kernel.org>
References: <20240227163758.198133-1-jiajie.ho@starfivetech.com>
 <20240227163758.198133-2-jiajie.ho@starfivetech.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240227163758.198133-2-jiajie.ho@starfivetech.com>

On Wed, Feb 28, 2024 at 12:37:53AM +0800, Jia Jie Ho wrote:
> Add compatible string and additional interrupt for StarFive JH8100
> crypto engine.
> 
> Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
> ---
>  .../crypto/starfive,jh7110-crypto.yaml        | 30 +++++++++++++++++--
>  1 file changed, 28 insertions(+), 2 deletions(-)
> 
> diff --git a/Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.yaml b/Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.yaml
> index 71a2876bd6e4..d44d77908966 100644
> --- a/Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.yaml
> +++ b/Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.yaml
> @@ -12,7 +12,9 @@ maintainers:
>  
>  properties:
>    compatible:
> -    const: starfive,jh7110-crypto
> +    enum:
> +      - starfive,jh8100-crypto
> +      - starfive,jh7110-crypto
>  
>    reg:
>      maxItems: 1
> @@ -28,7 +30,10 @@ properties:
>        - const: ahb
>  
>    interrupts:
> -    maxItems: 1
> +    minItems: 1
> +    items:
> +      - description: SHA2 module irq
> +      - description: SM3 module irq
>  
>    resets:
>      maxItems: 1
> @@ -54,6 +59,27 @@ required:
>  
>  additionalProperties: false
>  
> +allOf:
> +  - if:
> +      properties:
> +        compatible:
> +          const: starfive,jh7110-crypto
> +
> +    then:
> +      properties:
> +        interrupts:
> +          maxItems: 1
> +
> +  - if:
> +      properties:
> +        compatible:
> +          const: starfive,jh8100-crypto
> +
> +    then:
> +      properties:
> +        interrupts:
> +          maxItems: 2

This is already the max. Don't you want 'minItems: 2'?

> +
>  examples:
>    - |
>      crypto: crypto@16000000 {
> -- 
> 2.34.1
>