Received-SPF: pass (google.com: domain of linux-crypto+bounces-2381-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
From: JiaJie Ho <jiajie.ho@starfivetech.com>
To: 'Rob Herring' <robh@kernel.org>
CC: 'Herbert Xu' <herbert@gondor.apana.org.au>, "'David S . Miller'"
	<davem@davemloft.net>, 'Krzysztof Kozlowski'
	<krzysztof.kozlowski+dt@linaro.org>, 'Conor Dooley' <conor+dt@kernel.org>,
	'Eugeniy Paltsev' <Eugeniy.Paltsev@synopsys.com>, 'Vinod Koul'
	<vkoul@kernel.org>, "'linux-crypto@vger.kernel.org'"
	<linux-crypto@vger.kernel.org>, "'devicetree@vger.kernel.org'"
	<devicetree@vger.kernel.org>, "'linux-kernel@vger.kernel.org'"
	<linux-kernel@vger.kernel.org>, "'dmaengine@vger.kernel.org'"
	<dmaengine@vger.kernel.org>
Subject: RE: [PATCH v3 1/6] dt-bindings: crypto: starfive: Add jh8100 support
Thread-Topic: [PATCH v3 1/6] dt-bindings: crypto: starfive: Add jh8100 support
Thread-Index: AQHaaZtYk3iqPNzLJ0a1+9ODjrwyHrEf6LEAgACucSA=
Date: Thu, 29 Feb 2024 02:17:41 +0000
Message-ID:
 <SHXPR01MB067062096D7EE6FB5F9305C58A5FA@SHXPR01MB0670.CHNPR01.prod.partner.outlook.cn>
References: <20240227163758.198133-1-jiajie.ho@starfivetech.com>
 <20240227163758.198133-2-jiajie.ho@starfivetech.com>
 <20240228155112.GA4059153-robh@kernel.org>
In-Reply-To: <20240228155112.GA4059153-robh@kernel.org>
Accept-Language: en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?9DdpxgIOwP7wTnbwhLekxn97SOA3zUUxqe1SKoztwIcVdmhsMMNqfintq8H3?=
 =?us-ascii?Q?QwDb3EKPfTa74Vazx6iHp1tHtczz+1izfb3fhFlYf3+lnPjuPcaI1Rsp2hL4?=
 =?us-ascii?Q?QxKc4dyZTL9wGu07yPnEyPr0B8tHXfv42prW1/wE42uzm2J6Lfp7sDS85Vbb?=
 =?us-ascii?Q?8542nAHGU2BFXXhFqT9a5/n56lEKbKiOpVjGstgOCAJ1Y9IvT8WYvNtYXntt?=
 =?us-ascii?Q?qyw25SSIAbbC35lSzBvyh1w7pXgPP3LdZZ5QNh0JmqqY2Cro/60HExmbPb1H?=
 =?us-ascii?Q?ZWroS+8gdfXarQ1luUtl6ZYIYETtYlnvZGksYWIv1vrwDWF/blGRoVCXoJAS?=
 =?us-ascii?Q?H0pJu1nZCi7LE+NRTnfsy8+v1689u80FszjFxb48PSSdvHC5K4SG7P426T8B?=
 =?us-ascii?Q?F2I/9PI9cn9L9cHwwVOyFNF3lYnRv3M0Kk5XnrLmVi6OZP+FkQ+BcQC0J3E+?=
 =?us-ascii?Q?so1cC4UobvFV7HnV5MpT2+5bPV/tLbptOLzw7QCWQWOLoEMoHk+OMA3neRHc?=
 =?us-ascii?Q?9t3cLOfSy2vWjlMVleB5CaWquTXfwSJavYvmor2813DcKiRHLtD5hOvKH+Ig?=
 =?us-ascii?Q?kpTNj6QnPOOR6SHRj7hcWTYJXTJejSdQ92y2/Ab3ZSMMq5cx0l7TgqieJT04?=
 =?us-ascii?Q?XhNn/GUe5j5AIiia7XxgwVDTxKrORy3gER9yTF/8vZyWlUIVmN+y2bm5GsHd?=
 =?us-ascii?Q?KFjhUvmVCEJ69W+sY/Z1akMT3Xr9ufUUkQgTz8Ps/8OFPptMefdIcz7LJIrg?=
 =?us-ascii?Q?6wYCrymTWU27ieNg2TwP5zzQvrnRkLkVxbzLekc9xeAI43NSW8YxCr+/qZ6M?=
 =?us-ascii?Q?goUksJpsvMEWDm1Z3HRoZAZHKtBJDukTAf+QlncWnAWbgcZt1qxh9Bw/Qtf7?=
 =?us-ascii?Q?/dlSDPn3TDQjrq0v13S2+AOFUUwngBobwpcQ0CTHLze2Jf+BYayiOrfIhpIT?=
 =?us-ascii?Q?ZXtFTGh/d2P3Tk8w2mbuCQvLPXF8N05kD6x5duwgmgIgHgzdfkMgZkT15okj?=
 =?us-ascii?Q?vLP9VT6I9cqSTGRErYg32vKrB473vU1CzFVv4gDRTQKFMkHj65jURC2hXx69?=
 =?us-ascii?Q?nCMr6UJ+8YEQeXTHAPLFd9BI6hv1rztOXh4XLAoWO++N6L4OBmLsWYjzxfo2?=
 =?us-ascii?Q?4RCaj+oRlznQ/y12ceizYuUlT4wXGrqMFndVy7EDbNCRg744qqFhhGuLQZi0?=
 =?us-ascii?Q?UgXE48Io+j03JWgdF6ZDuJJ0kaHuUGMPxmxdMaxRANqPPVb6V2hgJBjPItOL?=
 =?us-ascii?Q?bM5BC25xDDc99so4Ynn4ZNiKqlGh6xteyBhDjN7hRIVwYfmSuqYt69/CrZuR?=
 =?us-ascii?Q?evRQgdQNdTp29CYPhel1rxAKn6cp7lvFWlOQONaHhzqbYJES6EAJ9K2hlyXj?=
 =?us-ascii?Q?h0cimACxqu1IAmTVZPM23v9FdsR0XkXlAFh6O1LCEFtKWPF2jC7YPp+tMtb7?=
 =?us-ascii?Q?x4TmP/MWZqTv3Im89xrN/m6x0Bk6LeA34UMzxsQ9c1NEIz5r3Yvpt6KOyw67?=
 =?us-ascii?Q?Ry0tYT36kO10BjuaSsdMNBjzF5ZWIbYGmQQINC+1xczfTuoeqC6TO1KGeoQI?=
 =?us-ascii?Q?aO/McELpK8/DTxUMBttvfZ1QQoHZACeL/WCCNIR0?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-crypto@vger.kernel.org
List-Id: <linux-crypto.vger.kernel.org>
List-Subscribe: <mailto:linux-crypto+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-crypto+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: starfivetech.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SHXPR01MB0670.CHNPR01.prod.partner.outlook.cn
X-MS-Exchange-CrossTenant-Network-Message-Id: 786ed7f3-1566-4fc7-6350-08dc38cc9bb9
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Feb 2024 02:17:41.6826
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 06fe3fa3-1221-43d3-861b-5a4ee687a85c
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: ZPdEbkY6c+0fHM5jzwROnBu+tNY6fE7lGsG4i/A1hmUWgv6oz1jk4zQgJUak3uVzLpjDhq6irQ+c8Z/qCf6e4afUHlc+Y1nNvQ2chwuDlrw=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SHXPR01MB0781

> > Add compatible string and additional interrupt for StarFive JH8100
> > crypto engine.
> >
> > Signed-off-by: Jia Jie Ho <jiajie.ho@starfivetech.com>
> > ---
> >  .../crypto/starfive,jh7110-crypto.yaml        | 30 +++++++++++++++++--
> >  1 file changed, 28 insertions(+), 2 deletions(-)
> >
> > diff --git
> > a/Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.yaml
> > b/Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.yaml
> > index 71a2876bd6e4..d44d77908966 100644
> > ---
> > a/Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.yaml
> > +++ b/Documentation/devicetree/bindings/crypto/starfive,jh7110-crypto.
> > +++ yaml
> > @@ -12,7 +12,9 @@ maintainers:
> >
> >  properties:
> >    compatible:
> > -    const: starfive,jh7110-crypto
> > +    enum:
> > +      - starfive,jh8100-crypto
> > +      - starfive,jh7110-crypto
> >
> >    reg:
> >      maxItems: 1
> > @@ -28,7 +30,10 @@ properties:
> >        - const: ahb
> >
> >    interrupts:
> > -    maxItems: 1
> > +    minItems: 1
> > +    items:
> > +      - description: SHA2 module irq
> > +      - description: SM3 module irq
> >
> >    resets:
> >      maxItems: 1
> > @@ -54,6 +59,27 @@ required:
> >
> >  additionalProperties: false
> >
> > +allOf:
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          const: starfive,jh7110-crypto
> > +
> > +    then:
> > +      properties:
> > +        interrupts:
> > +          maxItems: 1
> > +
> > +  - if:
> > +      properties:
> > +        compatible:
> > +          const: starfive,jh8100-crypto
> > +
> > +    then:
> > +      properties:
> > +        interrupts:
> > +          maxItems: 2
>=20
> This is already the max. Don't you want 'minItems: 2'?

I'll fix this in the next version.
Thanks for reviewing this.

Regards,
Jia Jie