Received-SPF: pass (google.com: domain of linux-crypto+bounces-2382-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240226080328.334021-1-wangyuli@uniontech.com>
In-Reply-To: <20240226080328.334021-1-wangyuli@uniontech.com>
From: Huacai Chen <chenhuacai@kernel.org>
Date: Thu, 29 Feb 2024 11:05:22 +0800
Message-ID: <CAAhV-H4CXW5Lkn1=hMnMbcY3MO2eoos8bSr3Z5jY_piAbpP+5A@mail.gmail.com>
Subject: Re: [PATCH] loongarch/crypto: Clean up useless assignment operations
To: WangYuli <wangyuli@uniontech.com>
Cc: herbert@gondor.apana.org.au, davem@davemloft.net, kernel@xen0n.name, 
	linux-crypto@vger.kernel.org, loongarch@lists.linux.dev, 
	linux-kernel@vger.kernel.org, Guan Wentao <guanwentao@uniontech.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi, Yuli,

The code is fine to me, please change loongarch to LoongArch in the
subject, and update your commit message with Xuerui's review in V2.

Huacai

On Mon, Feb 26, 2024 at 4:04=E2=80=AFPM WangYuli <wangyuli@uniontech.com> w=
rote:
>
> Both crc32 and crc32c hw accelerated funcs will calculate the
> remaining len. Those codes are derived from
> arch/mips/crypto/crc32-mips.c and "len -=3D sizeof(u32)" is not
> necessary for 64-bit CPUs.
>
> Removing it can make context code style more unified and improve
> code readability.
>
> Suggested-by: Guan Wentao <guanwentao@uniontech.com>
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> ---
>  arch/loongarch/crypto/crc32-loongarch.c | 2 --
>  1 file changed, 2 deletions(-)
>
> diff --git a/arch/loongarch/crypto/crc32-loongarch.c b/arch/loongarch/cry=
pto/crc32-loongarch.c
> index a49e507af38c..3eebea3a7b47 100644
> --- a/arch/loongarch/crypto/crc32-loongarch.c
> +++ b/arch/loongarch/crypto/crc32-loongarch.c
> @@ -44,7 +44,6 @@ static u32 crc32_loongarch_hw(u32 crc_, const u8 *p, un=
signed int len)
>
>                 CRC32(crc, value, w);
>                 p +=3D sizeof(u32);
> -               len -=3D sizeof(u32);
>         }
>
>         if (len & sizeof(u16)) {
> @@ -80,7 +79,6 @@ static u32 crc32c_loongarch_hw(u32 crc_, const u8 *p, u=
nsigned int len)
>
>                 CRC32C(crc, value, w);
>                 p +=3D sizeof(u32);
> -               len -=3D sizeof(u32);
>         }
>
>         if (len & sizeof(u16)) {
> --
> 2.33.1
>