Received: by 2002:a05:7208:13ce:b0:7f:395a:35b6 with SMTP id r14csp355246rbe; Thu, 29 Feb 2024 01:16:22 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCWm7eYy1wFhYjLTtCR9m/59uy6YAb2TrDy3BDxJff2CdjB19zyMQ4obwrtqlQUSzOzabjaT/JN0BgkEUQgUeiBtHaR1UvO2TApUk9r8yg== X-Google-Smtp-Source: AGHT+IHYR7HFcyTSIIIrxNMwJscpEB/xDvDihKpJU5LufseTq2uJ1Y/EepuQ+PLAH/QTeW4yzaQS X-Received: by 2002:a17:906:3394:b0:a44:b96:2811 with SMTP id v20-20020a170906339400b00a440b962811mr1067056eja.29.1709198182590; Thu, 29 Feb 2024 01:16:22 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709198182; cv=pass; d=google.com; s=arc-20160816; b=LRILXlfR4uZiV4C67y+CVfWAhZpUdLjxkoj4nZylPTFAgizVv3njcBvI91h/+DMjkd /v/wsgeRF+YzT3KJ5Rb0rpef+MU0qM+rwnjp6iwqBI0RLnhd19/YZ4zhqwJz30xMSzAz 7j6eVdj8K99xyLN4I3/NXnudyqrxjRvf2FiotCrR3G0bN8eGeh1fr2AoDsonQh16+gh+ B8zFJPKQpUmMytvyaq3ZrFH+w+9Z/SiARGCFYaBCwzjSbEngRg+gpGdIm/8O/j/C2kwg BadHXR7w7Er/zrvW4XKBZJRtfW5y2U5T+eSYIxfGMvgIXT4A5uR4et0aqrg9n+n+Pdwd 9vwA== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:in-reply-to:content-disposition:mime-version :list-unsubscribe:list-subscribe:list-id:precedence:references :message-id:subject:cc:to:from:date; bh=FdNETkhrs0j2WilgXW0YF4mhUuidnbTpo5vcqWY26G8=; fh=/w08LdzNt1kNSwWwCVqhlqp7XWsG8pryXQF7MxR0bbE=; b=b98VA2g7wGc+9CMSa5SJOgKkErXG46/xAgqQ1YQwQlZUXxkAZXqiVXeonLmHYBi+Z1 9spZQpi+NTJ47vve4ywBj9ZHteeqfvVrespy3pnrouRjj2Ax4i/5o53rGP9DObRaVT+b VMgy8F5ygXWsJCr1B4PkwWhQUTYxC2tPQ4rVmBA3WIMZowjGRdxJ8ly1+W/wBpe6d7om KmzWpqyGekf5GEKpvvR2mDbSHrho7xZFAJ/udBpXBvs6dSI2ZQxvVoq529E3U7lmDER6 lY7BJT19alPilUUNPYuQ2UcAqi6M0Cjg4MKAx/3UTgOUxzICx/fQeE87/t/AK7S2uJ9k 6QWg==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-crypto+bounces-2385-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-crypto+bounces-2385-linux.lists.archive=gmail.com@vger.kernel.org" Return-Path: Received: from am.mirrors.kernel.org (am.mirrors.kernel.org. [147.75.80.249]) by mx.google.com with ESMTPS id au2-20020a170907092200b00a43c3c4a24esi381992ejc.330.2024.02.29.01.16.22 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 01:16:22 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto+bounces-2385-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249; Authentication-Results: mx.google.com; arc=pass (i=1); spf=pass (google.com: domain of linux-crypto+bounces-2385-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) smtp.mailfrom="linux-crypto+bounces-2385-linux.lists.archive=gmail.com@vger.kernel.org" Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by am.mirrors.kernel.org (Postfix) with ESMTPS id 5C9F91F25B03 for ; Thu, 29 Feb 2024 09:16:22 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 33D3D5811C; Thu, 29 Feb 2024 09:16:16 +0000 (UTC) X-Original-To: linux-crypto@vger.kernel.org Received: from bmailout2.hostsharing.net (bmailout2.hostsharing.net [83.223.78.240]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D6FC05810D; Thu, 29 Feb 2024 09:16:12 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=83.223.78.240 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709198176; cv=none; b=Ry7H8S94+uGv9+cMp2oOh/3Niz5v3tlwmpw27rRFLZ4Nhwjjxg2HdqwyZvPGUjYGesX9L2M77gQtRUaaoU1QRV5VzBSjg5jO9RHo15VnvbIA/0vexyFPA++CxvY/uy9gIdGjytZ9+il+WzjP9ypLsOpouINEcDi7kfkwE48fAyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709198176; c=relaxed/simple; bh=OwlEVOXrS4FMp9zxgvm2qrOTH6eutcMS+NUEYXAQmNo=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=S6WvF7xHtC0zRtJD0igVYsvm1OtVEW4HriM8UCOOQww13ZMAiUmc0kf6P4JoYDqOSsbS7Bpm/KdazmjUynhpXwtNm47vJpKJKi/Tbu66hGpuc+3zG6PSdPMavUSZdTa87EM40N5KtS+kSu4VSNxcCbalQFGOO4aIFT7TA8JT5vk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de; spf=none smtp.mailfrom=h08.hostsharing.net; arc=none smtp.client-ip=83.223.78.240 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=wunner.de Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=h08.hostsharing.net Received: from h08.hostsharing.net (h08.hostsharing.net [83.223.95.28]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "*.hostsharing.net", Issuer "RapidSSL TLS RSA CA G1" (verified OK)) by bmailout2.hostsharing.net (Postfix) with ESMTPS id 6C18D2800E5C9; Thu, 29 Feb 2024 10:16:05 +0100 (CET) Received: by h08.hostsharing.net (Postfix, from userid 100393) id 5FD6052247B; Thu, 29 Feb 2024 10:16:05 +0100 (CET) Date: Thu, 29 Feb 2024 10:16:05 +0100 From: Lukas Wunner To: Stefan Berger Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au, davem@davemloft.net, linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br Subject: Re: [PATCH v3 02/10] crypto: ecdsa - Adjust tests on length of key parameters Message-ID: <20240229091605.GA11866@wunner.de> References: <20240223204149.4055630-1-stefanb@linux.ibm.com> <20240223204149.4055630-3-stefanb@linux.ibm.com> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240223204149.4055630-3-stefanb@linux.ibm.com> User-Agent: Mutt/1.10.1 (2018-07-13) On Fri, Feb 23, 2024 at 03:41:41PM -0500, Stefan Berger wrote: > @@ -239,7 +239,7 @@ static int ecdsa_set_pub_key(struct crypto_akcipher *tfm, const void *key, unsig > keylen--; > digitlen = keylen >> 1; > > - ndigits = digitlen / sizeof(u64); > + ndigits = DIV_ROUND_UP(digitlen, sizeof(u64)); > if (ndigits != ctx->curve->g.ndigits) > return -EINVAL; This deletes a line inserted by the preceding patch in the series. I'd prefer just squashing the two patches together. Thanks, Lukas