Received-SPF: pass (google.com: domain of linux-crypto+bounces-2386-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1;
From: Akhil R <akhilrajeev@nvidia.com>
To: "herbert@gondor.apana.org.au" <herbert@gondor.apana.org.au>,
	"davem@davemloft.net" <davem@davemloft.net>, "robh+dt@kernel.org"
	<robh+dt@kernel.org>, "krzysztof.kozlowski+dt@linaro.org"
	<krzysztof.kozlowski+dt@linaro.org>, "conor+dt@kernel.org"
	<conor+dt@kernel.org>, "thierry.reding@gmail.com" <thierry.reding@gmail.com>,
	Jon Hunter <jonathanh@nvidia.com>, "catalin.marinas@arm.com"
	<catalin.marinas@arm.com>, "will@kernel.org" <will@kernel.org>, Mikko
 Perttunen <mperttunen@nvidia.com>, "linux-crypto@vger.kernel.org"
	<linux-crypto@vger.kernel.org>, "devicetree@vger.kernel.org"
	<devicetree@vger.kernel.org>, "linux-tegra@vger.kernel.org"
	<linux-tegra@vger.kernel.org>, "linux-kernel@vger.kernel.org"
	<linux-kernel@vger.kernel.org>, "krzk@kernel.org" <krzk@kernel.org>
Subject: RE: [PATCH v5 3/5] crypto: tegra: Add Tegra Security Engine driver
Thread-Topic: [PATCH v5 3/5] crypto: tegra: Add Tegra Security Engine driver
Thread-Index: AQHaY1jZwFltH5yLb0OQSiEEFOMbgrEhGKTA
Date: Thu, 29 Feb 2024 09:20:48 +0000
Message-ID:
 <SJ1PR12MB63392983F30CA57CBCB69B93C05F2@SJ1PR12MB6339.namprd12.prod.outlook.com>
References: <20240219172530.20517-1-akhilrajeev@nvidia.com>
 <20240219172530.20517-4-akhilrajeev@nvidia.com>
In-Reply-To: <20240219172530.20517-4-akhilrajeev@nvidia.com>
Accept-Language: en-IN, en-US
Content-Language: en-US
x-ms-exchange-antispam-messagedata-chunkcount: 1
x-ms-exchange-antispam-messagedata-0:
 =?us-ascii?Q?NuJ4MohulrynnFKdJF/RTh9WxnoARwZ8UwSsBAQGOSuQBg+002hnIkIO97ni?=
 =?us-ascii?Q?ASICspQUiTcNJE106UtloZjR9rQiMYSag814pFGYswEZyac402777B5wVmbZ?=
 =?us-ascii?Q?zgVR1td7EpNTZkhS9Rf9LmPoScEu6OeFt1xMrS59AZfpSpoQ0Xt0J35doiq7?=
 =?us-ascii?Q?vd4kGR49g+QzNwdE9mv1xOvRqafCBYRfo1HdDrYBtMprnG2VHGGi22/iILWI?=
 =?us-ascii?Q?+O4c+FU39483wrw/ORsqkwKapC/hN7vA62PZlcJqctlO1ejY42sybkKyQM44?=
 =?us-ascii?Q?LQPUO6PzhERN+h7IHiJQqgYO+8ZRegWjSI5Y4SYkgZaWlSKqs+1gH8Mr5fCq?=
 =?us-ascii?Q?MapRXhXUQL8eLIOEE/9kQewWp8Fsf382T2eEX3dCCFzb4sGZ8tDlrabfjwu7?=
 =?us-ascii?Q?D8XCvq8tb3tXVMIOnuncsqZhM5OSFo0bH6IupP+AozY19E4Ugmvdux3EQ4iw?=
 =?us-ascii?Q?6Aukct+FAex+yulxKDWL6eHnKqMOMn24f/GgSs/DTSiokvXRFbbKvzgLodyu?=
 =?us-ascii?Q?+iwq7Nhywu76HxRh1f6xSSsf8WhN0m/ftqipzs6fJELVVIcmbvymrWoIt8HW?=
 =?us-ascii?Q?mVS3zqSRdJ97w3ONMUg+B1rFNviNbaAS5hdB3zwgzio2rSjR4gYrrQX67q8K?=
 =?us-ascii?Q?EXp3GRrpQqVHQ0wA6oLvZUajuqzYepUM8YQ71MYSkJhWxWrKWjalfbaV2YHw?=
 =?us-ascii?Q?ztcmHZQSsPqiFCKyg388Ghv+pstJmvb4k+ys2SUQmcgwd7homwsFHMmXolyy?=
 =?us-ascii?Q?5ba8+tjyYuHnYZQvhOy9GH6We+UaLbK+9UxqQfBcfEJn0Rwt6T8gkYpvlWt9?=
 =?us-ascii?Q?wwTq+325pJZl2NsQf+DdOFMpgcz/whHi3sGE23f7axlIyAoUE7nAhQ73v+Jd?=
 =?us-ascii?Q?nfHPnOH+x1qCl6CKmLi48d8kS2+MEmjt6DAX5G4OXB0LlBMqq8pVE2yAnVY7?=
 =?us-ascii?Q?tAEGkfituKeRq8ViRlxybVElGVswXurQ9Trp1+z4GDuENznH8NjiabWfUYFs?=
 =?us-ascii?Q?0cWVM6u9HgW5gGSfVBPfdScx3cnoJnAF3QYxAjH6sTX86wuHn0uTHXxM1JPS?=
 =?us-ascii?Q?XKRptsnjnkc63ASa7vgmF9ZOlEmMbJDr4UoZRzAg4aWB/tpG/CcDiVj8JWCb?=
 =?us-ascii?Q?AOw+miKz8YmwKIsdgrxmYhZTTT1DPjXj3XU9aPyIWPLThF804OGkObNJznLP?=
 =?us-ascii?Q?+EfhHwHZoW4r4PV7ARbAl4lLOlbpSCbvMeB9K+83EixjyeqODZZlODD/7MJM?=
 =?us-ascii?Q?HH1kWNh28DSuPCMe5RXbh2jUK1toa+TfHscQ9j/+Io+KRoSJ4RZ86xSe0du4?=
 =?us-ascii?Q?eM6LzPNJDGYLtctmFwjo/cH8HntaiIFfRE3oaAg1vXT+MgO3vzVDuiRBqSOR?=
 =?us-ascii?Q?UFIbJ+sMhgGNkZ/5ebVB/+0MmMxDR3osXgUZjZ3/ZnOV7cOmabTggx24wNuX?=
 =?us-ascii?Q?hJCbyVzHBw4vHvSEqr7AlS88Zl7cd2Hsk0+XBJ3h7fLvc8SAe7WjY0MOB5i/?=
 =?us-ascii?Q?38NKLSfPuya6id6RvF3cJEhc6MsTTKDlUxTYFGn1xq4CQjskdwD6xA40Q6u2?=
 =?us-ascii?Q?H/ytxyNhXl2zRcj56iw6Yc6uV1lt68IKLporUqHM?=
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
Precedence: bulk
X-Mailing-List: linux-crypto@vger.kernel.org
List-Id: <linux-crypto.vger.kernel.org>
List-Subscribe: <mailto:linux-crypto+subscribe@vger.kernel.org>
List-Unsubscribe: <mailto:linux-crypto+unsubscribe@vger.kernel.org>
MIME-Version: 1.0
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-AuthSource: SJ1PR12MB6339.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-Network-Message-Id: a6119b04-104c-42f1-49f2-08dc3907b738
X-MS-Exchange-CrossTenant-originalarrivaltime: 29 Feb 2024 09:20:48.0992
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-mailboxtype: HOSTED
X-MS-Exchange-CrossTenant-userprincipalname: mcLDWomfSjIIU4oUFkGi0qPq7qoDxUydD/caa7r/M5oTIA/HElsaWThcsSn4I7S2XMXdKKSfw23bfW3oUJxCXQ==
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB7501

> +
> +static int tegra_sha_export(struct ahash_request *req, void *out)
> +{
> +	struct tegra_sha_reqctx *rctx =3D ahash_request_ctx(req);
> +	struct crypto_ahash *tfm =3D crypto_ahash_reqtfm(req);
> +	struct tegra_sha_ctx *ctx =3D crypto_ahash_ctx(tfm);
> +	int i;
> +
> +	if (ctx->fallback)
> +		return tegra_sha_fallback_export(req, out);
> +
> +	memcpy(out, rctx, sizeof(*rctx));
> +
> +	return 0;
> +}
> +
> +static int tegra_sha_import(struct ahash_request *req, const void *in)
> +{
> +	struct tegra_sha_reqctx *rctx =3D ahash_request_ctx(req);
> +	struct crypto_ahash *tfm =3D crypto_ahash_reqtfm(req);
> +	struct tegra_sha_ctx *ctx =3D crypto_ahash_ctx(tfm);
> +	int i;
Got a warning from testbot for an unused variable here as well as in the ex=
port()
function. I will fix that in the next revision.

Do we have any other concerns with the driver currently, which I can addres=
s
in the next revision?

Regards,
Akhil