Received-SPF: pass (google.com: domain of linux-crypto+bounces-2401-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <88b7574d-c9eb-47c2-928b-e9e19ba7835d@linux.ibm.com>
Date: Thu, 29 Feb 2024 12:20:08 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 01/10] crypto: ecdsa - Convert byte arrays with key
 coordinates to digits
Content-Language: en-US
To: Lukas Wunner <lukas@wunner.de>
Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
        herbert@gondor.apana.org.au, davem@davemloft.net,
        linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br
References: <20240223204149.4055630-1-stefanb@linux.ibm.com>
 <20240223204149.4055630-2-stefanb@linux.ibm.com>
 <20240229091105.GA29363@wunner.de>
 <aabeec7b-618c-4d15-b033-4162b6e54f6a@linux.ibm.com>
 <20240229164810.GA7144@wunner.de>
From: Stefan Berger <stefanb@linux.ibm.com>
In-Reply-To: <20240229164810.GA7144@wunner.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2/29/24 11:48, Lukas Wunner wrote:
> On Thu, Feb 29, 2024 at 09:57:30AM -0500, Stefan Berger wrote:
>> static inline void ecc_digits_from_bytes(const u8 *in, unsigned int nbytes,
>>                                           u64 *out, unsigned int ndigits)
>> {
>>          unsigned int o = nbytes & 7;
>>          u64 msd = 0;
>>          size_t i;
>>
>>          if (o == 0) {
>>                  ecc_swap_digits(in, out, ndigits);
>>          } else {
>>                  for (i = 0; i < o; i++)
>>                          msd = (msd << 8) | in[i];
>>                  out[ndigits - 1] = msd;
>>                  ecc_swap_digits(&in[o], out, ndigits - 1);
>>          }
>> }
> 
> Might be beneficial to add a code comment explaining the else-branch
> is for curves with key length not a multiple of 64 bits (such as NIST P521).

Will do. I am also using this here now since it's safer: 
ecc_swap_digits(&in[o], out, (nbytes - o) >> 3);

    Stefan

> 
> Otherwise LGTM, thanks!
> 
> Lukas