Received-SPF: pass (google.com: domain of linux-crypto+bounces-2405-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Message-ID: <bd4f59d7-5633-4259-83b2-97fe28ee2610@linux.ibm.com>
Date: Thu, 29 Feb 2024 15:29:34 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v3 06/10] crypte: ecc - Implement ecc_curve_get_nbits to
 get number of bits
Content-Language: en-US
To: Lukas Wunner <lukas@wunner.de>
Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
        herbert@gondor.apana.org.au, davem@davemloft.net,
        linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br
References: <20240223204149.4055630-1-stefanb@linux.ibm.com>
 <20240223204149.4055630-7-stefanb@linux.ibm.com>
 <20240227201552.GA32765@wunner.de>
From: Stefan Berger <stefanb@linux.ibm.com>
In-Reply-To: <20240227201552.GA32765@wunner.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 2/27/24 15:15, Lukas Wunner wrote:
> On Fri, Feb 23, 2024 at 03:41:45PM -0500, Stefan Berger wrote:
>> --- a/include/crypto/internal/ecc.h
>> +++ b/include/crypto/internal/ecc.h
>> @@ -75,6 +75,17 @@ static inline void ecc_digits_from_bytes(const u8 *in, unsigned int nbytes,
>>   	ecc_swap_digits(tmp, out, ndigits);
>>   }
>>   
>> +/**
>> + * ecc_curve_get_nbits() - Get the number of bits of the curve
>> + * @curve:    The curve
>> + */
>> +static inline unsigned int ecc_curve_get_nbits(const struct ecc_curve *curve)
>> +{
>> +	if (curve->nbits)
>> +		return curve->nbits;
>> +	return curve->g.ndigits << ECC_DIGITS_TO_BYTES_SHIFT * 8;
>> +}
> 
> Since you're amending struct ecc_curve with an extra nbits value anyway,
> why not statically fill it in for all curves, instead of adding this
> extra complexity in the code?

I filled in all curves now, including ecrdsa cruves and curve25519.

    Stefan

> 
> Thanks,
> 
> Lukas