Received: by 2002:a05:7208:13ce:b0:7f:395a:35b6 with SMTP id r14csp368547rbe; Thu, 29 Feb 2024 01:48:26 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCUtN2Lm+tRqzkhStun6P6NHh1OQBpOkJJSW0VKG4KW0te2NLz0mYe+8XIwJfeJ8dA7aJs+6j/rw5K2LIrXUKW++medNTYw5SKY9+Gt3pg== X-Google-Smtp-Source: AGHT+IG+s7o0wwQAoVqg7Ohp0siGDFPVmfzyLVTCPewJ9FrGrD0Tjeas2tgiQSnygtAUcpBnFwNi X-Received: by 2002:a17:90b:156:b0:29a:e05f:3f55 with SMTP id em22-20020a17090b015600b0029ae05f3f55mr1600201pjb.2.1709200106388; Thu, 29 Feb 2024 01:48:26 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1709200106; cv=pass; d=google.com; s=arc-20160816; b=eneTbVKxW1Nsn+Z8nAYXoySTd5tnraqoZ8j9e+kQxDfc5jKJHzWDgc6XiZ8CGiDl9+ npvUosbYAGrT0i/3tyl+/Fu8rq3tXNRi5Jp3pA4U8Wpz0r82fGWgCoOgkoaTmA1LTOtx v6qKidNh+h0SdBIVcVoX94mI5pn0LCsdp6pAj2vqx8Is0jgnUbmfOwT+44EQ0a5ECFvh kWvZ6tEr82UiZ6K4E+Cc55StdCQqck7zLX53f+zcfEfjcVhriwBUM6lGIprL/Tlw28SR xx8HDe9F5uar1NkUDnl6AxW0l9TfPTbmiHUpyUr1OjigPkp/UeR6e+dCPrAYrAdNeyY/ fTkg== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=YExKJpRBpSGCnSTnvPO1rU9FE9K5FJWDqsJ85fiyKjY=; fh=euXsDJUsyRC6AWl9JkA21/kdbCo769bcYIWlERE5qLI=; b=H91pEUyLuzuV/EvoYkijIOXy45QBkyRfK5hN1xK2Pg3ZiMH2oQo2aS/qRB1PP1GJqJ AGB/anARJjKKtgBbjkUD1vrJaXucthkxW4Ir3JI9RRriocRVLx/RLY3D7WXq28EM278Y sbAIKnkLlxrNbvcHomq2V6Zw4G4O39sUB3F0HcR/f4ZTwPIi9pDvHRFJqWzPHnAzUwAF KSbQ73s/MTOdBaS4moLYosZdEObZTscDl3o92rkM8mCqFDlXXk3UTWGOhpF25746yKzH eJKLhjhuRp7uNXcduqJqYKGBKqEBu9eTP79Mr+iG7sNSAMfAUYkj5/oqexp6QxmdARZ5 ho6A==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gondor.apana.org.au dmarc=pass fromdomain=gondor.apana.org.au); spf=pass (google.com: domain of linux-crypto+bounces-2388-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-crypto+bounces-2388-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=REJECT sp=QUARANTINE dis=QUARANTINE) header.from=apana.org.au Return-Path: Received: from sv.mirrors.kernel.org (sv.mirrors.kernel.org. [139.178.88.99]) by mx.google.com with ESMTPS id np4-20020a17090b4c4400b0029af707b480si1198905pjb.16.2024.02.29.01.48.26 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 29 Feb 2024 01:48:26 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto+bounces-2388-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gondor.apana.org.au dmarc=pass fromdomain=gondor.apana.org.au); spf=pass (google.com: domain of linux-crypto+bounces-2388-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) smtp.mailfrom="linux-crypto+bounces-2388-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=REJECT sp=QUARANTINE dis=QUARANTINE) header.from=apana.org.au Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sv.mirrors.kernel.org (Postfix) with ESMTPS id 5908928DC55 for ; Thu, 29 Feb 2024 09:45:40 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 70786626B4; Thu, 29 Feb 2024 09:45:00 +0000 (UTC) X-Original-To: linux-crypto@vger.kernel.org Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1570562167; Thu, 29 Feb 2024 09:44:55 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=144.6.53.87 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709199900; cv=none; b=tMEYNOMPKRaHaENYX2tmXcX2OJcvEzMryMI9z39TqI3X7sOfqHH6bMCFDsJQsliBDuMNFm0tLIFM742BrHuY+O8yC9d5sm4SolfZUcRUcOitaLLdJWvO1eRTS2ZvZwUYEgbQiU0hF+AL7X73U5bYAxKx1zLTnqS2HM4fskXulyM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1709199900; c=relaxed/simple; bh=LRJVFzBwH7MuVtq2csaTPRAM3cjLsMOfo43jLit+25Q=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=QfqUW0oJAvGh5vomtFDJo+i9PTMXLGAIW5HflM4LMD9JQxIXBKC9gbzhQGhqg8b3UXikl/rRsoqKiit+RGBfkRD0g6ZWxQHTAlZC9d/srR9coKPFcfg7zwVHVEJpjHJjcqFlbTVJhoevmARrxsfV4mXxQ0E7xCWjDgsVZR8XMag= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au; spf=pass smtp.mailfrom=gondor.apana.org.au; arc=none smtp.client-ip=144.6.53.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gondor.apana.org.au Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1rfcxv-001mAd-8M; Thu, 29 Feb 2024 17:44:36 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Thu, 29 Feb 2024 17:44:50 +0800 Date: Thu, 29 Feb 2024 17:44:50 +0800 From: Herbert Xu To: Akhil R Cc: "davem@davemloft.net" , "robh+dt@kernel.org" , "krzysztof.kozlowski+dt@linaro.org" , "conor+dt@kernel.org" , "thierry.reding@gmail.com" , Jon Hunter , "catalin.marinas@arm.com" , "will@kernel.org" , Mikko Perttunen , "linux-crypto@vger.kernel.org" , "devicetree@vger.kernel.org" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "krzk@kernel.org" Subject: Re: [PATCH v5 3/5] crypto: tegra: Add Tegra Security Engine driver Message-ID: References: <20240219172530.20517-1-akhilrajeev@nvidia.com> <20240219172530.20517-4-akhilrajeev@nvidia.com> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Thu, Feb 29, 2024 at 09:20:48AM +0000, Akhil R wrote: > > Do we have any other concerns with the driver currently, which I can address > in the next revision? The sha export/import code looks good now. Does it pass all the self-tests, including extra fuzzing? The same export/import issue still exists with cmac so please fix that. Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt