Received: by 2002:a05:7208:9594:b0:7e:5202:c8b4 with SMTP id gs20csp176421rbb; Fri, 23 Feb 2024 16:51:21 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVHwKKmoCZo45YunwSqukFMcHBNCv8HG89Lk3JYuqsEuIrrpmGHB0xyN/eGPSzL3BR3SU1Wbv5BiCPh3YFDqV9jZwQsUmfrLuKH8lG90w== X-Google-Smtp-Source: AGHT+IF6mTVL7Hnc+RuQvA+7QoUxCa/77bJWQSmhoth1gVe+phoSn0b6/l28B+0CKWjof1BMDpwj X-Received: by 2002:a05:6a00:9396:b0:6e4:eac1:894a with SMTP id ka22-20020a056a00939600b006e4eac1894amr1740961pfb.18.1708735881715; Fri, 23 Feb 2024 16:51:21 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1708735881; cv=pass; d=google.com; s=arc-20160816; b=WLrCUSkhptbwlRDWU+gf1u9IKTsnumvY6Negm1ByBFu8RarK4XJDDU9XYRmScrRmGC 7NNnmygsSkYsTB9P7/cANyFQyCxu9r/vKeROSgCJjNJBVYkZuRG26ASgtknyLVR8arZP zMZoQftnPsJ/FN13zvD2ZOpGMSwS0zut6So1rB1II3m86TZ7CD5VBdW3W7fg+kRYPl1t zFIIfCa7sjnkTCqr8Fh/dEvXt/Y4BnzI6/Vt5RwAdLActpdtpwECwqVf+Nbdgc3OBs9z LJAhVSXNV56NJ6z9Rifzc6IyNhgshd5Dxnj2y8C1gr1229Qps3psRFm/zHFsaI5zE402 52hQ== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=in-reply-to:content-disposition:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:message-id:subject:cc :to:from:date; bh=KHLPvIC9QxjKBUhMuLDMWTljPZsXJz5pkIvE4EfG0sU=; fh=286IVnJxmA87nrPZfpCuBZG2TGQZn80/91cSvMqKxPc=; b=nx0DJ/4Eyg/P4AJ8Nag9fdcp9xW3iCMEvjSRlGKLyujxgiv4PW94NgACmTGnYDYhz+ ExRiwGFGSINBgGyEgU3hheSpA4mdmHkaRBQDTuP87EcKoDRTwWi2tQjm3mY8yi7ucgD7 SpxvQTr7fjc9VRmeUJMgeVHfmzz+2+ZN9T04Szq3VE50vhWyvQ5b6sldnKLjhyvQwyV2 hCP0inX+b9hx/Qfpdk/6WpeVOqEVTgEDOOhmut+HKUcdF5j1YrOuSE5KbUh+o7FHS79D R+z5iJzTXaUO8y1xgVN9B3yJZHVi8zNKUrf+8aNk+pVdNrya6BKxqNfL9cf0ml60yrX9 NgHw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; arc=pass (i=1 spf=pass spfdomain=gondor.apana.org.au dmarc=pass fromdomain=gondor.apana.org.au); spf=pass (google.com: domain of linux-crypto+bounces-2298-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-crypto+bounces-2298-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=REJECT sp=QUARANTINE dis=NONE) header.from=apana.org.au Return-Path: Received: from sy.mirrors.kernel.org (sy.mirrors.kernel.org. [147.75.48.161]) by mx.google.com with ESMTPS id f8-20020a056a001ac800b006dffc180954si103872pfv.398.2024.02.23.16.51.21 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 23 Feb 2024 16:51:21 -0800 (PST) Received-SPF: pass (google.com: domain of linux-crypto+bounces-2298-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) client-ip=147.75.48.161; Authentication-Results: mx.google.com; arc=pass (i=1 spf=pass spfdomain=gondor.apana.org.au dmarc=pass fromdomain=gondor.apana.org.au); spf=pass (google.com: domain of linux-crypto+bounces-2298-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.48.161 as permitted sender) smtp.mailfrom="linux-crypto+bounces-2298-linux.lists.archive=gmail.com@vger.kernel.org"; dmarc=fail (p=REJECT sp=QUARANTINE dis=NONE) header.from=apana.org.au Received: from smtp.subspace.kernel.org (wormhole.subspace.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by sy.mirrors.kernel.org (Postfix) with ESMTPS id D1D38B20B89 for ; Sat, 24 Feb 2024 00:51:15 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id B6246138A; Sat, 24 Feb 2024 00:51:10 +0000 (UTC) X-Original-To: linux-crypto@vger.kernel.org Received: from abb.hmeau.com (abb.hmeau.com [144.6.53.87]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id C939D1864 for ; Sat, 24 Feb 2024 00:51:08 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=144.6.53.87 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708735870; cv=none; b=eR8pqEu4m4xfIsaKWjJexBiWxGjfLbp6ZkE4bQJVvDUbgclxrCR/9MPqug0J6JhoH9x/j3PkrEz+XWCfx2vncXvmFq6nTlGWO1HICcvE8aaG6g0TXZkzrW5sIyho8ICYbgQJYq9JRkiprllpvOs/tC7VZR0tAiQnqs2vklQb/tA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1708735870; c=relaxed/simple; bh=Tx8QJFbihMA2dtuOXPZCxecF73Op+GYtbHDdV8Pp1+g=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=DJ0vViHvZ3IgQgFOqo9rVsaB0nfxo2tmCEHgTnVr2OfiK6anFY1hPi08YWBal1fkp2pQV2nnlNlrVwPEIjG2IP2Kp/8h3QBuhjzqyRFVFPbFV36FQ1bV39CYz2Ql6MgivAgPkuADn2lX+cQRiRu1+PpOS5Zb2mMvoGEeigSruvs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au; spf=pass smtp.mailfrom=gondor.apana.org.au; arc=none smtp.client-ip=144.6.53.87 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=gondor.apana.org.au Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gondor.apana.org.au Received: from loth.rohan.me.apana.org.au ([192.168.167.2]) by formenos.hmeau.com with smtp (Exim 4.94.2 #2 (Debian)) id 1rdgFs-00HDy8-Ng; Sat, 24 Feb 2024 08:51:05 +0800 Received: by loth.rohan.me.apana.org.au (sSMTP sendmail emulation); Sat, 24 Feb 2024 08:51:19 +0800 Date: Sat, 24 Feb 2024 08:51:19 +0800 From: Herbert Xu To: Adam Guerin Cc: linux-crypto@vger.kernel.org, qat-linux@intel.com Subject: Re: [PATCH 0/6] crypto: qat - fix warnings reported by clang Message-ID: References: <20240216151959.19382-1-adam.guerin@intel.com> Precedence: bulk X-Mailing-List: linux-crypto@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20240216151959.19382-1-adam.guerin@intel.com> On Fri, Feb 16, 2024 at 03:19:54PM +0000, Adam Guerin wrote: > This set fixes a list of warnings found by compiling the QAT driver with > "CC=clang W=2" and with the Clang tool scan-build. > > These fixes include removing unused macros in both adf_cnv_dbgfs.c and > qat_comp_alg.c, fix initialization of multiple variables, check that > delta_us is not 0, and fixing the comment structures in multiple files. > > Adam Guerin (6): > crypto: qat - remove unused macros in qat_comp_alg.c > crypto: qat - removed unused macro in adf_cnv_dbgfs.c > crypto: qat - avoid division by zero > crypto: qat - remove double initialization of value > crypto: qat - remove unnecessary description from comment > crypto: qat - fix comment structure > > drivers/crypto/intel/qat/qat_common/adf_clock.c | 3 +++ > drivers/crypto/intel/qat/qat_common/adf_cnv_dbgfs.c | 1 - > drivers/crypto/intel/qat/qat_common/adf_dev_mgr.c | 4 ++-- > drivers/crypto/intel/qat/qat_common/adf_gen4_ras.c | 6 ++---- > drivers/crypto/intel/qat/qat_common/adf_isr.c | 2 -- > drivers/crypto/intel/qat/qat_common/adf_vf_isr.c | 2 -- > drivers/crypto/intel/qat/qat_common/qat_comp_algs.c | 9 --------- > drivers/crypto/intel/qat/qat_common/qat_crypto.c | 4 ++-- > 8 files changed, 9 insertions(+), 22 deletions(-) > > > base-commit: 7a35f3adf4535a9a56ef7b3e75355806632030ca > -- > 2.40.1 All applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt