Received-SPF: pass (google.com: domain of linux-crypto+bounces-2473-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Message-ID: <8ef01d48-2f42-4764-b256-e5cfd922022c@linux.ibm.com>
Date: Sun, 3 Mar 2024 11:32:17 -0500
Precedence: bulk
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v4 05/12] crypto: ecc - Add nbits field to ecc_curve
 structure
Content-Language: en-US
To: Lukas Wunner <lukas@wunner.de>
Cc: keyrings@vger.kernel.org, linux-crypto@vger.kernel.org,
        herbert@gondor.apana.org.au, davem@davemloft.net,
        linux-kernel@vger.kernel.org, saulo.alessandre@tse.jus.br
References: <20240301022007.344948-1-stefanb@linux.ibm.com>
 <20240301022007.344948-6-stefanb@linux.ibm.com>
 <20240303110705.GB394@wunner.de>
From: Stefan Berger <stefanb@linux.ibm.com>
In-Reply-To: <20240303110705.GB394@wunner.de>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit


On 3/3/24 06:07, Lukas Wunner wrote:
> On Thu, Feb 29, 2024 at 09:20:00PM -0500, Stefan Berger wrote:
>> Add the number of bits a curve has to the ecc_curve definition and set it
>> on all cruve definitions.
> 
> Nit: s/cruve/curve/
> 
> 
>> --- a/include/crypto/ecc_curve.h
>> +++ b/include/crypto/ecc_curve.h
>> @@ -23,6 +23,8 @@ struct ecc_point {
>>    * struct ecc_curve - definition of elliptic curve
>>    *
>>    * @name:	Short name of the curve.
>> + * @nbits:      Curves that do not use all bits in their ndigits must specify
>> + *              their number of bits here, otherwise can leave at 0.
>>    * @g:		Generator point of the curve.
>>    * @p:		Prime number, if Barrett's reduction is used for this curve
>>    *		pre-calculated value 'mu' is appended to the @p after ndigits.
> 
> Nit: Looks like this kernel-doc uses 1 tab instead of blanks.
> 
Fixed.