Received-SPF: pass (google.com: domain of linux-crypto+bounces-2467-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Sat, 2 Mar 2024 22:36:09 +0100
From: Lukas Wunner <lukas@wunner.de>
To: Stefan Berger <stefanb@linux.ibm.com>
Cc: Jarkko Sakkinen <jarkko@kernel.org>, keyrings@vger.kernel.org,
	linux-crypto@vger.kernel.org, herbert@gondor.apana.org.au,
	davem@davemloft.net, linux-kernel@vger.kernel.org,
	saulo.alessandre@tse.jus.br
Subject: Re: [PATCH v3 01/10] crypto: ecdsa - Convert byte arrays with key
 coordinates to digits
Message-ID: <20240302213609.GB30938@wunner.de>
References: <20240223204149.4055630-1-stefanb@linux.ibm.com>
 <20240223204149.4055630-2-stefanb@linux.ibm.com>
 <20240229091105.GA29363@wunner.de>
 <aabeec7b-618c-4d15-b033-4162b6e54f6a@linux.ibm.com>
 <CZIOY02QS2QC.LV0A0HNT7VKM@suppilovahvero>
 <20240302140001.GA3095@wunner.de>
 <f5dacc38-bf53-4dc7-95cf-54b8b13dd1d7@linux.ibm.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <f5dacc38-bf53-4dc7-95cf-54b8b13dd1d7@linux.ibm.com>
User-Agent: Mutt/1.10.1 (2018-07-13)

On Sat, Mar 02, 2024 at 04:19:49PM -0500, Stefan Berger wrote:
> On 3/2/24 09:00, Lukas Wunner wrote:
> > Maybe eliminate the for-loop as well?
> > 
> > 	unsigned int o = nbytes & 7;
> > 	u64 msd = 0;
> > 
> > 	if (o != 0) {
> > 		/* if key length is not a multiple of 64 bits (NIST P521) */
> > 		memcpy((u8 *)&msd + sizeof(msd) - o, in, o);
> > 		out[--ndigits] = be64_to_cpu(msd);
> > 		in += o;
> > 	}
> > 
> > 	ecc_swap_digits(in, out, ndigits);
> 
> Will take this for v5 with your Suggested-by:, ok?

Sure, feel free to, but better test it because I haven't. :-)

I'll look through the rest of the series tomorrow. %-)

Thanks,

Lukas