Received-SPF: pass (google.com: domain of linux-crypto+bounces-2519-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Tue, 5 Mar 2024 20:00:52 -0800
From: Eric Biggers <ebiggers@kernel.org>
To: Pavitrakumar Managutte <pavitrakumarm@vayavyalabs.com>
Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org,
	Ruud.Derwig@synopsys.com, manjunath.hadli@vayavyalabs.com
Subject: Re: [PATCH 0/4] Add spacc crypto driver support
Message-ID: <20240306040052.GB68962@sol.localdomain>
References: <20240305112831.3380896-1-pavitrakumarm@vayavyalabs.com>
 <20240305211318.GA1202@sol.localdomain>
 <CALxtO0kp+vDstePYkq3AYSD-h6LRt1HvRm4HdW-OtTQm5ipqkw@mail.gmail.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CALxtO0kp+vDstePYkq3AYSD-h6LRt1HvRm4HdW-OtTQm5ipqkw@mail.gmail.com>

On Wed, Mar 06, 2024 at 09:16:31AM +0530, Pavitrakumar Managutte wrote:
> > Algorithms that don't have a generic implementation shouldn't be included.
> >
> Hi Eric,
>   Yes we have tested this with CONFIG_CRYPTO_MANAGER_EXTRA_TESTS=y
> 
>   Also is it fine if those additional algos stay inside that disabled
> CONFIG. SPAcc hardware
>   does support those algos.
> 
> - PK
> 

If you provide an option to build them into the driver, that still counts as
them being there.  I think they should just be left out entirely for now.

- Eric