Received-SPF: pass (google.com: domain of linux-crypto+bounces-2524-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:40f1:3f00::1 as permitted sender) client-ip=2604:1380:40f1:3f00::1;
Precedence: bulk
MIME-Version: 1.0
References: <20240305112831.3380896-1-pavitrakumarm@vayavyalabs.com>
 <20240305112831.3380896-3-pavitrakumarm@vayavyalabs.com> <820315ee-eb76-4444-bdad-b1e353cfce48@linux.microsoft.com>
In-Reply-To: <820315ee-eb76-4444-bdad-b1e353cfce48@linux.microsoft.com>
From: Pavitrakumar Managutte <pavitrakumarm@vayavyalabs.com>
Date: Wed, 6 Mar 2024 12:08:12 +0530
Message-ID: <CALxtO0mRevWe8n1Cbc3uO4As4cQBVNJmsdPjusn0ip+p7Wun+w@mail.gmail.com>
Subject: Re: [PATCH 2/4] Add SPACC Kconfig and Makefile
To: Easwar Hariharan <eahariha@linux.microsoft.com>
Cc: herbert@gondor.apana.org.au, linux-crypto@vger.kernel.org, 
	Ruud.Derwig@synopsys.com, manjunath.hadli@vayavyalabs.com, 
	shwetar <shwetar@vayavyalabs.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

Hi Easwar,
   The default will be a module, my bad. I will rectify this in the v1 patc=
h,
   which I am already working on.

- PK

On Wed, Mar 6, 2024 at 11:12=E2=80=AFAM Easwar Hariharan
<eahariha@linux.microsoft.com> wrote:
>
> On 3/5/2024 3:28 AM, Pavitrakumar M wrote:
> > Signed-off-by: shwetar <shwetar@vayavyalabs.com>
> > Signed-off-by: Pavitrakumar M <pavitrakumarm@vayavyalabs.com>
> > Acked-by: Ruud Derwig <Ruud.Derwig@synopsys.com>
> > ---
> >  drivers/crypto/dwc-spacc/Kconfig  | 95 +++++++++++++++++++++++++++++++
> >  drivers/crypto/dwc-spacc/Makefile | 16 ++++++
> >  2 files changed, 111 insertions(+)
> >  create mode 100644 drivers/crypto/dwc-spacc/Kconfig
> >  create mode 100644 drivers/crypto/dwc-spacc/Makefile
> >
> > diff --git a/drivers/crypto/dwc-spacc/Kconfig b/drivers/crypto/dwc-spac=
c/Kconfig
> > new file mode 100644
> > index 000000000000..6f40358f7932
> > --- /dev/null
> > +++ b/drivers/crypto/dwc-spacc/Kconfig
> > @@ -0,0 +1,95 @@
> > +# SPDX-License-Identifier: GPL-2.0-only
> > +
> > +config CRYPTO_DEV_SPACC
> > +     tristate "Support for dw_spacc Security protocol accelerators"
> > +     depends on HAS_DMA
> > +     default y
>
> <snip>
>
> Why is the default y rather than n or m? I would prefer it to be a module=
, but I just want
> to understand why it was chosen to be default compiled in.
>
> Thanks,
> Easwar
>