Received-SPF: pass (google.com: domain of linux-crypto+bounces-2589-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:45e3:2400::1 as permitted sender) client-ip=2604:1380:45e3:2400::1;
Date: Fri, 8 Mar 2024 12:52:32 -0400
From: Jason Gunthorpe <jgg@nvidia.com>
To: Xin Zeng <xin.zeng@intel.com>
Cc: herbert@gondor.apana.org.au, alex.williamson@redhat.com,
	yishaih@nvidia.com, shameerali.kolothum.thodi@huawei.com,
	kevin.tian@intel.com, linux-crypto@vger.kernel.org,
	kvm@vger.kernel.org, qat-linux@intel.com
Subject: Re: [PATCH v5 08/10] crypto: qat - add interface for live migration
Message-ID: <20240308165232.GU9179@nvidia.com>
References: <20240306135855.4123535-1-xin.zeng@intel.com>
 <20240306135855.4123535-9-xin.zeng@intel.com>
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20240306135855.4123535-9-xin.zeng@intel.com>
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0:
	=?us-ascii?Q?VTpKBRNgDw61b5fOn/1kvkMT68ogEcqXmCwPJwyutAiP2yZRFwygP5TjqoTY?=
 =?us-ascii?Q?7wL/6Ny/p8bChP6sH5IPzbk+H5lr23/LGV/L3Q3bE8OgEf+tFny7rl/NLiGq?=
 =?us-ascii?Q?TrgWrvFjo5G9Xxkti8JaU95ZPj2We2Le5y5/B8BHrzSDPyutDMEkbsuKW+d5?=
 =?us-ascii?Q?zIFeI/YULD9TmV5DXNPg5jr6Y6s1+R3LFAfoaLjM3GH/HBRaV5ooz+a6o6JL?=
 =?us-ascii?Q?fAFBK/7xez/j+76jBP93tzZjsk1PEgv3+n5U2W5XjVDr7q/IdXqYbSAJ7LyG?=
 =?us-ascii?Q?W/6oqD44ydcaoY06s9O48u7y4ZsLW9qAMRm8VcZ0OZMcLjA+ulJsWdF9YJal?=
 =?us-ascii?Q?gbp39utt/dhwiwr6eby2AE8L7M8RuypCzoGHUD0IXoynT9lu0gTVu5f3PdU7?=
 =?us-ascii?Q?UhZZ8PxepA/f3E3jUQHIfTXrE1hym5qOI6E6nXmqgL6Rm61Kl+fkxLpE+opJ?=
 =?us-ascii?Q?qhclrbJonXIDGiXRVKPYJiyGgPNkHGPBGtMvtR4UbgJdcAeoVgy+Eg9OPKIJ?=
 =?us-ascii?Q?KLu/iuGq3DTmqik51rg03f9beMC6jOWpuM7fs8G7smgwm8ka8Gds8wNLqTxF?=
 =?us-ascii?Q?gg8HHemU1XkiOuAL57z4dV6bi7L2iWjmReYIon0lgEHyW18pZn/O/V7wWyOJ?=
 =?us-ascii?Q?2WFMolufIn0OnvaJaSKSt8ozLXr7sxIKBILnfJrk5N8MWSNJMlJ+9GRJ00GO?=
 =?us-ascii?Q?I50PXwJJpYS1wxbNSoCXkg38KDdIJO11GYOoA/RBZjTvNOjcJdBoVQ9hqlW3?=
 =?us-ascii?Q?A6du0PyhrH5J8cigteTafLGOmpY3NEYeish4FBqznNz0fmvq9kIJQW0lx5vu?=
 =?us-ascii?Q?2DdRoKkuktuioYq/nZVq8RNsD4qoe9G2TW7UGz7/sMw3vzRlhYdqL3GU3jZp?=
 =?us-ascii?Q?QSgxmXeuLzOJY1+/CrJi3nkVHTD9Qpi2ziIdHu7Lv5XrRUJS3b0YE6KnsWlI?=
 =?us-ascii?Q?R5voHfBjH0yFGwhOfibwtqWy0kATYY1fsp9AhNjMzLabitdA8TRG0eQHgdI6?=
 =?us-ascii?Q?Ufg7xCEo/1ao5XVgoqHruzZSevDCbSoIl0lTcfvTlZq5JL589eC4e5ZftkmX?=
 =?us-ascii?Q?EQpJRZOThGsuV+KDHOJOd8UfB07pcDVbCXfJ7rhsaj/3lhfjVHT76uhMdJP0?=
 =?us-ascii?Q?RXx39rJC0sx9lGOeFutVtEVfN7MaW46SndUR6iw7pKKB2GnnOzo+ARqp8XK9?=
 =?us-ascii?Q?QWR41riCILpKQsW/MRunGePH4PmSE1nzDUh+GaQQ3izanTr19RlGNqsDvbax?=
 =?us-ascii?Q?IBV8BVE5pkzkOamhmNdDFyPy+Ks/hb1DI7+gFNR3Kj3MEhkjy4g2kXLs48wN?=
 =?us-ascii?Q?ZuK8XKB0QHWM35LveXvuBbhxA2QOkR5eNE5HheTqrrwabteLKu9q38IfQQU5?=
 =?us-ascii?Q?t4aT77OhDKLvJRKqPHQC5203LcZg/CaA/pj6sEx452V9f6Bgy+7ToQc5uT4a?=
 =?us-ascii?Q?UmJxAPGkfcjho+5I1W/J7/EDZBHj6KvSCsIWwJ6VAUPLyQVDPygLrwvMziFn?=
 =?us-ascii?Q?zupLemhStTHI9Dw3+yplJ1Q45iyeGsPlWs8vesrXAziQ0doWZ54LsfonKHOq?=
 =?us-ascii?Q?7+WwmfLGyCEu+udszUoZs/WZ5S1rSjocewGQCp7w?=
X-OriginatorOrg: Nvidia.com
X-MS-Exchange-CrossTenant-Network-Message-Id: d4d9d062-d8b5-420a-1379-08dc3f9026fc
X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB3849.namprd12.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 08 Mar 2024 16:52:34.4639
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: VrVOKEmN2REhKZqt0sUu/Vt4dAaziiFIxzP3W//DYt4ZhCJtRN/b5cjkt3CuK77E
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN7PR12MB8004

On Wed, Mar 06, 2024 at 09:58:53PM +0800, Xin Zeng wrote:
> @@ -258,6 +259,20 @@ struct adf_dc_ops {
>  	void (*build_deflate_ctx)(void *ctx);
>  };
>  
> +struct qat_migdev_ops {
> +	int (*init)(struct qat_mig_dev *mdev);
> +	void (*cleanup)(struct qat_mig_dev *mdev);
> +	void (*reset)(struct qat_mig_dev *mdev);
> +	int (*open)(struct qat_mig_dev *mdev);
> +	void (*close)(struct qat_mig_dev *mdev);
> +	int (*suspend)(struct qat_mig_dev *mdev);
> +	int (*resume)(struct qat_mig_dev *mdev);
> +	int (*save_state)(struct qat_mig_dev *mdev);
> +	int (*save_setup)(struct qat_mig_dev *mdev);
> +	int (*load_state)(struct qat_mig_dev *mdev);
> +	int (*load_setup)(struct qat_mig_dev *mdev, int size);
> +};

Why do we still have these ops? There is only one implementation

Jason