Received-SPF: pass (google.com: domain of linux-crypto+bounces-2595-linux.lists.archive=gmail.com@vger.kernel.org designates 139.178.88.99 as permitted sender) client-ip=139.178.88.99;
Precedence: bulk
MIME-Version: 1.0
References: <20240222081135.173040-1-21cnbao@gmail.com> <CAGsJ_4wMGNDcgc3pqSUicYoH7Z_miczkT=uwZU+yhDF0fd57Rg@mail.gmail.com>
 <20240308192334.845b27504a663ec8af4f2aad@linux-foundation.org>
 <CAGsJ_4xSwNZmHN5GvipS-1kELX2NBwHxoGE=aG4sekm1LcYVPw@mail.gmail.com>
 <20240308203641.7fbe7e939b3483bd83b9769d@linux-foundation.org>
 <20240308204251.43d7e518ba95fb4ce22f8d4d@linux-foundation.org> <CAGsJ_4xYUSdEV4N8i3KqNL+dz2kWx3JWgqtMypk0KW539M4SVQ@mail.gmail.com>
In-Reply-To: <CAGsJ_4xYUSdEV4N8i3KqNL+dz2kWx3JWgqtMypk0KW539M4SVQ@mail.gmail.com>
From: Barry Song <21cnbao@gmail.com>
Date: Sat, 9 Mar 2024 13:08:14 +0800
Message-ID: <CAGsJ_4zRM1Epk-OqRmm6ZfB_FA1TyNBtOA=soz_5cZB=_CsrgA@mail.gmail.com>
Subject: Re: [PATCH v6 0/2] zswap: remove the memcpy if acomp is not sleepable
To: Andrew Morton <akpm@linux-foundation.org>
Cc: herbert@gondor.apana.org.au, chriscli@google.com, chrisl@kernel.org, 
	ddstreet@ieee.org, linux-kernel@vger.kernel.org, sjenning@redhat.com, 
	vitaly.wool@konsulko.com, Barry Song <v-songbaohua@oppo.com>, davem@davemloft.net, 
	hannes@cmpxchg.org, linux-crypto@vger.kernel.org, linux-mm@kvack.org, 
	zhouchengming@bytedance.com, nphamcs@gmail.com, yosryahmed@google.com
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, Mar 9, 2024 at 12:56=E2=80=AFPM Barry Song <21cnbao@gmail.com> wrot=
e:
>
> On Sat, Mar 9, 2024 at 12:42=E2=80=AFPM Andrew Morton <akpm@linux-foundat=
ion.org> wrote:
> >
> > On Fri, 8 Mar 2024 20:36:41 -0800 Andrew Morton <akpm@linux-foundation.=
org> wrote:
> >
> > > > Okay, I understand. Since this patch improves zswap's performance, =
I wanted
> > > > it to be integrated sooner to contribute. However, I'm perfectly wi=
lling to
> > > > respect your concerns and adhere to the community's best practices.
> > > >
> > >
> > > OK.  I very much doubt if anyone is running those drivers on mm.git, =
so
> > > adding it now isn't likely to hurt.
> > >
> > > So I'll merge it now and shall aim to get it upstream very late in th=
e
> > > next merge window.
> >
> > Nope.  mm.git won't build without acomp_is_async().
> >
> > We can merge the zswap patch via the crypto tree.  Acked-by: me.
>
> Herbert Acked the acomp_is_async() patch in v5 instead of picking it up
> into crypto:
> https://lore.kernel.org/linux-mm/ZdWKz43tTz2XY4ca@gondor.apana.org.au/

More details: Herbert acked the acomp_is_async in v5 [1], while he requeste=
d
that patch 3/3 of v5 be split from the series and applied by crypto
[2]. Patch 3/3
of v5 can function independently of 1/3 and 2/3, and it has already
been included
in the crypto tree.

That is why v6 has only two left.

[1] https://lore.kernel.org/linux-mm/ZdWKz43tTz2XY4ca@gondor.apana.org.au/
[2] https://lore.kernel.org/linux-mm/ZdWLim6zYSl%2Fx1Bk@gondor.apana.org.au=
/


>
> >
> > Or please just resend the zswap change after 6.9-rc1 is released.

Thanks
Barry