Received-SPF: pass (google.com: domain of linux-crypto+bounces-2614-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 11 Mar 2024 17:57:08 +0000
From: "Cabiddu, Giovanni" <giovanni.cabiddu@intel.com>
To: Jason Gunthorpe <jgg@nvidia.com>
CC: Xin Zeng <xin.zeng@intel.com>, <herbert@gondor.apana.org.au>,
	<alex.williamson@redhat.com>, <yishaih@nvidia.com>,
	<shameerali.kolothum.thodi@huawei.com>, <kevin.tian@intel.com>,
	<linux-crypto@vger.kernel.org>, <kvm@vger.kernel.org>, <qat-linux@intel.com>
Subject: Re: [PATCH v5 08/10] crypto: qat - add interface for live migration
Message-ID: <Ze9F9NSFSnasaN3Y@gcabiddu-mobl.ger.corp.intel.com>
References: <20240306135855.4123535-1-xin.zeng@intel.com>
 <20240306135855.4123535-9-xin.zeng@intel.com>
 <20240308165232.GU9179@nvidia.com>
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20240308165232.GU9179@nvidia.com>
Organization: Intel Research and Development Ireland Ltd - Co. Reg. #308263 -
 Collinstown Industrial Park, Leixlip, County Kildare - Ireland
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?Tqi61FwTYHRL8fPgUVgxos0ADIpciOjXWwCuiHUMFnmvdP2wNG+hExbe4xfS?=
 =?us-ascii?Q?W1budiP/JFbYD+QjAHduC9ViXTwNHGM3MniijFx+cDDevPh+Nhy42HDEqck/?=
 =?us-ascii?Q?7XHc2JBtzWRtaCFFMupqK6fwe7vciO896MGKcB6NO2LFWXRiL/pC6JGf1zH1?=
 =?us-ascii?Q?H4hYseU+bXhlDpbxYaNlROKxFL0zKS1Nb7mT6oHttnU/ubFpu2OsWab6Wxhd?=
 =?us-ascii?Q?2UdkFdFxMCBZNUq8at8xf3y928M5zQMtbQz/5/YxhxAb/BnWLes2DDZn8TPT?=
 =?us-ascii?Q?+JXtKDDXppXd1oGyFMYLZd+IHjZ6k/XEZ3OVZoRKEtRrfan9LsvKexfMFdur?=
 =?us-ascii?Q?LY0C9pW2Qvru7pfpTnrQTjRUx0YNLCQMGaDQ0i6rBIFt1Tl6bG/6qL1UH+HN?=
 =?us-ascii?Q?DQPvonF3hOM1x0QtLoPSrR48o4wkTbEV+eb+BY8BQs6XXrjh48yQLN9cIlLX?=
 =?us-ascii?Q?7zCUBXpRYb6q7mJx/cWTqBF/aWRTZtgsvdPH/mZGUJbZRkiNL7cLUbEpqCdT?=
 =?us-ascii?Q?DTwHLz0OauZCts2Ckrx1uL3DhHQCyDEJOazItXn1hXfqlK/fbyVowtqVQ33U?=
 =?us-ascii?Q?8ej9XIw7XO+J7GrB4h2Z7ns6EcY6BsVZWorIJWHOc2zVHllvTxe3/J8Dum4t?=
 =?us-ascii?Q?hJyRq3T9lGRasSIMK/e79z62pjesKYgcIdeftMYVQL7s6k4TEfK/XxUKZu+m?=
 =?us-ascii?Q?LtOSZWLzzeXS5yQEobc0i4RU9QIhof5zvlStYHeM4K42BPfT7GIvn2/Lh0hb?=
 =?us-ascii?Q?4fcJfVeWG2Tzlnil9SEcxEqFBWIaSkMyrfHEwqE9mROXD4sZyfhWcZ8rwoUJ?=
 =?us-ascii?Q?X0Aq6ahkdFgoqCeOWl+/o3dJPbBwnzNIJ1Xu3Eq2gG9TSiPYMIZbBgM6rcam?=
 =?us-ascii?Q?RoGVXaaYhJa0NSJkIAYW9Y2cWxzFuBk7gxvEbISq1wWbRKb/cEMx2e/yp4WG?=
 =?us-ascii?Q?IIWtZjz1U0hdGMqAGT72ts+5AtkW6AiVjtOIyyu5HSDK8iZjm8CxPa8HO8DE?=
 =?us-ascii?Q?GkwF/roNRa35p3DMoPIT4gz2seYR2kjbd9Wh3BeRtii/rBE3domtKc49yIUF?=
 =?us-ascii?Q?hD4vXVMp7x2Uj0oLk/wFIBtD1O6hqNs35aFpGA6gOXL4cbwih31CEm81ce2w?=
 =?us-ascii?Q?qsedq4Zmv/WgaMwxaXso+caueOAVGy81GSdbRTz09iK5/Z0lr8e7bs50J0Fa?=
 =?us-ascii?Q?c95Bb1jcjVIdGt/4morVsdQamBxMmxqHsPpIoB59OdB7R7m0f76f7wTiaN5+?=
 =?us-ascii?Q?P2wbFVyEKpnCcEKNl6Ly6MrJXWlIQtxgHgpoJkl7TBsr1G5tu5AaGjAc3oN4?=
 =?us-ascii?Q?03SwItdfU3OVj2PdXo+qwU3XQdrFG+sQcsS73LZofy5hxEjqJT764K1gXGmH?=
 =?us-ascii?Q?9DRO9hPUdWuwqSYIpaG4L89Scc/4abaIEUt9sUtZmCu9xV66P3lpK+cb4ktO?=
 =?us-ascii?Q?fs3LFdqstX9kMmS6fBWVWxZv+4zNMDUs/T/3xtQin6mQwF6WNRsASK574wJC?=
 =?us-ascii?Q?AJwaA7UuQ0Yl+QNT5GXG8ryy8aT+DdTtof08GY5PSbpQWzOVLUhleSvgp+vj?=
 =?us-ascii?Q?4dl7CFfscT2JQcaKSWEnMAaUV+7TMWITFbIksJFBL5WQiPLt8phs6O9z+SCi?=
 =?us-ascii?Q?6w=3D=3D?=
X-MS-Exchange-CrossTenant-Network-Message-Id: c0d58a6b-b00c-4d8a-a9e2-08dc41f4af75
X-MS-Exchange-CrossTenant-AuthSource: CY5PR11MB6366.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 11 Mar 2024 17:57:15.2618
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: IPDe2wgs5Mj5bgn0Srqsy83kZf2id8xg6f1DDg2SKWrVl+F855zEGJqCXaIHjE0VKjnz+7UCdAB+OMuXS3CN5MWKoo01bnbwZqYBBVpwu+8=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: CH3PR11MB8494
X-OriginatorOrg: intel.com

Hi Jason,

On Fri, Mar 08, 2024 at 12:52:32PM -0400, Jason Gunthorpe wrote:
> On Wed, Mar 06, 2024 at 09:58:53PM +0800, Xin Zeng wrote:
> > @@ -258,6 +259,20 @@ struct adf_dc_ops {
> >  	void (*build_deflate_ctx)(void *ctx);
> >  };
> >  
> > +struct qat_migdev_ops {
> > +	int (*init)(struct qat_mig_dev *mdev);
> > +	void (*cleanup)(struct qat_mig_dev *mdev);
> > +	void (*reset)(struct qat_mig_dev *mdev);
> > +	int (*open)(struct qat_mig_dev *mdev);
> > +	void (*close)(struct qat_mig_dev *mdev);
> > +	int (*suspend)(struct qat_mig_dev *mdev);
> > +	int (*resume)(struct qat_mig_dev *mdev);
> > +	int (*save_state)(struct qat_mig_dev *mdev);
> > +	int (*save_setup)(struct qat_mig_dev *mdev);
> > +	int (*load_state)(struct qat_mig_dev *mdev);
> > +	int (*load_setup)(struct qat_mig_dev *mdev, int size);
> > +};
> 
> Why do we still have these ops? There is only one implementation
This is related to the architecture of the QAT driver. The core QAT
module (intel_qat.ko), which exposes the functions required for live
migration, supports multiple devices. Each QAT specific driver registers
the functions that it supports.

Even if live migration is currently supported only by QAT GEN4 devices,
my preference is to keep the qat_vfio_pci module to invoke GEN agnostic
functions. Also, I would prefer to avoid having such functions calling
directly the GEN4 specific implementation.

Regards,

-- 
Giovanni