Received-SPF: pass (google.com: domain of linux-crypto+bounces-2631-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Message-ID: <d7340cb0-8835-4816-9bb1-6ceb6f662b34@intel.com>
Date: Tue, 12 Mar 2024 08:37:04 -0700
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH] crypto: x86/aesni - Update aesni_set_key() to return void
Content-Language: en-US
To: Ard Biesheuvel <ardb@kernel.org>
CC: <linux-kernel@vger.kernel.org>, <linux-crypto@vger.kernel.org>,
	<herbert@gondor.apana.org.au>, <davem@davemloft.net>, <ebiggers@kernel.org>,
	<x86@kernel.org>
References: <20230607053558.GC941@sol.localdomain>
 <20240311213232.128240-1-chang.seok.bae@intel.com>
 <CAMj1kXEQpFhDaxJ-rBb221ggdZEYWPzeoueKJr5SqRx60Ezf-w@mail.gmail.com>
 <7d463faa-94ae-4c62-b3bc-b4d1084e4600@intel.com>
 <CAMj1kXEr3egDCZ+DYrZt8ohG3fA3jEr_D2iLZp+c9yoj3mr5eQ@mail.gmail.com>
From: "Chang S. Bae" <chang.seok.bae@intel.com>
In-Reply-To: <CAMj1kXEr3egDCZ+DYrZt8ohG3fA3jEr_D2iLZp+c9yoj3mr5eQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"; format=flowed
Content-Transfer-Encoding: 7bit
Precedence: bulk
MIME-Version: 1.0
X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1
X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VENCM2VoQmIxZmVQYlFwSXdjV2NtOU5pSzZpU0ZoOGVDS3BFaGdtNXllc3Bs?=
 =?utf-8?B?K1NuL1VtYTl4OXpscUpJSnh5SjdMbE5KSTdDUFBLMldsdDducmxiNnZrbG1F?=
 =?utf-8?B?R05MSnNBRmw4Y1FGZW5ENjhGOEM0bGhyNkZIRHkxVW9xdlIwc0JxTHFRWWQ1?=
 =?utf-8?B?RnljQWliZmczZDRHNU1RWnVwUjNiMzZtV2FJWjV0ZXRUamplMkpMT25tVnlt?=
 =?utf-8?B?NzBqQlBDVis2bFd2T2FhWEMxWlFKYjhpMkxvR0NEV3NHSGk2SHhZOHRDRjZP?=
 =?utf-8?B?U0F2TzBzUUZxc1RINktVOWNMbmlQdittOThZLzhvMlZLVlBWK3RZaW5PUHoy?=
 =?utf-8?B?QjZQS1N1ZUF1WEMzY0Y0OTZLTXl5OFcvaWVIbXlvZm9oMCt0aUZhMGN3UENW?=
 =?utf-8?B?Y05XNWhCanZTaUxmelh6ejl3T25ST05IamtMTjBEa2o5b2pvZFJEa0s5NUlC?=
 =?utf-8?B?VmIydy9PUzlPaTlIeE5xYXFta3gzWDV2YzlwR0xlT0Y1aVkySHJCaXNVUHVj?=
 =?utf-8?B?bUpxK05PYUpjUEMvbmdPUHNicVFTMk5xMi9tK1NySTY5RmJpYitlL2hLLzJm?=
 =?utf-8?B?ZGFmaFAzNFpUdkovY2k3ZGZ6RzRNMGxQZlhVOWlzQWFNWXI1bXYwK0FnODZX?=
 =?utf-8?B?a0gvY1p4dVgwdnBjMU5LNzdKemg4bGE0bUVoZjZRUm1raHJUT21xYlU4bStk?=
 =?utf-8?B?Q1k0ZXZiNi9xQUZZSUNFNk1veGJyV1JSb3JoRnJQVlVTZUczM0F1NTczeTRq?=
 =?utf-8?B?a2dXK2tJUHRNZTV3ZFdFQll6Y2hlWHhZRGVSNXNIMWpaM1llTmtuZGt2ZHdF?=
 =?utf-8?B?a3J4UUNxTkp4Tm1mNnUzMW5WcmhPMmVSUDl1N0wwRlNPeGl5THFqNnlDWms4?=
 =?utf-8?B?eCtCbWVNYU9FcXdGZ3BEeHVuZ2ppeFB6VUFpcWNLSVFVdDZXbnN6blJpQmZt?=
 =?utf-8?B?VERJMW5FTGkxTTRwU3BtcHM3OFoxN2d6Q1dCWlFPM2gzVTA3WHZueEpJQTdv?=
 =?utf-8?B?cUI2amtVeUFlNEJCUVdsbURiNFpWMEpoM1h4TCtUWnN2WGVNQWZCS2ZnUHZF?=
 =?utf-8?B?VnMra0xadVp6MGpIM2M4SGxKZzJhNkdpY0NHRXQrNllMbzRQeG42N1JtTFN4?=
 =?utf-8?B?YUtlR2w0RnRQOWg3UVd4M3VWSjNOWkNkdVlKT2FrMnl0RlJYOUtRdlZBQ0RL?=
 =?utf-8?B?bHpGeFhsSFlvamlQZnBmTkFRcE9VZlhINHlvRkI3Vk5Ia1drYklmM1pyejFN?=
 =?utf-8?B?RjZlZlRBTmdJR05CUHhuZEI5UTJBQTZmVUR5cHdpdGZzMDZXUWY3QmFjck5R?=
 =?utf-8?B?L0hSKzVXU3lDRkZRdUVXV3g4RTNDSDZZSm54aHBhYmE0Y1V5UFVqT2RyTlZo?=
 =?utf-8?B?c0xWYnpZN2IvN0pOaU1NRU1hbWJZQmgwVExEN0F1akYxNXI0TXZ4Q3ZsSG9C?=
 =?utf-8?B?Y1l3bjFxSHFqQVBzZDZSUzVOQllrS1JWMEtjd2ZpbEpmRmJhaUNZSVZTU1Uw?=
 =?utf-8?B?amZBMFlYS01EMHhXSXJTSE85UnNLVXV4T243SUIvMlZMRXV2TEZRN1VqN0Rk?=
 =?utf-8?B?MWk2ekpZUE1qaEM5bHlneTJuQkJBb1VTTEx2QlMvZmJMM1FpZUh1V1VoUG5o?=
 =?utf-8?B?OG1iNmg4eGN6ZW50bThCVnVxVHh0K1hNdk44NDBDN3FiaW9qRmd1Y1liTEhR?=
 =?utf-8?B?ekZWZkVpUzB1V1VRbmxjbjRtczdrbHJjTU93UUd0V1VJa2pydURTeDIvSnNJ?=
 =?utf-8?B?aWZZMG02R0d0S095YmJoU3N4dzd3emtUanNwUDN1WXBLRmxrUm03NlNjcHVa?=
 =?utf-8?B?YUZXMm9qWUd3OTZZUXJyaDJ2SkNsWnRqNDZMQ25rL1Uxb3lqczd1YVJWMnJx?=
 =?utf-8?B?WVFUYmZDdFZveXVJQk5KMjRDaStKRS9YVjE5Tzl4YXBaRVFyaFNSdzRkdUI5?=
 =?utf-8?B?TG9tQ3dGMlJDcCtWeHFVTkpvUTFnY2VadXh5aGw3dkNsWHpyWmpZb0p1TTZu?=
 =?utf-8?B?eUVwZENoMjhBTmswVVJ5VitZR0pyOEo0dGZBRkVoRlgzZjBDalY2dTlEalZr?=
 =?utf-8?B?MWpTY00wUWNEbE8yOW5TUnpUcEJqVnNmTHVHUWFkNDBGYm1vbGVrRzhlV0E5?=
 =?utf-8?B?N3FwL2xYQ05CR3N2cVhnSitEcDliRnIxTXpRamcwY3QrRktsVFdya2dVb3hn?=
 =?utf-8?B?T1E9PQ==?=
X-MS-Exchange-CrossTenant-Network-Message-Id: 132fb284-9f10-4804-663d-08dc42aa4647
X-MS-Exchange-CrossTenant-AuthSource: MW4PR11MB7164.namprd11.prod.outlook.com
X-MS-Exchange-CrossTenant-AuthAs: Internal
X-MS-Exchange-CrossTenant-OriginalArrivalTime: 12 Mar 2024 15:37:07.2294
 (UTC)
X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted
X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d
X-MS-Exchange-CrossTenant-MailboxType: HOSTED
X-MS-Exchange-CrossTenant-UserPrincipalName: tb1BooILoi8fSqWUP0DOzYAj/Q6ED+B3w+4apEqJJMorSry/bj2RPK8GlaslYpSs0f4W9d/KoxuhotE026825fcXbvPj1ZQSJuqnrCbd78Q=
X-MS-Exchange-Transport-CrossTenantHeadersStamped: LV8PR11MB8510
X-OriginatorOrg: intel.com

On 3/12/2024 8:18 AM, Ard Biesheuvel wrote:
> 
> I wonder whether we need aesni_set_key() at all.

The following looks to be relevant from the AES-NI whitepaper [1]:

The Relative Cost of the Key Expansion
     ...
     Some less frequent applications require frequent key scheduling. For
     example, some random number generators may rekey frequently to
     achieve forward secrecy. One extreme example is a Davies-Meyer
     hashing construction, which uses a block cipher primitive as a
     compression function, and the cipher is re-keyed for each processed
     data block.

     Although these are not the mainstream usage models of the AES
     instructions, we point out that the AESKEYGENASSIST and AESIMC
     instructions facilitate Key Expansion procedure which is lookup
     tables free, and faster than software only key expansion. In
     addition, we point out that unrolling of the key expansion code,
     which is provided in the previous sections, improves the key
     expansion performance. The AES256 case can also utilize the
     instruction AESENCLAST, for the sbox transformation, that is faster
     than using AESKEYGENASSIST.

[1] 
https://www.intel.com/content/dam/doc/white-paper/advanced-encryption-standard-new-instructions-set-paper.pdf

Thanks,
Chang