Received-SPF: pass (google.com: domain of linux-crypto+bounces-2679-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Precedence: bulk
Mime-Version: 1.0
Content-Transfer-Encoding: quoted-printable
Content-Type: text/plain; charset=UTF-8
Date: Thu, 14 Mar 2024 09:11:08 +0100
Message-Id: <CZTBKHQZXJTR.3VMFEA8MZSP5W@matfyz.cz>
To: "Eric Biggers" <ebiggers@kernel.org>
From: "Karel Balej" <balejk@matfyz.cz>
Cc: <keyrings@vger.kernel.org>, <linux-wireless@vger.kernel.org>,
        <iwd@lists.linux.dev>, "James Prestwood" <prestwoj@gmail.com>,
        "Dimitri
 John Ledkov" <dimitri.ledkov@canonical.com>,
        <linux-crypto@vger.kernel.org>,
        "Herbert Xu" <herbert@gondor.apana.org.au>
Subject: Re: [PATCH] Revert "crypto: pkcs7 - remove sha1 support"
References: <20240313233227.56391-1-ebiggers@kernel.org>
In-Reply-To: <20240313233227.56391-1-ebiggers@kernel.org>

Eric,

Eric Biggers, 2024-03-13T16:32:27-07:00:
> From: Eric Biggers <ebiggers@google.com>
>
> This reverts commit 16ab7cb5825fc3425c16ad2c6e53d827f382d7c6 because it
> broke iwd.  iwd uses the KEYCTL_PKEY_* UAPIs via its dependency libell,
> and apparently it is relying on SHA-1 signature support.  These UAPIs
> are fairly obscure, and their documentation does not mention which
> algorithms they support.  iwd really should be using a properly
> supported userspace crypto library instead.  Regardless, since something
> broke we have to revert the change.
>
> It may be possible that some parts of this commit can be reinstated
> without breaking iwd (e.g. probably the removal of MODULE_SIG_SHA1), but
> for now this just does a full revert to get things working again.
>
> Reported-by: Karel Balej <balejk@matfyz.cz>
> Closes: https://lore.kernel.org/r/CZSHRUIJ4RKL.34T4EASV5DNJM@matfyz.cz
> Cc: Dimitri John Ledkov <dimitri.ledkov@canonical.com>
> Signed-off-by: Eric Biggers <ebiggers@google.com>

thank you very much for the revert. I have compiled 6.8 with this patch
and attest that it solves my eduroam connection issue.

Tested-by: Karel Balej <balejk@matfyz.cz>

May I please ask, though, why you did not Cc stable (and add a Fixes
trailer for that matter)? It seems like something that would be nice to
see fixed in 6.7.y and 6.8.y too as soon as possible.

Kind regards,
K. B.