Received-SPF: pass (google.com: domain of linux-crypto+bounces-2579-linux.lists.archive=gmail.com@vger.kernel.org designates 2604:1380:4601:e00::3 as permitted sender) client-ip=2604:1380:4601:e00::3;
Date: Fri, 8 Mar 2024 18:19:02 +0800
From: Herbert Xu <herbert@gondor.apana.org.au>
To: WangYuli <wangyuli@uniontech.com>
Cc: davem@davemloft.net, chenhuacai@kernel.org, kernel@xen0n.name,
	linux-crypto@vger.kernel.org, loongarch@lists.linux.dev,
	linux-kernel@vger.kernel.org, wangyuli@uniontech.com,
	guanwentao@uniontech.com
Subject: Re: [PATCH v2] LoongArch/crypto: Clean up useless assignment
 operations
Message-ID: <ZermFgvsJymZkz4u@gondor.apana.org.au>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <79D75E042AE5B03F+20240229100449.1001261-1-wangyuli@uniontech.com>

WangYuli <wangyuli@uniontech.com> wrote:
> The LoongArch CRC32 hw acceleration is based on
> arch/mips/crypto/crc32-mips.c. While the MIPS code supports both
> MIPS32 and MIPS64, LA32 lacks the CRC instruction. As a result,
> "line len -= sizeof(u32)" is unnecessary.
> 
> Removing it can make context code style more unified and improve
> code readability.
> 
> Suggested-by: Guan Wentao <guanwentao@uniontech.com>
> Signed-off-by: WangYuli <wangyuli@uniontech.com>
> ---
> arch/loongarch/crypto/crc32-loongarch.c | 2 --
> 1 file changed, 2 deletions(-)
> 
> diff --git a/arch/loongarch/crypto/crc32-loongarch.c b/arch/loongarch/crypto/crc32-loongarch.c
> index a49e507af38c..3eebea3a7b47 100644
> --- a/arch/loongarch/crypto/crc32-loongarch.c
> +++ b/arch/loongarch/crypto/crc32-loongarch.c
> @@ -44,7 +44,6 @@ static u32 crc32_loongarch_hw(u32 crc_, const u8 *p, unsigned int len)
> 
>                CRC32(crc, value, w);
>                p += sizeof(u32);
> -               len -= sizeof(u32);
>        }

This makes no sense whatsoever.  Please review this patch carefully
before you resubmit.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt