Received-SPF: pass (google.com: domain of linux-crypto+bounces-2713-linux.lists.archive=gmail.com@vger.kernel.org designates 147.75.80.249 as permitted sender) client-ip=147.75.80.249;
Date: Mon, 18 Mar 2024 12:46:48 -0700
From: Jerry Snitselaar <jsnitsel@redhat.com>
To: Tom Zanussi <tom.zanussi@linux.intel.com>
Cc: Jonathan Corbet <corbet@lwn.net>, linux-crypto@vger.kernel.org, 
	linux-doc@vger.kernel.org
Subject: Re: [PATCH] crypto: iaa: Fix some errors in IAA documentation
Message-ID: <cj6rfdhse7lcmj47ux5wba4kfpvjezx7wp5apc2k5gv5gd22ad@fvzpsmxs2ott>
References: <20240318064421.833348-1-jsnitsel@redhat.com>
 <jhpuhcengkgdpgyb7qsez4lugpa5nhjjn3zqehbcbrtr2xh5md@cc3vz7v2xzdu>
 <f6487dcb03a31c35c272225197af87795df2a409.camel@linux.intel.com>
 <hdb2l73guzxz2ck5qbkvpmpfiez646t33ocfqawdgxrnemwrpp@izvr4k6b2jft>
 <64229faa848b78d263a9383f664b0c269ffd65c3.camel@linux.intel.com>
Precedence: bulk
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <64229faa848b78d263a9383f664b0c269ffd65c3.camel@linux.intel.com>

On Mon, Mar 18, 2024 at 02:01:18PM -0500, Tom Zanussi wrote:
...
> > 
> > This is what I came up with last night for the kernel parameters when thinking about it:
> > 
> > 
> > > mode \ default enable | intel_iommu + /sm + | intel_iommu + / sm - | intel_iommu - / sm +? | intel_iommu - / sm - |
> > > -----------------------+---------------------+----------------------+-----------------------+----------------------|
> > > Scalable Mode???????? | nothing???????????? | intel_iommu=sm_on??? | intel_iommu=on??????? | intel_iommu=on,sm_on |
> > > Legacy Mode?????????? | intel_iommu=sm_off? | nothing????????????? | intel_iommu=on,sm_off | intel_iommu=on?????? |
> > > No IOMMU Mode???????? | intel_iommu=off???? | intel_iommu=off????? | nothing?????????????? | nothing????????????? |
> > 
> 
> Very nice. I think it would need a little explanation on how to read
> the table and mention of how the defaults correspond to actual config
> options e.g. sm+ = CONFIG_INTEL_IOMMU_SCALABLE_MODE_DEFAULT_ON=y,
> etc...
> 
> Thanks,
> 
> Tom
>

Yes, if something like this were to go into the doc it would need more
explanation. This was me just trying to map out the different
combinations last night in an org-mode table in emacs.